From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: bp@alien8.de, david.kaplan@amd.com, linux-kernel@vger.kernel.org,
x86@kernel.org
Subject: Re: [RFC][PATCH 2/2] x86: Clean up default rethunk warning
Date: Wed, 9 Oct 2024 09:59:40 +0200 [thread overview]
Message-ID: <20241009075940.GI17263@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241008164514.ky7ybaoitytvbwlp@treble>
On Tue, Oct 08, 2024 at 09:45:14AM -0700, Josh Poimboeuf wrote:
> On Tue, Oct 08, 2024 at 09:25:02AM +0200, Peter Zijlstra wrote:
> > On Mon, Oct 07, 2024 at 10:33:45AM -0700, Josh Poimboeuf wrote:
> > > On Mon, Oct 07, 2024 at 10:32:12AM +0200, Peter Zijlstra wrote:
> > > > Replace the funny __warn_thunk thing with a more regular
> > > > WARN_ON_ONCE(), and simplify the ifdeffery.
> > > >
> > > > Notably this avoids RET from having recursive RETs (once from the
> > > > thunk and once from the C function) -- recursive RET makes my head
> > > > hurt for no good reason.
> > >
> > > This could use an explanation for why the ifdefs can be removed and why
> > > the alternative can be removed.
> >
> > The alternative is in the WARN_ONCE now.
>
> Ah, sneaky... It should really be called WARN_ONCE_AFTER_ALTERNATIVES or
> something.
Yeah, I suppose it should.
next prev parent reply other threads:[~2024-10-09 7:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 8:32 [RFC][PATCH 0/2] x86: ASM based __bug_table and rethunks Peter Zijlstra
2024-10-07 8:32 ` [RFC][PATCH 1/2] x86: Provide assembly __bug_table helpers Peter Zijlstra
2024-10-07 17:21 ` Josh Poimboeuf
2024-10-23 11:22 ` Borislav Petkov
2024-10-07 8:32 ` [RFC][PATCH 2/2] x86: Clean up default rethunk warning Peter Zijlstra
2024-10-07 17:33 ` Josh Poimboeuf
2024-10-08 7:25 ` Peter Zijlstra
2024-10-08 16:45 ` Josh Poimboeuf
2024-10-09 7:59 ` Peter Zijlstra [this message]
2024-11-04 11:47 ` Borislav Petkov
2024-11-04 14:29 ` Peter Zijlstra
2024-11-04 14:39 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009075940.GI17263@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=david.kaplan@amd.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox