From: Peter Zijlstra <peterz@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Ankur Arora <ankur.a.arora@oracle.com>,
tglx@linutronix.de, mingo@kernel.org,
linux-kernel@vger.kernel.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
vschneid@redhat.com, efault@gmx.de
Subject: Re: [PATCH 0/5] sched: Lazy preemption muck
Date: Wed, 9 Oct 2024 10:02:02 +0200 [thread overview]
Message-ID: <20241009080202.GJ17263@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20241009062019.1FJYnQL1@linutronix.de>
On Wed, Oct 09, 2024 at 08:20:19AM +0200, Sebastian Andrzej Siewior wrote:
> On 2024-10-08 21:40:05 [-0700], Ankur Arora wrote:
> > > While comparing this vs what I have:
> > > - need_resched()
> > > It checked both (tif_need_resched_lazy() || tif_need_resched()) while
> > > now it only looks at tif_need_resched().
> > > Also ensured that raw_irqentry_exit_cond_resched() does not trigger on
> > > lazy.
> > > I guess you can argue both ways what makes sense, just noting…
> >
> > I think we want need_resched() to be only tif_need_resched(). That way
> > preemption in lazy mode *only* happens at the user mode boundary.
>
> There are places such as __clear_extent_bit() or select_collect() where
> need_resched() is checked and if 0 they loop again. For these kind of
> users it would probably make sense to allow them to preempt themself.
> We could also add a new function which checks both and audit all users
> and check what would make sense base on $criteria.
Do we really need this -- wasn't the idea to have thing 'delay' until
the actual NEED_RESCHED bit gets set?
next prev parent reply other threads:[~2024-10-09 8:02 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 7:46 [PATCH 0/5] sched: Lazy preemption muck Peter Zijlstra
2024-10-07 7:46 ` [PATCH 1/5] sched: Add TIF_NEED_RESCHED_LAZY infrastructure Peter Zijlstra
2024-10-09 12:18 ` Sebastian Andrzej Siewior
2024-10-09 13:01 ` Peter Zijlstra
2024-11-06 10:48 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2024-10-07 7:46 ` [PATCH 2/5] sched: Add Lazy preemption model Peter Zijlstra
2024-10-08 5:43 ` Ankur Arora
2024-10-08 14:48 ` Peter Zijlstra
2024-10-09 8:50 ` Sebastian Andrzej Siewior
2024-10-09 9:14 ` Peter Zijlstra
2024-10-09 9:19 ` Sebastian Andrzej Siewior
2024-10-15 14:37 ` Shrikanth Hegde
2024-10-25 10:42 ` Sebastian Andrzej Siewior
2024-10-22 16:44 ` Shrikanth Hegde
2024-10-25 13:19 ` Sebastian Andrzej Siewior
2024-10-29 18:57 ` Shrikanth Hegde
2024-11-06 10:48 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2024-10-07 7:46 ` [PATCH 3/5] sched: Enable PREEMPT_DYNAMIC for PREEMPT_RT Peter Zijlstra
2024-10-08 13:24 ` Sebastian Andrzej Siewior
2024-10-08 14:40 ` Peter Zijlstra
2024-10-10 6:52 ` Christoph Hellwig
2024-10-10 7:50 ` Peter Zijlstra
2024-11-06 10:48 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2024-10-07 7:46 ` [PATCH 4/5] sched, x86: Enable Lazy preemption Peter Zijlstra
2024-11-06 10:48 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2024-10-07 7:46 ` [PATCH 5/5] sched: Add laziest preempt model Peter Zijlstra
2024-10-08 5:59 ` Ankur Arora
2024-10-08 14:23 ` Thomas Gleixner
2024-10-08 14:40 ` Peter Zijlstra
2024-10-08 15:07 ` Sebastian Andrzej Siewior
2024-10-07 8:33 ` [PATCH 0/5] sched: Lazy preemption muck Sebastian Andrzej Siewior
2024-10-08 4:58 ` Mike Galbraith
2024-10-08 15:32 ` Sebastian Andrzej Siewior
2024-10-09 4:40 ` Ankur Arora
2024-10-09 6:20 ` Sebastian Andrzej Siewior
2024-10-09 7:23 ` Ankur Arora
2024-10-09 8:02 ` Peter Zijlstra [this message]
2024-10-09 8:45 ` Sebastian Andrzej Siewior
2024-10-09 14:01 ` Steven Rostedt
2024-10-09 20:13 ` Thomas Gleixner
2024-10-09 20:43 ` Steven Rostedt
2024-10-09 21:06 ` Thomas Gleixner
2024-10-09 21:19 ` Steven Rostedt
2024-10-09 23:16 ` Thomas Gleixner
2024-10-09 23:29 ` Steven Rostedt
2024-10-10 1:20 ` Thomas Gleixner
2024-10-10 10:23 ` David Laight
2024-10-13 19:02 ` Thomas Gleixner
2024-10-14 8:21 ` David Laight
2024-10-10 3:12 ` Tianchen Ding
2024-10-10 7:47 ` Thomas Gleixner
2024-10-09 7:30 ` Ankur Arora
2024-10-09 7:46 ` Peter Zijlstra
2024-10-09 11:07 ` Sebastian Andrzej Siewior
2024-10-17 12:36 ` Mike Galbraith
2024-11-07 17:21 ` Thomas Meyer
2024-11-08 0:59 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009080202.GJ17263@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ankur.a.arora@oracle.com \
--cc=bigeasy@linutronix.de \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=efault@gmx.de \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox