From: Lee Jones <lee@kernel.org>
To: Dipendra Khadka <kdipendra88@gmail.com>
Cc: avel@ucw.cz, lee@kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: leds: replace divide condition 'shift / 16' with 'shift >= 16'
Date: Wed, 9 Oct 2024 14:37:52 +0100 [thread overview]
Message-ID: <20241009133643.GI276481@google.com> (raw)
In-Reply-To: <20240922174020.49856-1-kdipendra88@gmail.com>
Staging! Why Staging?
On Sun, 22 Sep 2024, Dipendra Khadka wrote:
> Smatch reported following:
> '''
> drivers/leds/leds-bcm6328.c:116 bcm6328_led_mode() warn: replace divide condition 'shift / 16' with 'shift >= 16'
> drivers/leds/leds-bcm6328.c:360 bcm6328_led() warn: replace divide condition 'shift / 16' with 'shift >= 16'
> '''
> Replacing 'shift / 16' with 'shift >= 16'.
More info please.
- What is the current problem you're attempting to solve?
- How does this patch help with that?
- What are the consequences for not applying this fix?
> Signed-off-by: Dipendra Khadka <kdipendra88@gmail.com>
> ---
> drivers/leds/leds-bcm6328.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/leds-bcm6328.c b/drivers/leds/leds-bcm6328.c
> index 246f1296ab09..13f535ccba0b 100644
> --- a/drivers/leds/leds-bcm6328.c
> +++ b/drivers/leds/leds-bcm6328.c
> @@ -113,7 +113,7 @@ static void bcm6328_led_mode(struct bcm6328_led *led, unsigned long value)
> unsigned long val, shift;
>
> shift = bcm6328_pin2shift(led->pin);
> - if (shift / 16)
> + if (shift >= 16)
> mode = led->mem + BCM6328_REG_MODE_HI;
> else
> mode = led->mem + BCM6328_REG_MODE_LO;
> @@ -357,7 +357,7 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg,
> break;
> case LEDS_DEFSTATE_KEEP:
> shift = bcm6328_pin2shift(led->pin);
> - if (shift / 16)
> + if (shift >= 16)
> mode = mem + BCM6328_REG_MODE_HI;
> else
> mode = mem + BCM6328_REG_MODE_LO;
> --
> 2.43.0
>
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-10-09 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-22 17:40 [PATCH] Staging: leds: replace divide condition 'shift / 16' with 'shift >= 16' Dipendra Khadka
2024-09-26 10:14 ` Pavel Machek
2024-10-09 13:37 ` Lee Jones [this message]
2024-10-11 11:24 ` Pavel Machek
2024-10-15 9:01 ` Lee Jones
2024-10-17 19:23 ` Dipendra Khadka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241009133643.GI276481@google.com \
--to=lee@kernel.org \
--cc=avel@ucw.cz \
--cc=kdipendra88@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox