public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mfd: bd96801: Add ERRB IRQ
Date: Wed, 9 Oct 2024 17:11:13 +0100	[thread overview]
Message-ID: <20241009161113.GA661995@google.com> (raw)
In-Reply-To: <dda4464443fba81f79d5f8d73947dbd63083cff2.1727931468.git.mazziesaccount@gmail.com>

On Thu, 03 Oct 2024, Matti Vaittinen wrote:

> The ROHM BD96801 "scalable PMIC" provides two physical IRQs. The ERRB
> handling can in many cases be omitted because it is used to inform fatal
> IRQs, which usually kill the power from the SOC.
> 
> There may however be use-cases where the SOC has a 'back-up' emergency
> power source which allows some very short time of operation to try to
> gracefully shut down sensitive hardware. Furthermore, it is possible the
> processor controlling the PMIC is not powered by the PMIC. In such cases
> handling the ERRB IRQs may be beneficial.
> 
> Add support for ERRB IRQs.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> ---
> Revision history:
> New series (only ERRB addition)
> v2:
> 	- Suffle local variables in probe()
> 	- Unify and improve the error prints when adding regmap IRQ chip for
> 	  INTB or ERRB fails.
> v1:
> 	- use devm allocation for regulator_res
> 	- use goto skip_errb instead of an if (errb)
> 	- constify immutable structs
> 
> Old series (All BD96801 functionality + irqdomain and regmap changes)
> v2 => v3:
> 	- No changes
> v1 => v2:
> 	- New patch
> ---
>  drivers/mfd/rohm-bd96801.c | 275 ++++++++++++++++++++++++++++++++-----
>  1 file changed, 241 insertions(+), 34 deletions(-)

Are the 2 patches tied together or can they be taken separately?

-- 
Lee Jones [李琼斯]

  reply	other threads:[~2024-10-09 16:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-03  5:33 [PATCH v2 0/2] ROHM BD96801 Support ERRB IRQ Matti Vaittinen
2024-10-03  5:34 ` [PATCH v2 1/2] mfd: bd96801: Add " Matti Vaittinen
2024-10-09 16:11   ` Lee Jones [this message]
2024-10-10  6:06     ` Matti Vaittinen
2024-10-15 13:34   ` (subset) " Lee Jones
2024-10-03  5:34 ` [PATCH v2 2/2] regulator: " Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241009161113.GA661995@google.com \
    --to=lee@kernel.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox