public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Damato <jdamato@fastly.com>
To: netdev@vger.kernel.org
Cc: michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
	Joe Damato <jdamato@fastly.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org (open list),
	Michael Chan <mchan@broadcom.com>,
	Paolo Abeni <pabeni@redhat.com>
Subject: [net-next v4 0/2] tg3: Link IRQs, NAPIs, and queues
Date: Wed,  9 Oct 2024 17:55:07 +0000	[thread overview]
Message-ID: <20241009175509.31753-1-jdamato@fastly.com> (raw)

Greetings:

Welcome to v4, now an actual submission instead of an RFC.

This follows from a previous RFC (wherein I botched the subject lines of
all the messages) [1].

I've taken Michael Chan's suggestion on modifying patch 2 and I've
updated the commit messages of both patches to test and show the output
for the default 1 TX 4 RX queues and the 4 TX and 4 RX queues cases.

Reviewers: please check the commit messages carefully to ensure the
output is correct (or on your own systems to verify, if you like). I am
not a tg3 expert and it's possible that I got something wrong.

Thanks,
Joe

[1]: https://lore.kernel.org/all/20241005145717.302575-3-jdamato@fastly.com/T/

v4:
  - Upgraded from RFC to official submission
  - Patch 1:
    - Updated commit message to test more cases, no code or functional
      changes, so I retained the Reviewed-by
  - Patch 2:
    - Switched the if ... else if ... to two ifs as per Michael Chan's
      suggestion when tg3 uses combined tx and rx queues
    - Updated commit message to test more cases, including combined tx
      and rx queues

rfcv3:
  - Patch 1:
    - Line wrap to 80 characters, no functional changes
    - Added Pavan Chebbi's Reviewed-by
  - Patch 2:
    - changed tg3_napi_enable and tg3_napi_disable to use running
      counters to number the queues as there is no explicit queue index
      assigned in tg3

Joe Damato (2):
  tg3: Link IRQs to NAPI instances
  tg3: Link queues to NAPIs

 drivers/net/ethernet/broadcom/tg3.c | 47 ++++++++++++++++++++++++-----
 1 file changed, 40 insertions(+), 7 deletions(-)

-- 
2.25.1


             reply	other threads:[~2024-10-09 17:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 17:55 Joe Damato [this message]
2024-10-09 17:55 ` [net-next v4 1/2] tg3: Link IRQs to NAPI instances Joe Damato
2024-10-09 22:40   ` Michael Chan
2024-10-09 17:55 ` [net-next v4 2/2] tg3: Link queues to NAPIs Joe Damato
2024-10-09 22:36   ` Michael Chan
2024-10-11  1:50 ` [net-next v4 0/2] tg3: Link IRQs, NAPIs, and queues patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241009175509.31753-1-jdamato@fastly.com \
    --to=jdamato@fastly.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchan@broadcom.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox