Re: [PATCHv3 5/5] documentation: use nvmem-layout in examples

Krzysztof Kozlowski
2024-10-10T04:50:39Z

On 09/10/2024 23:48, Rosen Penev wrote:
> nvmem-cells are deprecated and replaced with nvmem-layout. For these
> examples, replace. They're not relevant to the main point of the
> document anyway.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

You already got this comment, is something unclear?

> .../mtd/partitions/qcom,smem-part.yaml | 21 +++++++++++--------
> .../bindings/net/marvell,aquantia.yaml | 13 +++++++-----
> 2 files changed, 20 insertions(+), 14 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml
> index 1c2b4e780ca9..c2cc11286d80 100644
> --- a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml
> +++ b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml
> @@ -23,7 +23,7 @@ properties:
>
> patternProperties:
> "^partition-[0-9a-z]+$":
> - $ref: nvmem-cells.yaml
> + $ref: nvmem-layout.yaml

There is no such file here, so this should be full path /schemas/nvmem/....

but is this a nvmem? Looks like MTD and NAND. Previously this was a
partition, now it is not. I don't understand what you are trying to
achieve here.

Best regards,
Krzysztof