From: linux@treblig.org
To: perex@perex.cz, tiwai@suse.com
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: [PATCH] ALSA: core: Remove unused copy_from_user_toio
Date: Thu, 10 Oct 2024 21:53:40 +0100 [thread overview]
Message-ID: <20241010205340.278133-1-linux@treblig.org> (raw)
From: "Dr. David Alan Gilbert" <linux@treblig.org>
copy_from_user_toio() has been unused since commit
ce2d8ed8d809 ("ASoC: qcom: Convert to generic PCM copy ops")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
include/sound/core.h | 1 -
sound/core/memory.c | 20 --------------------
2 files changed, 21 deletions(-)
diff --git a/include/sound/core.h b/include/sound/core.h
index 1f3f5dccd736..b5a6f3d2bff5 100644
--- a/include/sound/core.h
+++ b/include/sound/core.h
@@ -267,7 +267,6 @@ static inline int snd_minor_info_oss_init(void) { return 0; }
/* memory.c */
int copy_to_user_fromio(void __user *dst, const volatile void __iomem *src, size_t count);
-int copy_from_user_toio(volatile void __iomem *dst, const void __user *src, size_t count);
/* init.c */
diff --git a/sound/core/memory.c b/sound/core/memory.c
index 2d2d0094c897..8222a851da87 100644
--- a/sound/core/memory.c
+++ b/sound/core/memory.c
@@ -63,26 +63,6 @@ int copy_to_iter_fromio(struct iov_iter *dst, const void __iomem *src,
}
EXPORT_SYMBOL(copy_to_iter_fromio);
-/**
- * copy_from_user_toio - copy data from user-space to mmio-space
- * @dst: the destination pointer on mmio-space
- * @src: the source pointer on user-space
- * @count: the data size to copy in bytes
- *
- * Copies the data from user-space to mmio-space.
- *
- * Return: Zero if successful, or non-zero on failure.
- */
-int copy_from_user_toio(volatile void __iomem *dst, const void __user *src, size_t count)
-{
- struct iov_iter iter;
-
- if (import_ubuf(ITER_SOURCE, (void __user *)src, count, &iter))
- return -EFAULT;
- return copy_from_iter_toio((void __iomem *)dst, &iter, count);
-}
-EXPORT_SYMBOL(copy_from_user_toio);
-
/**
* copy_from_iter_toio - copy data from iov_iter to mmio-space
* @dst: the destination pointer on mmio-space
--
2.47.0
next reply other threads:[~2024-10-10 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-10 20:53 linux [this message]
2024-10-11 9:12 ` [PATCH] ALSA: core: Remove unused copy_from_user_toio Takashi Iwai
2024-10-11 10:57 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241010205340.278133-1-linux@treblig.org \
--to=linux@treblig.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox