From: Chi Zhiling <chizhiling@163.com>
To: cem@kernel.org, djwong@kernel.org
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
chizhiling <chizhiling@kylinos.cn>
Subject: [PATCH] xfs_logprint: Fix super block buffer interpretation issue
Date: Fri, 11 Oct 2024 11:08:10 +0800 [thread overview]
Message-ID: <20241011030810.1083636-1-chizhiling@163.com> (raw)
From: chizhiling <chizhiling@kylinos.cn>
When using xfs_logprint to interpret the buffer of the super block, the
icount will always be 6360863066640355328 (0x5846534200001000). This is
because the offset of icount is incorrect, causing xfs_logprint to
misinterpret the MAGIC number as icount.
This patch fixes the offset value of the SB counters in xfs_logprint.
Before this patch:
icount: 6360863066640355328 ifree: 5242880 fdblks: 0 frext: 0
After this patch:
icount: 10240 ifree: 4906 fdblks: 37 frext: 0
Signed-off-by: chizhiling <chizhiling@kylinos.cn>
---
logprint/log_misc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/logprint/log_misc.c b/logprint/log_misc.c
index 8e86ac34..21da5b8b 100644
--- a/logprint/log_misc.c
+++ b/logprint/log_misc.c
@@ -288,13 +288,13 @@ xlog_print_trans_buffer(char **ptr, int len, int *i, int num_ops)
/*
* memmove because *ptr may not be 8-byte aligned
*/
- memmove(&a, *ptr, sizeof(__be64));
- memmove(&b, *ptr+8, sizeof(__be64));
+ memmove(&a, *ptr + offsetof(struct xfs_dsb, sb_icount), sizeof(__be64));
+ memmove(&b, *ptr + offsetof(struct xfs_dsb, sb_ifree), sizeof(__be64));
printf(_("icount: %llu ifree: %llu "),
(unsigned long long) be64_to_cpu(a),
(unsigned long long) be64_to_cpu(b));
- memmove(&a, *ptr+16, sizeof(__be64));
- memmove(&b, *ptr+24, sizeof(__be64));
+ memmove(&a, *ptr + offsetof(struct xfs_dsb, sb_fdblocks), sizeof(__be64));
+ memmove(&b, *ptr + offsetof(struct xfs_dsb, sb_frextents), sizeof(__be64));
printf(_("fdblks: %llu frext: %llu\n"),
(unsigned long long) be64_to_cpu(a),
(unsigned long long) be64_to_cpu(b));
--
2.43.0
next reply other threads:[~2024-10-11 3:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 3:08 Chi Zhiling [this message]
2024-10-11 3:24 ` [PATCH] xfs_logprint: Fix super block buffer interpretation issue Darrick J. Wong
2024-10-11 3:54 ` Chi Zhiling
2024-10-12 22:10 ` Dave Chinner
[not found] ` <e0ae8eb7-360a-40c4-8c84-dd439d7161fd@163.com>
2024-10-13 22:50 ` Dave Chinner
2024-10-14 5:51 ` Chi Zhiling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241011030810.1083636-1-chizhiling@163.com \
--to=chizhiling@163.com \
--cc=cem@kernel.org \
--cc=chizhiling@kylinos.cn \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox