From: Jason Gunthorpe <jgg@ziepe.ca>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Kevin Tian <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>,
Vasant Hegde <vasant.hegde@amd.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] iommu/vt-d: Add domain_alloc_paging support
Date: Fri, 11 Oct 2024 13:33:01 -0300 [thread overview]
Message-ID: <20241011163301.GQ762027@ziepe.ca> (raw)
In-Reply-To: <20241011132252.GJ762027@ziepe.ca>
On Fri, Oct 11, 2024 at 10:22:52AM -0300, Jason Gunthorpe wrote:
> On Fri, Oct 11, 2024 at 12:27:16PM +0800, Lu Baolu wrote:
>
> > +static struct iommu_domain *intel_iommu_domain_alloc_paging(struct device *dev)
> > +{
> > + struct dmar_domain *dmar_domain;
> > + bool first_stage;
> > +
> > + first_stage = first_level_by_default(0);
> > + dmar_domain = paging_domain_alloc(dev, first_stage);
> > + if (IS_ERR(dmar_domain))
> > + return ERR_CAST(dmar_domain);
> > +
> > + return &dmar_domain->domain;
> > +}
>
> With the direction that Vasant's series is going in, I think this
> should be skipped and instead your other patch to make
> domain_alloc_user (which we will rename) a full functional replacement
> is the right thing.
Though I guess for patch ordering purposes it makes sense to just
leave this and remove it the next cycle
Jason
next prev parent reply other threads:[~2024-10-11 16:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 4:27 [PATCH 0/7] iommu/vt-d: Add domain_alloc_paging support Lu Baolu
2024-10-11 4:27 ` [PATCH 1/7] " Lu Baolu
2024-10-11 13:22 ` Jason Gunthorpe
2024-10-11 16:33 ` Jason Gunthorpe [this message]
2024-10-14 0:53 ` Baolu Lu
2024-10-14 19:23 ` Jason Gunthorpe
2024-10-11 4:27 ` [PATCH 2/7] iommu/vt-d: Remove unused domain_alloc callback Lu Baolu
2024-10-11 16:17 ` Jason Gunthorpe
2024-10-11 4:27 ` [PATCH 3/7] iommu/vt-d: Enhance compatibility check for paging domain attach Lu Baolu
2024-10-11 16:27 ` Jason Gunthorpe
2024-10-14 1:25 ` Baolu Lu
2024-10-14 19:24 ` Jason Gunthorpe
2024-10-15 2:52 ` Baolu Lu
2024-10-15 12:48 ` Jason Gunthorpe
2024-10-16 1:46 ` Baolu Lu
2024-10-11 4:27 ` [PATCH 4/7] iommu/vt-d: Remove domain_update_iommu_cap() Lu Baolu
2024-10-11 16:30 ` Jason Gunthorpe
2024-10-11 4:27 ` [PATCH 5/7] iommu/vt-d: Remove domain_update_iommu_superpage() Lu Baolu
2024-10-11 16:30 ` Jason Gunthorpe
2024-10-11 4:27 ` [PATCH 6/7] iommu/vt-d: Refactor first_level_by_default() Lu Baolu
2024-10-11 16:31 ` Jason Gunthorpe
2024-10-11 4:27 ` [PATCH 7/7] iommu/vt-d: Refine intel_iommu_domain_alloc_user() Lu Baolu
2024-10-11 11:32 ` Jason Gunthorpe
2024-10-11 16:31 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241011163301.GQ762027@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox