Re: [PATCHv6 net-next 2/7] net: ibm: emac: remove custom init/exit functions

Simon Horman
2024-10-12T12:59:15Z

On Fri, Oct 11, 2024 at 12:56:17PM -0700, Rosen Penev wrote:
> c092d0be38f4f754cdbdc76dc6df628ca48ac0eb introduced EPROBE_DEFER

The preferred way to cite commits in patch descriptions is like this:

commit c092d0be38f4 ("net: ibm: emac: remove all waiting code")

Something like this in gitconfig can be helpful.

[core]
abbrev = 12
[pretty]
quote = commit %h (\"%s\")
[alias]
quote = log -1 --pretty=quote

Then the following should work:

$ git quote c092d0be38f4f754cdbdc76dc6df628ca48ac0eb
commit 71eb7f699755 ("net: ibm: emac: use netif_receive_skb_list")

> support. Because of that, we can defer initialization until all modules
> are ready instead of handling it explicitly with custom init/exit
> functions.
>
> As a consequence of removing explicit module initialization and
> deferring probe until everything is ready, there's no need for custom
> init and exit functions.
>
> There are now module_init and module_exit calls but no real change in
> functionality as these init and exit functions are no longer directly
> called by core.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Otherwise, LGTM.