From: Devarsh Thakkar <devarsht@ti.com>
To: <jyri.sarha@iki.fi>, <tomi.valkeinen@ideasonboard.com>,
<airlied@gmail.com>, <maarten.lankhorst@linux.intel.com>,
<mripard@kernel.org>, <tzimmermann@suse.de>,
<dri-devel@lists.freedesktop.org>, <simona@ffwll.ch>,
<linux-kernel@vger.kernel.org>
Cc: <praneeth@ti.com>, <vigneshr@ti.com>, <aradhya.bhatia@linux.dev>,
<s-jain1@ti.com>, <r-donadkar@ti.com>, <sam@ravnborg.org>,
<bparrot@ti.com>, <jcormier@criticallink.com>, <devarsht@ti.com>
Subject: [PATCH 0/2] DSS interrupt related bug fixes
Date: Sat, 12 Oct 2024 20:37:08 +0530 [thread overview]
Message-ID: <20241012150710.261767-1-devarsht@ti.com> (raw)
While reviewing the interrupt related code and register dump, we found couple
of issues related to interrupt related register programming. Firstly, the
function enabling/disabling the interrupts was trying to clear the
interrupts which were not enabled in first place and secondly there is a
potential race scenario between interrupt subroutine and interrupt
enable/disable related functions as they both access interrupt registers
without a common lock. This series addresses the aforementioned problems.
Devarsh Thakkar (2):
drm/tidss: Clear the interrupt status for interrupts being disabled
drm/tidss: Avoid race condition while handling interrupt registers
drivers/gpu/drm/tidss/tidss_dispc.c | 12 ++++++++----
drivers/gpu/drm/tidss/tidss_irq.c | 2 ++
2 files changed, 10 insertions(+), 4 deletions(-)
--
2.39.1
next reply other threads:[~2024-10-12 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-12 15:07 Devarsh Thakkar [this message]
2024-10-12 15:07 ` [PATCH 1/2] drm/tidss: Clear the interrupt status for interrupts being disabled Devarsh Thakkar
2024-10-21 11:15 ` Tomi Valkeinen
2024-10-21 14:46 ` Jon Cormier
2024-10-21 14:48 ` Jon Cormier
2024-10-12 15:07 ` [PATCH 2/2] drm/tidss: Avoid race condition while handling interrupt registers Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241012150710.261767-1-devarsht@ti.com \
--to=devarsht@ti.com \
--cc=airlied@gmail.com \
--cc=aradhya.bhatia@linux.dev \
--cc=bparrot@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jcormier@criticallink.com \
--cc=jyri.sarha@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=praneeth@ti.com \
--cc=r-donadkar@ti.com \
--cc=s-jain1@ti.com \
--cc=sam@ravnborg.org \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox