From: Greg KH <gregkh@linuxfoundation.org>
To: Judith Mendez <jm@ti.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Bin Liu <b-liu@ti.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH RESEND 2/2] serial: 8250: omap: Move pm_runtime_get_sync
Date: Sat, 12 Oct 2024 10:03:26 +0200 [thread overview]
Message-ID: <2024101218-overpay-yoga-7423@gregkh> (raw)
In-Reply-To: <20241011173356.870883-3-jm@ti.com>
On Fri, Oct 11, 2024 at 12:33:56PM -0500, Judith Mendez wrote:
> Currently in omap_8250_shutdown, the dma->rx_running
> flag is set to zero in omap_8250_rx_dma_flush. Next
> pm_runtime_get_sync is called, which is a runtime
> resume call stack which can re-set the flag. When the
> call omap_8250_shutdown returns, the flag is expected
> to be UN-SET, but this is not the case. This is causing
> issues the next time UART is re-opened and omap_8250_rx_dma
> is called. Fix by moving pm_runtime_get_sync before the
> omap_8250_rx_dma_flush.
You can go to 72 columns :)
> Signed-off-by: Bin Liu <b-liu@ti.com>
> Signed-off-by: Judith Mendez <jm@ti.com>
Wait, who wrote this, Bin? If so, there needs to be a "From:" line
saying so.
What commit id does this fix? Do you want it backported to older
kernels? Why mix two different subsystems in the same patch series, who
is supposed to take it?
thanks,
greg k-h
next prev parent reply other threads:[~2024-10-12 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 17:33 [PATCH RESEND 0/2] Misc OMAP GPIO/UART fixes Judith Mendez
2024-10-11 17:33 ` [PATCH RESEND 1/2] gpio: omap: Add omap_gpio_disable/enable_irq calls Judith Mendez
2024-10-11 19:07 ` Andrew Davis
2024-10-17 18:38 ` Judith Mendez
2024-10-11 17:33 ` [PATCH RESEND 2/2] serial: 8250: omap: Move pm_runtime_get_sync Judith Mendez
2024-10-12 0:19 ` Kevin Hilman
2024-10-12 8:03 ` Greg KH [this message]
2024-10-17 18:47 ` Judith Mendez
2024-10-12 12:27 ` Andreas Kemnade
[not found] ` <4297747A-8AB9-4E50-93FF-723672B6471C@gmail.com>
2024-10-14 15:22 ` Andreas Kemnade
2024-10-11 22:52 ` [PATCH RESEND 0/2] Misc OMAP GPIO/UART fixes Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024101218-overpay-yoga-7423@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=b-liu@ti.com \
--cc=brgl@bgdev.pl \
--cc=jm@ti.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox