From: David Hunter <david.hunter.linux@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: David Hunter <david.hunter.linux@gmail.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
shuah@kernel.org, javier.carrasco.cruz@gmail.com,
Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH v2 3/7] streamline_config.pl: remove prompt warnings for configs with defaults
Date: Mon, 14 Oct 2024 10:13:33 -0400 [thread overview]
Message-ID: <20241014141345.5680-4-david.hunter.linux@gmail.com> (raw)
In-Reply-To: <20241014141345.5680-1-david.hunter.linux@gmail.com>
Ignore process select warnings for config entries that have a default
option. Some config entries have no prompt, and nothing selects them, but
these config options are okay because they have a default option.
Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
---
V1 https://lore.kernel.org/all/20240913171205.22126-7-david.hunter.linux@gmail.com/
V2
- changed subject
- put a space between "if" and "("
---
scripts/kconfig/streamline_config.pl | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/scripts/kconfig/streamline_config.pl b/scripts/kconfig/streamline_config.pl
index 85f4712e2bf3..8e23faab5d22 100755
--- a/scripts/kconfig/streamline_config.pl
+++ b/scripts/kconfig/streamline_config.pl
@@ -144,6 +144,7 @@ my %selects;
my %prompts;
my %objects;
my %config2kfile;
+my %defaults;
my $var;
my $iflevel = 0;
my @ifdeps;
@@ -222,6 +223,7 @@ sub read_kconfig {
$depends{$config} .= " " . $1;
} elsif ($state ne "NONE" && /^\s*def(_(bool|tristate)|ault)\s+(\S.*)$/) {
my $dep = $3;
+ $defaults{$config} = 1;
if ($dep !~ /^\s*(y|m|n)\s*$/) {
$dep =~ s/.*\sif\s+//;
$depends{$config} .= " " . $dep;
@@ -523,8 +525,16 @@ sub parse_config_selects
# If no possible config selected this, then something happened.
if (!defined($next_config)) {
- print STDERR "WARNING: $config is required, but nothing in the\n";
- print STDERR " current config selects it.\n";
+
+ # Some config options have no prompt, and nothing selects them, but
+ # they stay turned on once the final checks for the configs
+ # are done. These configs have a default option, so turn off the
+ # warnings for configs with default options.
+ if (!defined($defaults{$config})) {
+ print STDERR "WARNING: $config is required, but nothing in the\n";
+ print STDERR " current config selects it.\n";
+ }
+
return;
}
--
2.43.0
next prev parent reply other threads:[~2024-10-14 14:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 14:13 [PATCH v3 0/7] streamline_config.pl: fix: process configs set to "y" David Hunter
2024-10-14 14:13 ` [PATCH v2 1/7] streamline_config.pl: fix missing variable operator in debug print David Hunter
2024-11-05 23:05 ` Masahiro Yamada
2024-10-14 14:13 ` [PATCH v2 2/7] streamline_config.pl: ensure all defaults are tracked David Hunter
2024-10-15 23:09 ` Steven Rostedt
2024-11-05 23:05 ` Masahiro Yamada
2024-11-26 23:48 ` David Hunter
2024-11-27 1:09 ` Steven Rostedt
2024-11-05 23:05 ` Masahiro Yamada
2024-10-14 14:13 ` David Hunter [this message]
2024-11-05 23:13 ` [PATCH v2 3/7] streamline_config.pl: remove prompt warnings for configs with defaults Masahiro Yamada
2024-10-14 14:13 ` [PATCH v1 4/7] streamline_config.pl: include tool to learn about a config option David Hunter
2024-11-05 23:15 ` Masahiro Yamada
2024-10-14 14:13 ` [PATCH v2 5/7] streamline_config.pl: fix: implement choice for kconfigs David Hunter
2024-10-17 22:32 ` Steven Rostedt
2024-11-05 23:33 ` Masahiro Yamada
2024-11-27 13:18 ` David Hunter
2024-11-30 9:41 ` Masahiro Yamada
2024-10-14 14:13 ` [PATCH v2 6/7] streamline_config.pl: process config options set to "y" David Hunter
2024-10-15 23:20 ` Steven Rostedt
2024-11-05 23:44 ` Masahiro Yamada
2024-10-14 14:13 ` [PATCH v2 7/7] streamline_config.pl: check prompt for bool options David Hunter
2024-11-05 23:45 ` Masahiro Yamada
2024-11-27 13:26 ` David Hunter
2024-11-27 22:50 ` Masahiro Yamada
2024-11-28 15:04 ` David Hunter
2024-10-17 22:37 ` [PATCH v3 0/7] streamline_config.pl: fix: process configs set to "y" Steven Rostedt
2024-10-18 14:30 ` Steven Rostedt
2024-11-27 23:05 ` David Hunter
2024-11-27 23:26 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241014141345.5680-4-david.hunter.linux@gmail.com \
--to=david.hunter.linux@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox