Re: [PATCH v13 09/18] cxl/mbox: Add SET_FEATURE mailbox command

Jonathan Cameron
2024-10-14T15:12:25Z

On Wed, 9 Oct 2024 13:41:10 +0100
<shiju.jose@huawei.com> wrote:

> From: Shiju Jose <shiju.jose@huawei.com>
>
> Add support for SET_FEATURE mailbox command.
>
> CXL spec 3.1 section 8.2.9.6 describes optional device specific features.
> CXL devices support features with changeable attributes.
> The settings of a feature can be optionally modified using Set Feature
> command.
> CXL spec 3.1 section 8.2.9.6.3 describes Set Feature command.
>
> Signed-off-by: Shiju Jose <shiju.jose@huawei.com>

LGTM
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

CXL reviewers. I'd like at least one more review of this one
simply because it's a core code.

Fan, you looked at v12 and pointed out a typo only. Could you
take another quick look?

Thanks,

Jonathan