Re: [PATCH v5 12/22] media: rzg2l-cru: Inline calculating image size

Laurent Pinchart
2024-10-15T10:22:49Z

Hi Prabhakar,

Thank you for the patch.

On Fri, Oct 11, 2024 at 06:30:42PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> The `rzg2l_cru_format_sizeimage()` function has been inlined into the
> `rzg2l_cru_format_align()` function as it has a single caller.

The commit message should use the imperative mood:

Inline the `rzg2l_cru_format_sizeimage()` function into its single
caller as the function is trivial and is not expected to be called
anywhere else.

>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

> ---
> drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> index 37fea2bed00f..6a4f0455dc9c 100644
> --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c
> @@ -839,11 +839,6 @@ static u32 rzg2l_cru_format_bytesperline(struct v4l2_pix_format *pix)
> return pix->width * fmt->bpp[0];
> }
>
> -static u32 rzg2l_cru_format_sizeimage(struct v4l2_pix_format *pix)
> -{
> - return pix->bytesperline * pix->height;
> -}
> -
> static void rzg2l_cru_format_align(struct rzg2l_cru_dev *cru,
> struct v4l2_pix_format *pix)
> {
> @@ -868,7 +863,7 @@ static void rzg2l_cru_format_align(struct rzg2l_cru_dev *cru,
> &pix->height, 240, RZG2L_CRU_MAX_INPUT_HEIGHT, 2, 0);
>
> pix->bytesperline = rzg2l_cru_format_bytesperline(pix);
> - pix->sizeimage = rzg2l_cru_format_sizeimage(pix);
> + pix->sizeimage = pix->bytesperline * pix->height;
>
> dev_dbg(cru->dev, "Format %ux%u bpl: %u size: %u\n",
> pix->width, pix->height, pix->bytesperline, pix->sizeimage);

--
Regards,

Laurent Pinchart