Re: [PATCH v3 1/2] irqchip: Kconfig: module build support for the TI interrupt router driver

Guillaume LA ROQUE
2024-10-16T18:32:17Z

Hi ,

Le 16/10/2024 à 18:38, Thomas Gleixner a écrit :
> On Wed, Oct 16 2024 at 11:41, Guillaume La Roque wrote:
>> From: Nicolas Frayer <nfrayer@baylibre.com>
> irqchip: Kconfig: is not a valid prefix.
>
> This is about the TI SCI router, so this wants to use the
> irqchip/ti-whatever prefix.
>
>> Added module build support in Kconfig for the TI SCI interrupt router
>> driver
> Added?
>
> This wants to be 'Add ...'
>
> You fail to explain why it is valid to build this as a module, i.e. you
> did the analysis that there is no dependency on this before modules can
> be loaded.

i will rewrite commit message and title .

>
>> MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@ticom>");
>> MODULE_DESCRIPTION("K3 Interrupt Router driver over TI SCI protocol");
>> +MODULE_LICENSE("GPL");
> This change is not mentioned in the change log.

it's mandatory for have possiblity to build in module so for me no
really needed to explain this but i will add why in commit message.

thanks for review.

Guillaume

>
> Thanks,
>
> tglx