Re: [PATCH v3 1/2] irqchip: Kconfig: module build support for the TI interrupt router driver

Andrew Davis
2024-10-16T13:37:53Z

On 10/16/24 4:41 AM, Guillaume La Roque wrote:
> From: Nicolas Frayer <nfrayer@baylibre.com>
>
> Added module build support in Kconfig for the TI SCI interrupt router
> driver
>
> Signed-off-by: Nicolas Frayer <nfrayer@baylibre.com>
> Signed-off-by: Guillaume La Roque <glaroque@baylibre.com>
> ---
> arch/arm64/Kconfig.platforms | 1 -
> drivers/irqchip/Kconfig | 3 ++-
> drivers/irqchip/irq-ti-sci-intr.c | 1 +
> 3 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 6c6d11536b42..393845a3ae5c 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -135,7 +135,6 @@ config ARCH_K3
> select SOC_TI
> select TI_MESSAGE_MANAGER
> select TI_SCI_PROTOCOL
> - select TI_SCI_INTR_IRQCHIP
> select TI_SCI_INTA_IRQCHIP
> select TI_K3_SOCINFO
> help
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 341cd9ca5a05..a958731404e9 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -533,9 +533,10 @@ config LS1X_IRQ
> Support for the Loongson-1 platform Interrupt Controller.
>
> config TI_SCI_INTR_IRQCHIP
> - bool
> + tristate "TI SCI INTR Interrupt Controller"

Although not needed, might be good to gate this on ARCH_K3
as it only makes sense to add when K3 is an enabled platform.
Then add on compile test support:

depends on ARCH_K3 || COMPILE_TEST

Andrew

> depends on TI_SCI_PROTOCOL
> select IRQ_DOMAIN_HIERARCHY
> + default ARCH_K3
> help
> This enables the irqchip driver support for K3 Interrupt router
> over TI System Control Interface available on some new TI's SoCs.
> diff --git a/drivers/irqchip/irq-ti-sci-intr.c b/drivers/irqchip/irq-ti-sci-intr.c
> index c027cd9e4a69..b49a73106c69 100644
> --- a/drivers/irqchip/irq-ti-sci-intr.c
> +++ b/drivers/irqchip/irq-ti-sci-intr.c
> @@ -303,3 +303,4 @@ module_platform_driver(ti_sci_intr_irq_domain_driver);
>
> MODULE_AUTHOR("Lokesh Vutla <lokeshvutla@ticom>");
> MODULE_DESCRIPTION("K3 Interrupt Router driver over TI SCI protocol");
> +MODULE_LICENSE("GPL");
>