From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 332411F585F for ; Tue, 15 Oct 2024 20:36:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729024613; cv=none; b=hqrVXk5ggYXP/EBvPiOmlUx02RkjSRbQI/SqE8yzfjjZPCrjV43iAi45lIbDfbX1SG1n6lOqcVcOPGZFYbMV8EstnwUTAGgv/KfY2KQcNnI0raaxUi321jZiK8XTtQ6x88Xw2utkGOpJL9CTzJS329/p180EqE98PGKkoLRjgXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729024613; c=relaxed/simple; bh=PxNg9e//Uj2iB519PkjX8NJ6AZJiVEkwP1CoX8ZQqNM=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=GvLbUCS6a1nz1473hlRdpVB7hUUEnQSiaWpGXirkiAAQ0AfeHgSK+bI/tr6RaP1ed7hDUx7Y/WkcYWIMZE9OjAX7BzSMgHlU9O0d7HTGhhbEpR5nlYXSBeMqq5KD5RdpfZVU+Q0iRnb3quV83FoPiuGx+vfR0AlYGWEsFR8VEHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Wj1721uM; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Wj1721uM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729024611; x=1760560611; h=date:from:to:cc:subject:message-id:mime-version; bh=PxNg9e//Uj2iB519PkjX8NJ6AZJiVEkwP1CoX8ZQqNM=; b=Wj1721uM/8VIjddhJfaGfjwf56qF58DK+ipnCYoxigZ1mLlWwravEGai OcrGfLI78Q9kIUUcKeDhdEnKFfE15jDycKJ/uRYvOsVu+r5FaItFmyQ2I CxfLto6GlpPytzu7/f4kauQUvbjsc/ldEw86pPrTmRECxTxpVbGMDjJAe JwcdQBZiJkNrsSRgfJsfdzzM+hEO60UlecI1/lI/sAyWlB2aA53UxIY81 Zv2BlFjAyU/tAm3qHh37uKe8HlzlnLkORAtALmMDwRNIaxa19mB183dJp jc02VExEXPl++W3GX0wJajYp/AnrP59fBjyggcwvi9lCg+g9TDkYyaLia Q==; X-CSE-ConnectionGUID: kiiu6v5WRh+RpVKwk3ka4A== X-CSE-MsgGUID: N7UGtr+wSEKVujFLgz07bQ== X-IronPort-AV: E=McAfee;i="6700,10204,11225"; a="53855824" X-IronPort-AV: E=Sophos;i="6.11,206,1725346800"; d="scan'208";a="53855824" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2024 13:36:50 -0700 X-CSE-ConnectionGUID: xry8Cxc7S7S8A193Ie8MqA== X-CSE-MsgGUID: etcp92BbRfKAOrDK2AWPJA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,206,1725346800"; d="scan'208";a="77634045" Received: from lkp-server01.sh.intel.com (HELO a48cf1aa22e8) ([10.239.97.150]) by fmviesa006.fm.intel.com with ESMTP; 15 Oct 2024 13:36:49 -0700 Received: from kbuild by a48cf1aa22e8 with local (Exim 4.96) (envelope-from ) id 1t0oHf-000Juu-0h; Tue, 15 Oct 2024 20:36:47 +0000 Date: Wed, 16 Oct 2024 04:36:19 +0800 From: kernel test robot To: Hans de Goede Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: drivers/platform/x86/x86-android-tablets/lenovo.c:604:30: sparse: sparse: symbol 'lenovo_yoga_tab2_1380_bq24190_pdata' was not declared. Should it be static? Message-ID: <202410160432.oJAPbrW9-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: eca631b8fe808748d7585059c4307005ca5c5820 commit: 3eee73ad42c3899d97e073bf2c41e7670a3c575c platform/x86: x86-android-tablets: Add Lenovo Yoga Tablet 2 Pro 1380F/L data date: 6 months ago config: x86_64-randconfig-r133-20241015 (https://download.01.org/0day-ci/archive/20241016/202410160432.oJAPbrW9-lkp@intel.com/config) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241016/202410160432.oJAPbrW9-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202410160432.oJAPbrW9-lkp@intel.com/ sparse warnings: (new ones prefixed by >>) >> drivers/platform/x86/x86-android-tablets/lenovo.c:604:30: sparse: sparse: symbol 'lenovo_yoga_tab2_1380_bq24190_pdata' was not declared. Should it be static? >> drivers/platform/x86/x86-android-tablets/lenovo.c:729:12: sparse: sparse: symbol 'lenovo_yoga_tab2_1380_modules' was not declared. Should it be static? drivers/platform/x86/x86-android-tablets/lenovo.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, ...): include/linux/page-flags.h:242:46: sparse: sparse: self-comparison always evaluates to false include/linux/page-flags.h:242:46: sparse: sparse: self-comparison always evaluates to false vim +/lenovo_yoga_tab2_1380_bq24190_pdata +604 drivers/platform/x86/x86-android-tablets/lenovo.c 603 > 604 struct bq24190_platform_data lenovo_yoga_tab2_1380_bq24190_pdata = { 605 .regulator_init_data = &lenovo_yoga_tab2_1380_bq24190_vbus_init_data, 606 }; 607 608 static const struct property_entry lenovo_yoga_tab2_1380_lc824206xa_props[] = { 609 PROPERTY_ENTRY_BOOL("onnn,enable-miclr-for-dcp"), 610 { } 611 }; 612 613 static const struct software_node lenovo_yoga_tab2_1380_lc824206xa_node = { 614 .properties = lenovo_yoga_tab2_1380_lc824206xa_props, 615 }; 616 617 static const char * const lenovo_yoga_tab2_1380_lms303d_mount_matrix[] = { 618 "0", "-1", "0", 619 "-1", "0", "0", 620 "0", "0", "1" 621 }; 622 623 static const struct property_entry lenovo_yoga_tab2_1380_lms303d_props[] = { 624 PROPERTY_ENTRY_STRING_ARRAY("mount-matrix", lenovo_yoga_tab2_1380_lms303d_mount_matrix), 625 { } 626 }; 627 628 static const struct software_node lenovo_yoga_tab2_1380_lms303d_node = { 629 .properties = lenovo_yoga_tab2_1380_lms303d_props, 630 }; 631 632 static const struct x86_i2c_client_info lenovo_yoga_tab2_1380_i2c_clients[] __initconst = { 633 { 634 /* BQ27541 fuel-gauge */ 635 .board_info = { 636 .type = "bq27541", 637 .addr = 0x55, 638 .dev_name = "bq27541", 639 .swnode = &fg_bq24190_supply_node, 640 }, 641 .adapter_path = "\\_SB_.I2C1", 642 }, { 643 /* bq24292i battery charger */ 644 .board_info = { 645 .type = "bq24190", 646 .addr = 0x6b, 647 .dev_name = "bq24292i", 648 .swnode = &lenovo_yoga_tab2_1380_bq24190_node, 649 .platform_data = &lenovo_yoga_tab2_1380_bq24190_pdata, 650 }, 651 .adapter_path = "\\_SB_.I2C1", 652 .irq_data = { 653 .type = X86_ACPI_IRQ_TYPE_GPIOINT, 654 .chip = "INT33FC:02", 655 .index = 2, 656 .trigger = ACPI_EDGE_SENSITIVE, 657 .polarity = ACPI_ACTIVE_HIGH, 658 .con_id = "bq24292i_irq", 659 }, 660 }, { 661 /* LP8557 Backlight controller */ 662 .board_info = { 663 .type = "lp8557", 664 .addr = 0x2c, 665 .dev_name = "lp8557", 666 .platform_data = &lenovo_lp8557_pwm_and_reg_pdata, 667 }, 668 .adapter_path = "\\_SB_.I2C3", 669 }, { 670 /* LC824206XA Micro USB Switch */ 671 .board_info = { 672 .type = "lc824206xa", 673 .addr = 0x48, 674 .dev_name = "lc824206xa", 675 .swnode = &lenovo_yoga_tab2_1380_lc824206xa_node, 676 }, 677 .adapter_path = "\\_SB_.I2C3", 678 .irq_data = { 679 .type = X86_ACPI_IRQ_TYPE_GPIOINT, 680 .chip = "INT33FC:02", 681 .index = 1, 682 .trigger = ACPI_LEVEL_SENSITIVE, 683 .polarity = ACPI_ACTIVE_LOW, 684 .con_id = "lc824206xa_irq", 685 }, 686 }, { 687 /* AL3320A ambient light sensor */ 688 .board_info = { 689 .type = "al3320a", 690 .addr = 0x1c, 691 .dev_name = "al3320a", 692 }, 693 .adapter_path = "\\_SB_.I2C5", 694 }, { 695 /* LSM303DA accelerometer + magnetometer */ 696 .board_info = { 697 .type = "lsm303d", 698 .addr = 0x1d, 699 .dev_name = "lsm303d", 700 .swnode = &lenovo_yoga_tab2_1380_lms303d_node, 701 }, 702 .adapter_path = "\\_SB_.I2C5", 703 }, { 704 /* Synaptics RMI touchscreen */ 705 .board_info = { 706 .type = "rmi4_i2c", 707 .addr = 0x38, 708 .dev_name = "rmi4_i2c", 709 .platform_data = &lenovo_yoga_tab2_830_1050_rmi_pdata, 710 }, 711 .adapter_path = "\\_SB_.I2C6", 712 .irq_data = { 713 .type = X86_ACPI_IRQ_TYPE_APIC, 714 .index = 0x45, 715 .trigger = ACPI_EDGE_SENSITIVE, 716 .polarity = ACPI_ACTIVE_HIGH, 717 }, 718 } 719 }; 720 721 static const struct platform_device_info lenovo_yoga_tab2_1380_pdevs[] __initconst = { 722 { 723 /* For the Tablet 2 Pro 1380's custom fast charging driver */ 724 .name = "lenovo-yoga-tab2-pro-1380-fastcharger", 725 .id = PLATFORM_DEVID_NONE, 726 }, 727 }; 728 > 729 const char * const lenovo_yoga_tab2_1380_modules[] __initconst = { 730 "bq24190_charger", /* For the Vbus regulator for lc824206xa */ 731 NULL 732 }; 733 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki