From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Rongguang Wei <clementwei90@163.com>,
coreteam@netfilter.org, netfilter-devel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Rongguang Wei <weirongguang@kylinos.cn>,
kadlec@netfilter.org
Subject: Re: [netfilter-core] [PATCH v1] netfilter: x_tables: fix ordering of get and update table private
Date: Wed, 16 Oct 2024 18:34:26 +0200 [thread overview]
Message-ID: <20241016163426.GD6576@breakpoint.cc> (raw)
In-Reply-To: <Zw_OXzBgfFULaEzs@calendula>
Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> On Wed, Oct 16, 2024 at 11:09:09AM +0800, Rongguang Wei wrote:
> > From: Rongguang Wei <weirongguang@kylinos.cn>
> >
> > Meet a kernel panic in ipt_do_table:
> > PANIC: "Unable to handle kernel paging request at virtual address 00706f746b736564"
>
> This patch is no correct.
FWIW I do not understand this fix either.
I applied it and at least on x86_64 generated code is identical.
Can you show objdiff on your platform?
Maybe that gives a hint as to what is happening.
prev parent reply other threads:[~2024-10-16 16:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 3:09 [PATCH v1] netfilter: x_tables: fix ordering of get and update table private Rongguang Wei
2024-10-16 14:31 ` Pablo Neira Ayuso
2024-10-16 16:34 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241016163426.GD6576@breakpoint.cc \
--to=fw@strlen.de \
--cc=clementwei90@163.com \
--cc=coreteam@netfilter.org \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=weirongguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox