From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43E3918891F; Wed, 16 Oct 2024 17:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729099342; cv=none; b=TSilbH/ClsUrIckfHl3Hngk7KKp8VvN/rUvfPf6dj1t91/Mm/rnelcM4s0DZ/YJk990bNhvhYhOeiJTKSlRUzQmrK7pxPmeASNbBdpqMajD7yqUBz1J6sSb+/neOk1MsHawLqkGSLPrHU8OgKtF4Bp3fyonHQR4zby0eOmP6AN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729099342; c=relaxed/simple; bh=6gutrC8qGlDmj46iGktrJ4nVuXpp6A65DS7uFgh7qnM=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AITNBSlPVewqX9p3xj1Lmg1awE80mGAXC+ZIM+hVQk7oDvv7v+mpWO+FhWM/FO45cFq1C3d/VP60QZlqVCOC+V4/MDyvFz+JvNTHmoLYOK/CdVDpjZiEWcToLSsdXjz1eXROEeQHcT17UdBicbKks2l7BikcLzkNSj5JdtNI6oM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XTHnb2hHmz6JB2t; Thu, 17 Oct 2024 01:21:39 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 3848C1408F9; Thu, 17 Oct 2024 01:22:17 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 16 Oct 2024 19:22:16 +0200 Date: Wed, 16 Oct 2024 18:22:15 +0100 From: Jonathan Cameron To: Terry Bowman CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH 14/15] cxl/aer/pci: Export pci_aer_unmask_internal_errors() Message-ID: <20241016182215.00006496@Huawei.com> In-Reply-To: <20241008221657.1130181-15-terry.bowman@amd.com> References: <20241008221657.1130181-1-terry.bowman@amd.com> <20241008221657.1130181-15-terry.bowman@amd.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100001.china.huawei.com (7.191.160.183) To frapeml500008.china.huawei.com (7.182.85.71) On Tue, 8 Oct 2024 17:16:56 -0500 Terry Bowman wrote: > The CXL driver needs to enable AER correctable and uncorrectable internal > errors in order to receive notification of protocol > errors. pci_aer_unmask_internal_errors() is currently defined as > 'static' in the AER service driver. > > Update the AER service driver, exporting pci_aer_unmask_internal_errors() > to CXL namespace. > > Signed-off-by: Terry Bowman Reviewed-by: Jonathan Cameron (subject to suggestion we just enable internal errors for all devices and sit back and watch for error reports :))