From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rohit Chavan <roheetchavan@gmail.com>
Cc: Dave Penkler <dpenkler@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: gpib: Replace kmalloc/memset with kzalloc for zero initialization.
Date: Wed, 16 Oct 2024 09:55:21 +0200 [thread overview]
Message-ID: <2024101652-reattach-laborer-129a@gregkh> (raw)
In-Reply-To: <20241014075907.1571439-1-roheetchavan@gmail.com>
On Mon, Oct 14, 2024 at 01:29:07PM +0530, Rohit Chavan wrote:
> This patch updates the GPIB driver code by replacing the use of kmalloc
> followed by memset with kzalloc. This change simplifies the memory
> allocation process by ensuring that the allocated memory is zero-initialized
> in a single call, improving code readability and reducing the potential for
> errors related to uninitialized memory.
>
> Signed-off-by: Rohit Chavan <roheetchavan@gmail.com>
> ---
> drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 3 +--
> drivers/staging/gpib/cb7210/cb7210.c | 3 +--
> drivers/staging/gpib/gpio/gpib_bitbang.c | 3 +--
> drivers/staging/gpib/hp_82335/hp82335.c | 3 +--
> drivers/staging/gpib/hp_82341/hp_82341.c | 3 +--
> drivers/staging/gpib/ines/ines_gpib.c | 3 +--
> drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 3 +--
> 7 files changed, 7 insertions(+), 14 deletions(-)
You sent 2 patches that do almost the same thing, and have almost the
same subject line, shouldn't they just be merged into 1 patch? Please
do so and resend it as a v2.
thanks,
greg k-h
prev parent reply other threads:[~2024-10-16 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 7:59 [PATCH] staging: gpib: Replace kmalloc/memset with kzalloc for zero initialization Rohit Chavan
2024-10-16 7:55 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024101652-reattach-laborer-129a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dpenkler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=roheetchavan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox