From: Boris Brezillon <boris.brezillon@collabora.com>
To: "Adrián Larumbe" <adrian.larumbe@collabora.com>
Cc: Rob Herring <robh@kernel.org>,
Steven Price <steven.price@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Philipp Zabel <p.zabel@pengutronix.de>,
kernel@collabora.com, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] drm/panfrost: Replace DRM driver allocation method with newer one
Date: Thu, 17 Oct 2024 14:44:38 +0200 [thread overview]
Message-ID: <20241017144438.257aaa76@collabora.com> (raw)
In-Reply-To: <20241014233758.994861-1-adrian.larumbe@collabora.com>
On Tue, 15 Oct 2024 00:31:36 +0100
Adrián Larumbe <adrian.larumbe@collabora.com> wrote:
> Drop the deprecated DRM driver allocation method in favour of
> devm_drm_dev_alloc(). Overall just make it the same as in Panthor.
> Also discard now superfluous generic and platform device pointers inside
> the main panfrost device structure.
>
> Some ancient checkpatch issues unearthed as a result of these changes
> were also fixed, like lines too long or double assignment in one line.
>
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
Acked-by: Boris Brezillon <boris.brezillon@collabora.com>
I didn't do a thorough review of the diff, but I'm assuming it's
correct if the driver compiles.
BTW, I don't see it done in this series, but it might be good to also
turn devm_ calls into drmm_ ones, and dev_<loglevel> into
drm_<loglevel>.
next prev parent reply other threads:[~2024-10-17 12:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 23:31 [PATCH 1/9] drm/panfrost: Replace DRM driver allocation method with newer one Adrián Larumbe
2024-10-14 23:31 ` [PATCH 2/9] drm/panfrost: handle inexistent GPU during probe Adrián Larumbe
2024-10-21 14:06 ` Boris Brezillon
2024-10-24 14:55 ` Steven Price
2024-10-14 23:31 ` [PATCH 3/9] drm/panfrost: handle error when allocating AS number Adrián Larumbe
2024-10-21 14:07 ` Boris Brezillon
2024-10-14 23:31 ` [PATCH 4/9] drm/panfrost: handle job hw submit errors Adrián Larumbe
2024-10-21 14:14 ` Boris Brezillon
2024-10-14 23:31 ` [PATCH 5/9] drm/panfrost: Handle page mapping failure Adrián Larumbe
2024-10-21 14:32 ` Boris Brezillon
2024-10-14 23:31 ` [PATCH 6/9] drm/panfrost: Avoid re-enabling job interrupts in the reset path Adrián Larumbe
2024-10-21 14:52 ` Boris Brezillon
2024-10-14 23:31 ` [PATCH 7/9] drm/panfrost: Refactor job IRQ enabling sequence Adrián Larumbe
2024-10-14 23:31 ` [PATCH 8/9] drm/panfrost: Add forward declaration and types header Adrián Larumbe
2024-10-14 23:31 ` [PATCH 9/9] drm/panfrost: Explicitly clean up panfrost fence Adrián Larumbe
2024-10-16 13:12 ` Christian König
2024-10-16 16:43 ` Adrián Larumbe
2024-10-17 9:27 ` Christian König
2024-10-17 12:44 ` Boris Brezillon [this message]
2024-10-24 14:55 ` [PATCH 1/9] drm/panfrost: Replace DRM driver allocation method with newer one Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017144438.257aaa76@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=adrian.larumbe@collabora.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox