* [RESEND PATCH] f2fs: Use struct_size() to improve f2fs_acl_clone()
@ 2024-10-07 11:46 Thorsten Blum
2024-10-08 8:51 ` Chao Yu
0 siblings, 1 reply; 4+ messages in thread
From: Thorsten Blum @ 2024-10-07 11:46 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu; +Cc: Thorsten Blum, linux-f2fs-devel, linux-kernel
Use struct_size() to calculate the number of bytes to allocate for a
cloned acl.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/f2fs/acl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c
index 8bffdeccdbc3..1fbc0607363b 100644
--- a/fs/f2fs/acl.c
+++ b/fs/f2fs/acl.c
@@ -296,9 +296,8 @@ static struct posix_acl *f2fs_acl_clone(const struct posix_acl *acl,
struct posix_acl *clone = NULL;
if (acl) {
- int size = sizeof(struct posix_acl) + acl->a_count *
- sizeof(struct posix_acl_entry);
- clone = kmemdup(acl, size, flags);
+ clone = kmemdup(acl, struct_size(acl, a_entries, acl->a_count),
+ flags);
if (clone)
refcount_set(&clone->a_refcount, 1);
}
--
2.46.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH] f2fs: Use struct_size() to improve f2fs_acl_clone()
2024-10-07 11:46 Thorsten Blum
@ 2024-10-08 8:51 ` Chao Yu
0 siblings, 0 replies; 4+ messages in thread
From: Chao Yu @ 2024-10-08 8:51 UTC (permalink / raw)
To: Thorsten Blum, Jaegeuk Kim; +Cc: Chao Yu, linux-f2fs-devel, linux-kernel
On 2024/10/7 19:46, Thorsten Blum wrote:
> Use struct_size() to calculate the number of bytes to allocate for a
> cloned acl.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RESEND PATCH] f2fs: Use struct_size() to improve f2fs_acl_clone()
@ 2024-10-17 22:05 Thorsten Blum
0 siblings, 0 replies; 4+ messages in thread
From: Thorsten Blum @ 2024-10-17 22:05 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu; +Cc: Thorsten Blum, linux-f2fs-devel, linux-kernel
Use struct_size() to calculate the number of bytes to allocate for a
cloned acl.
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/f2fs/acl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c
index 8bffdeccdbc3..1fbc0607363b 100644
--- a/fs/f2fs/acl.c
+++ b/fs/f2fs/acl.c
@@ -296,9 +296,8 @@ static struct posix_acl *f2fs_acl_clone(const struct posix_acl *acl,
struct posix_acl *clone = NULL;
if (acl) {
- int size = sizeof(struct posix_acl) + acl->a_count *
- sizeof(struct posix_acl_entry);
- clone = kmemdup(acl, size, flags);
+ clone = kmemdup(acl, struct_size(acl, a_entries, acl->a_count),
+ flags);
if (clone)
refcount_set(&clone->a_refcount, 1);
}
--
2.47.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RESEND PATCH] f2fs: Use struct_size() to improve f2fs_acl_clone()
@ 2024-10-28 11:20 Thorsten Blum
0 siblings, 0 replies; 4+ messages in thread
From: Thorsten Blum @ 2024-10-28 11:20 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu; +Cc: Thorsten Blum, linux-f2fs-devel, linux-kernel
Use struct_size() to calculate the number of bytes to allocate for a
cloned acl.
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/f2fs/acl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c
index 8bffdeccdbc3..1fbc0607363b 100644
--- a/fs/f2fs/acl.c
+++ b/fs/f2fs/acl.c
@@ -296,9 +296,8 @@ static struct posix_acl *f2fs_acl_clone(const struct posix_acl *acl,
struct posix_acl *clone = NULL;
if (acl) {
- int size = sizeof(struct posix_acl) + acl->a_count *
- sizeof(struct posix_acl_entry);
- clone = kmemdup(acl, size, flags);
+ clone = kmemdup(acl, struct_size(acl, a_entries, acl->a_count),
+ flags);
if (clone)
refcount_set(&clone->a_refcount, 1);
}
--
2.47.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-28 11:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-17 22:05 [RESEND PATCH] f2fs: Use struct_size() to improve f2fs_acl_clone() Thorsten Blum
-- strict thread matches above, loose matches on Subject: below --
2024-10-28 11:20 Thorsten Blum
2024-10-07 11:46 Thorsten Blum
2024-10-08 8:51 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox