[PATCH 0/3] drm: Fix some memory leaks

[PATCH 0/3] drm: Fix some memory leaks

[Jinjie Ruan]

Fix some memory leaks in drm.

Jinjie Ruan (3):
  drm/connector: hdmi: Fix memory leak in
    drm_display_mode_from_cea_vic()
  drm/ttm/tests: Fix memory leak in ttm_tt_simple_create()
  drm/tests: hdmi: Fix memory leaks in drm_display_mode_from_cea_vic()

 drivers/gpu/drm/tests/drm_connector_test.c    | 24 +++++++++++++++++++
 .../drm/tests/drm_hdmi_state_helper_test.c    |  8 +++++++
 drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c |  1 +
 3 files changed, 33 insertions(+)

-- 
2.34.1

[PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()

[Jinjie Ruan]

modprobe drm_connector_test and then rmmod drm_connector_test,
the following memory leak occurs.

The `mode` allocated in drm_mode_duplicate() called by
drm_display_mode_from_cea_vic() is not freed, which cause the memory leak:

	unreferenced object 0xffffff80cb0ee400 (size 128):
	  comm "kunit_try_catch", pid 1948, jiffies 4294950339
	  hex dump (first 32 bytes):
	    14 44 02 00 80 07 d8 07 04 08 98 08 00 00 38 04  .D............8.
	    3c 04 41 04 65 04 00 00 05 00 00 00 00 00 00 00  <.A.e...........
	  backtrace (crc 90e9585c):
	    [<00000000ec42e3d7>] kmemleak_alloc+0x34/0x40
	    [<00000000d0ef055a>] __kmalloc_cache_noprof+0x26c/0x2f4
	    [<00000000c2062161>] drm_mode_duplicate+0x44/0x19c
	    [<00000000f96c74aa>] drm_display_mode_from_cea_vic+0x88/0x98
	    [<00000000d8f2c8b4>] 0xffffffdc982a4868
	    [<000000005d164dbc>] kunit_try_run_case+0x13c/0x3ac
	    [<000000006fb23398>] kunit_generic_run_threadfn_adapter+0x80/0xec
	    [<000000006ea56ca0>] kthread+0x2e8/0x374
	    [<000000000676063f>] ret_from_fork+0x10/0x20
	......

Free `mode` by calling drm_mode_destroy() to fix it.

Cc: stable@vger.kernel.org
Fixes: abb6f74973e2 ("drm/tests: Add HDMI TDMS character rate tests")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
 drivers/gpu/drm/tests/drm_connector_test.c | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/drivers/gpu/drm/tests/drm_connector_test.c b/drivers/gpu/drm/tests/drm_connector_test.c
index 15e36a8db685..9c94d26b3486 100644
--- a/drivers/gpu/drm/tests/drm_connector_test.c
+++ b/drivers/gpu/drm/tests/drm_connector_test.c
@@ -1004,6 +1004,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb(struct kunit *test)
 	rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB);
 	KUNIT_ASSERT_GT(test, rate, 0);
 	KUNIT_EXPECT_EQ(test, mode->clock * 1000ULL, rate);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -1025,6 +1027,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc(struct kunit *test)
 	rate = drm_hdmi_compute_mode_clock(mode, 10, HDMI_COLORSPACE_RGB);
 	KUNIT_ASSERT_GT(test, rate, 0);
 	KUNIT_EXPECT_EQ(test, mode->clock * 1250, rate);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -1043,6 +1047,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1(struct kunit *t
 
 	rate = drm_hdmi_compute_mode_clock(mode, 10, HDMI_COLORSPACE_RGB);
 	KUNIT_EXPECT_EQ(test, rate, 0);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -1064,6 +1070,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc(struct kunit *test)
 	rate = drm_hdmi_compute_mode_clock(mode, 12, HDMI_COLORSPACE_RGB);
 	KUNIT_ASSERT_GT(test, rate, 0);
 	KUNIT_EXPECT_EQ(test, mode->clock * 1500, rate);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -1082,6 +1090,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1(struct kunit *t
 
 	rate = drm_hdmi_compute_mode_clock(mode, 12, HDMI_COLORSPACE_RGB);
 	KUNIT_EXPECT_EQ(test, rate, 0);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -1103,6 +1113,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb_double(struct kunit *test)
 	rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB);
 	KUNIT_ASSERT_GT(test, rate, 0);
 	KUNIT_EXPECT_EQ(test, (mode->clock * 1000ULL) * 2, rate);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -1126,6 +1138,8 @@ static void drm_test_connector_hdmi_compute_mode_clock_yuv420_valid(struct kunit
 	rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_YUV420);
 	KUNIT_ASSERT_GT(test, rate, 0);
 	KUNIT_EXPECT_EQ(test, (mode->clock * 1000ULL) / 2, rate);
+
+	drm_mode_destroy(drm, mode);
 }
 
 static const unsigned int drm_hdmi_compute_mode_clock_yuv420_vic_valid_tests[] = {
@@ -1164,6 +1178,8 @@ static void drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc(struct kuni
 	KUNIT_ASSERT_GT(test, rate, 0);
 
 	KUNIT_EXPECT_EQ(test, mode->clock * 625, rate);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -1189,6 +1205,8 @@ static void drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc(struct kuni
 	KUNIT_ASSERT_GT(test, rate, 0);
 
 	KUNIT_EXPECT_EQ(test, mode->clock * 750, rate);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -1211,6 +1229,8 @@ static void drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc(struct kunit
 	rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_YUV422);
 	KUNIT_ASSERT_GT(test, rate, 0);
 	KUNIT_EXPECT_EQ(test, mode->clock * 1000, rate);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -1233,6 +1253,8 @@ static void drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc(struct kuni
 	rate = drm_hdmi_compute_mode_clock(mode, 10, HDMI_COLORSPACE_YUV422);
 	KUNIT_ASSERT_GT(test, rate, 0);
 	KUNIT_EXPECT_EQ(test, mode->clock * 1000, rate);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -1255,6 +1277,8 @@ static void drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc(struct kuni
 	rate = drm_hdmi_compute_mode_clock(mode, 12, HDMI_COLORSPACE_YUV422);
 	KUNIT_ASSERT_GT(test, rate, 0);
 	KUNIT_EXPECT_EQ(test, mode->clock * 1000, rate);
+
+	drm_mode_destroy(drm, mode);
 }
 
 static struct kunit_case drm_hdmi_compute_mode_clock_tests[] = {
-- 
2.34.1

[PATCH 2/3] drm/ttm/tests: Fix memory leak in ttm_tt_simple_create()

[Jinjie Ruan]

modprobe ttm_device_test and then rmmod ttm_device_test, the fllowing
memory leaks occurs:

The ttm->pages allocated in ttm_tt_init() is not freed after calling
ttm_tt_simple_create(), which cause the memory leak:

	unreferenced object 0xffffff80caf27750 (size 8):
	  comm "kunit_try_catch", pid 2242, jiffies 4295055735
	  hex dump (first 8 bytes):
	    c0 1e 3d c3 fe ff ff ff                          ..=.....
	  backtrace (crc 3d11615a):
	    [<000000007f57312a>] kmemleak_alloc+0x34/0x40
	    [<000000008c6c4c7e>] __kmalloc_node_noprof+0x304/0x3e4
	    [<00000000679c1182>] __kvmalloc_node_noprof+0x1c/0x144
	    [<000000006aed0a3d>] ttm_tt_init+0x138/0x28c [ttm]
	    [<000000005c331998>] drm_gem_shmem_free+0x60/0x534 [drm_shmem_helper]
	    [<0000000022b4f375>] kunit_try_run_case+0x13c/0x3ac
	    [<00000000c525d725>] kunit_generic_run_threadfn_adapter+0x80/0xec
	    [<000000002db94a1f>] kthread+0x2e8/0x374
	    [<000000002c457ad7>] ret_from_fork+0x10/0x20
	......

Fix it by calling ttm_tt_fini() in the exit function.

Cc: stable@vger.kernel.org
Fixes: e6f7c641fae3 ("drm/ttm/tests: Add tests for ttm_tt")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
 drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
index b91c13f46225..9ff216ec58ef 100644
--- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
+++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
@@ -54,6 +54,7 @@ static struct ttm_tt *ttm_tt_simple_create(struct ttm_buffer_object *bo, u32 pag
 
 static void ttm_tt_simple_destroy(struct ttm_device *bdev, struct ttm_tt *ttm)
 {
+	ttm_tt_fini(ttm);
 	kfree(ttm);
 }
 
-- 
2.34.1

[PATCH 3/3] drm/tests: hdmi: Fix memory leaks in drm_display_mode_from_cea_vic()

[Jinjie Ruan]

modprobe drm_hdmi_state_helper_test and then rmmod it, the following
memory leak occurs.

The `mode` allocated in drm_mode_duplicate() called by
drm_display_mode_from_cea_vic() is not freed, which cause the memory leak:

	unreferenced object 0xffffff80ccd18100 (size 128):
	  comm "kunit_try_catch", pid 1851, jiffies 4295059695
	  hex dump (first 32 bytes):
	    57 62 00 00 80 02 90 02 f0 02 20 03 00 00 e0 01  Wb........ .....
	    ea 01 ec 01 0d 02 00 00 0a 00 00 00 00 00 00 00  ................
	  backtrace (crc c2f1aa95):
	    [<000000000f10b11b>] kmemleak_alloc+0x34/0x40
	    [<000000001cd4cf73>] __kmalloc_cache_noprof+0x26c/0x2f4
	    [<00000000f1f3cffa>] drm_mode_duplicate+0x44/0x19c
	    [<000000008cbeef13>] drm_display_mode_from_cea_vic+0x88/0x98
	    [<0000000019daaacf>] 0xffffffedc11ae69c
	    [<000000000aad0f85>] kunit_try_run_case+0x13c/0x3ac
	    [<00000000a9210bac>] kunit_generic_run_threadfn_adapter+0x80/0xec
	    [<000000000a0b2e9e>] kthread+0x2e8/0x374
	    [<00000000bd668858>] ret_from_fork+0x10/0x20
	......

Free `mode` by calling drm_mode_destroy() to fix it.

Cc: stable@vger.kernel.org
Fixes: 4af70f19e559 ("drm/tests: Add RGB Quantization tests")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
 drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
index 34ee95d41f29..70b91e8c8219 100644
--- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
+++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
@@ -466,6 +466,8 @@ static void drm_test_check_broadcast_rgb_auto_cea_mode_vic_1(struct kunit *test)
 	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, conn_state);
 
 	KUNIT_EXPECT_FALSE(test, conn_state->hdmi.is_limited_range);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -582,6 +584,8 @@ static void drm_test_check_broadcast_rgb_full_cea_mode_vic_1(struct kunit *test)
 			DRM_HDMI_BROADCAST_RGB_FULL);
 
 	KUNIT_EXPECT_FALSE(test, conn_state->hdmi.is_limited_range);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -698,6 +702,8 @@ static void drm_test_check_broadcast_rgb_limited_cea_mode_vic_1(struct kunit *te
 			DRM_HDMI_BROADCAST_RGB_LIMITED);
 
 	KUNIT_EXPECT_TRUE(test, conn_state->hdmi.is_limited_range);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
@@ -1286,6 +1292,8 @@ static void drm_test_check_output_bpc_format_vic_1(struct kunit *test)
 
 	KUNIT_EXPECT_EQ(test, conn_state->hdmi.output_bpc, 8);
 	KUNIT_EXPECT_EQ(test, conn_state->hdmi.output_format, HDMI_COLORSPACE_RGB);
+
+	drm_mode_destroy(drm, mode);
 }
 
 /*
-- 
2.34.1

Re: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 2316 bytes --]

On Mon, Oct 14, 2024 at 03:16:30PM GMT, Jinjie Ruan wrote:
> modprobe drm_connector_test and then rmmod drm_connector_test,
> the following memory leak occurs.
> 
> The `mode` allocated in drm_mode_duplicate() called by
> drm_display_mode_from_cea_vic() is not freed, which cause the memory leak:
> 
> 	unreferenced object 0xffffff80cb0ee400 (size 128):
> 	  comm "kunit_try_catch", pid 1948, jiffies 4294950339
> 	  hex dump (first 32 bytes):
> 	    14 44 02 00 80 07 d8 07 04 08 98 08 00 00 38 04  .D............8.
> 	    3c 04 41 04 65 04 00 00 05 00 00 00 00 00 00 00  <.A.e...........
> 	  backtrace (crc 90e9585c):
> 	    [<00000000ec42e3d7>] kmemleak_alloc+0x34/0x40
> 	    [<00000000d0ef055a>] __kmalloc_cache_noprof+0x26c/0x2f4
> 	    [<00000000c2062161>] drm_mode_duplicate+0x44/0x19c
> 	    [<00000000f96c74aa>] drm_display_mode_from_cea_vic+0x88/0x98
> 	    [<00000000d8f2c8b4>] 0xffffffdc982a4868
> 	    [<000000005d164dbc>] kunit_try_run_case+0x13c/0x3ac
> 	    [<000000006fb23398>] kunit_generic_run_threadfn_adapter+0x80/0xec
> 	    [<000000006ea56ca0>] kthread+0x2e8/0x374
> 	    [<000000000676063f>] ret_from_fork+0x10/0x20
> 	......
> 
> Free `mode` by calling drm_mode_destroy() to fix it.
> 
> Cc: stable@vger.kernel.org
> Fixes: abb6f74973e2 ("drm/tests: Add HDMI TDMS character rate tests")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
>  drivers/gpu/drm/tests/drm_connector_test.c | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tests/drm_connector_test.c b/drivers/gpu/drm/tests/drm_connector_test.c
> index 15e36a8db685..9c94d26b3486 100644
> --- a/drivers/gpu/drm/tests/drm_connector_test.c
> +++ b/drivers/gpu/drm/tests/drm_connector_test.c
> @@ -1004,6 +1004,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb(struct kunit *test)
>  	rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB);
>  	KUNIT_ASSERT_GT(test, rate, 0);
>  	KUNIT_EXPECT_EQ(test, mode->clock * 1000ULL, rate);
> +
> +	drm_mode_destroy(drm, mode);
>  }

If KUNIT_ASSERT_GT triggers, then we would end up leaking the mode as well.

I think we should create a kunit_drm_display_mode_from_cea_vic()
function that registers a kunit action to free the mode when the test is
done.

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

Re: [PATCH 3/3] drm/tests: hdmi: Fix memory leaks in drm_display_mode_from_cea_vic()

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 2093 bytes --]

On Mon, Oct 14, 2024 at 03:16:32PM GMT, Jinjie Ruan wrote:
> modprobe drm_hdmi_state_helper_test and then rmmod it, the following
> memory leak occurs.
> 
> The `mode` allocated in drm_mode_duplicate() called by
> drm_display_mode_from_cea_vic() is not freed, which cause the memory leak:
> 
> 	unreferenced object 0xffffff80ccd18100 (size 128):
> 	  comm "kunit_try_catch", pid 1851, jiffies 4295059695
> 	  hex dump (first 32 bytes):
> 	    57 62 00 00 80 02 90 02 f0 02 20 03 00 00 e0 01  Wb........ .....
> 	    ea 01 ec 01 0d 02 00 00 0a 00 00 00 00 00 00 00  ................
> 	  backtrace (crc c2f1aa95):
> 	    [<000000000f10b11b>] kmemleak_alloc+0x34/0x40
> 	    [<000000001cd4cf73>] __kmalloc_cache_noprof+0x26c/0x2f4
> 	    [<00000000f1f3cffa>] drm_mode_duplicate+0x44/0x19c
> 	    [<000000008cbeef13>] drm_display_mode_from_cea_vic+0x88/0x98
> 	    [<0000000019daaacf>] 0xffffffedc11ae69c
> 	    [<000000000aad0f85>] kunit_try_run_case+0x13c/0x3ac
> 	    [<00000000a9210bac>] kunit_generic_run_threadfn_adapter+0x80/0xec
> 	    [<000000000a0b2e9e>] kthread+0x2e8/0x374
> 	    [<00000000bd668858>] ret_from_fork+0x10/0x20
> 	......
> 
> Free `mode` by calling drm_mode_destroy() to fix it.
> 
> Cc: stable@vger.kernel.org
> Fixes: 4af70f19e559 ("drm/tests: Add RGB Quantization tests")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
>  drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
> index 34ee95d41f29..70b91e8c8219 100644
> --- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
> +++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c
> @@ -466,6 +466,8 @@ static void drm_test_check_broadcast_rgb_auto_cea_mode_vic_1(struct kunit *test)
>  	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, conn_state);
>  
>  	KUNIT_EXPECT_FALSE(test, conn_state->hdmi.is_limited_range);
> +
> +	drm_mode_destroy(drm, mode);
>  }

Same comment than on patch 1

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]

Re: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()

[Jinjie Ruan]

On 2024/10/14 17:11, Maxime Ripard wrote:
> On Mon, Oct 14, 2024 at 03:16:30PM GMT, Jinjie Ruan wrote:
>> modprobe drm_connector_test and then rmmod drm_connector_test,
>> the following memory leak occurs.
>>
>> The `mode` allocated in drm_mode_duplicate() called by
>> drm_display_mode_from_cea_vic() is not freed, which cause the memory leak:
>>
>> 	unreferenced object 0xffffff80cb0ee400 (size 128):
>> 	  comm "kunit_try_catch", pid 1948, jiffies 4294950339
>> 	  hex dump (first 32 bytes):
>> 	    14 44 02 00 80 07 d8 07 04 08 98 08 00 00 38 04  .D............8.
>> 	    3c 04 41 04 65 04 00 00 05 00 00 00 00 00 00 00  <.A.e...........
>> 	  backtrace (crc 90e9585c):
>> 	    [<00000000ec42e3d7>] kmemleak_alloc+0x34/0x40
>> 	    [<00000000d0ef055a>] __kmalloc_cache_noprof+0x26c/0x2f4
>> 	    [<00000000c2062161>] drm_mode_duplicate+0x44/0x19c
>> 	    [<00000000f96c74aa>] drm_display_mode_from_cea_vic+0x88/0x98
>> 	    [<00000000d8f2c8b4>] 0xffffffdc982a4868
>> 	    [<000000005d164dbc>] kunit_try_run_case+0x13c/0x3ac
>> 	    [<000000006fb23398>] kunit_generic_run_threadfn_adapter+0x80/0xec
>> 	    [<000000006ea56ca0>] kthread+0x2e8/0x374
>> 	    [<000000000676063f>] ret_from_fork+0x10/0x20
>> 	......
>>
>> Free `mode` by calling drm_mode_destroy() to fix it.
>>
>> Cc: stable@vger.kernel.org
>> Fixes: abb6f74973e2 ("drm/tests: Add HDMI TDMS character rate tests")
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>> ---
>>  drivers/gpu/drm/tests/drm_connector_test.c | 24 ++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/tests/drm_connector_test.c b/drivers/gpu/drm/tests/drm_connector_test.c
>> index 15e36a8db685..9c94d26b3486 100644
>> --- a/drivers/gpu/drm/tests/drm_connector_test.c
>> +++ b/drivers/gpu/drm/tests/drm_connector_test.c
>> @@ -1004,6 +1004,8 @@ static void drm_test_drm_hdmi_compute_mode_clock_rgb(struct kunit *test)
>>  	rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB);
>>  	KUNIT_ASSERT_GT(test, rate, 0);
>>  	KUNIT_EXPECT_EQ(test, mode->clock * 1000ULL, rate);
>> +
>> +	drm_mode_destroy(drm, mode);
>>  }
> 
> If KUNIT_ASSERT_GT triggers, then we would end up leaking the mode as well.
> 
> I think we should create a kunit_drm_display_mode_from_cea_vic()
> function that registers a kunit action to free the mode when the test is
> done.

You are right! That will be nice and could be used by the new KUNIT test
modules.

> 
> Maxime

Re: [PATCH 2/3] drm/ttm/tests: Fix memory leak in ttm_tt_simple_create()

[Nirmoy Das]

On 10/14/2024 9:16 AM, Jinjie Ruan wrote:
> modprobe ttm_device_test and then rmmod ttm_device_test, the fllowing
> memory leaks occurs:
>
> The ttm->pages allocated in ttm_tt_init() is not freed after calling
> ttm_tt_simple_create(), which cause the memory leak:
>
> 	unreferenced object 0xffffff80caf27750 (size 8):
> 	  comm "kunit_try_catch", pid 2242, jiffies 4295055735
> 	  hex dump (first 8 bytes):
> 	    c0 1e 3d c3 fe ff ff ff                          ..=.....
> 	  backtrace (crc 3d11615a):
> 	    [<000000007f57312a>] kmemleak_alloc+0x34/0x40
> 	    [<000000008c6c4c7e>] __kmalloc_node_noprof+0x304/0x3e4
> 	    [<00000000679c1182>] __kvmalloc_node_noprof+0x1c/0x144
> 	    [<000000006aed0a3d>] ttm_tt_init+0x138/0x28c [ttm]
> 	    [<000000005c331998>] drm_gem_shmem_free+0x60/0x534 [drm_shmem_helper]
> 	    [<0000000022b4f375>] kunit_try_run_case+0x13c/0x3ac
> 	    [<00000000c525d725>] kunit_generic_run_threadfn_adapter+0x80/0xec
> 	    [<000000002db94a1f>] kthread+0x2e8/0x374
> 	    [<000000002c457ad7>] ret_from_fork+0x10/0x20
> 	......
>
> Fix it by calling ttm_tt_fini() in the exit function.
>
> Cc: stable@vger.kernel.org
> Fixes: e6f7c641fae3 ("drm/ttm/tests: Add tests for ttm_tt")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
>  drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
> index b91c13f46225..9ff216ec58ef 100644
> --- a/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
> +++ b/drivers/gpu/drm/ttm/tests/ttm_kunit_helpers.c
> @@ -54,6 +54,7 @@ static struct ttm_tt *ttm_tt_simple_create(struct ttm_buffer_object *bo, u32 pag
>  
>  static void ttm_tt_simple_destroy(struct ttm_device *bdev, struct ttm_tt *ttm)
>  {
> +	ttm_tt_fini(ttm);
>  	kfree(ttm);
>  }
>  

Re: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()

[kernel test robot]

Hi Jinjie,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on linus/master v6.12-rc3 next-20241017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jinjie-Ruan/drm-connector-hdmi-Fix-memory-leak-in-drm_display_mode_from_cea_vic/20241014-152022
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20241014071632.989108-2-ruanjinjie%40huawei.com
patch subject: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()
config: arm-randconfig-002-20241017 (https://download.01.org/0day-ci/archive/20241017/202410172046.2W97YGlm-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241017/202410172046.2W97YGlm-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410172046.2W97YGlm-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/tests/drm_connector_test.c:1008:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1031:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1051:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1074:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1094:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1117:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1142:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1182:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1209:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1233:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1257:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   drivers/gpu/drm/tests/drm_connector_test.c:1281:24: error: passing 'const struct drm_display_mode *' to parameter of type 'struct drm_display_mode *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
           drm_mode_destroy(drm, mode);
                                 ^~~~
   include/drm/drm_modes.h:456:72: note: passing argument to parameter 'mode' here
   void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
                                                                          ^
   12 errors generated.


vim +1008 drivers/gpu/drm/tests/drm_connector_test.c

   987	
   988	/*
   989	 * Test that for a given mode, with 8bpc and an RGB output the TMDS
   990	 * character rate is equal to the mode pixel clock.
   991	 */
   992	static void drm_test_drm_hdmi_compute_mode_clock_rgb(struct kunit *test)
   993	{
   994		struct drm_connector_init_priv *priv = test->priv;
   995		const struct drm_display_mode *mode;
   996		unsigned long long rate;
   997		struct drm_device *drm = &priv->drm;
   998	
   999		mode = drm_display_mode_from_cea_vic(drm, 16);
  1000		KUNIT_ASSERT_NOT_NULL(test, mode);
  1001	
  1002		KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK);
  1003	
  1004		rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB);
  1005		KUNIT_ASSERT_GT(test, rate, 0);
  1006		KUNIT_EXPECT_EQ(test, mode->clock * 1000ULL, rate);
  1007	
> 1008		drm_mode_destroy(drm, mode);
  1009	}
  1010	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()

[kernel test robot]

Hi Jinjie,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v6.12-rc3 next-20241017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jinjie-Ruan/drm-connector-hdmi-Fix-memory-leak-in-drm_display_mode_from_cea_vic/20241014-152022
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20241014071632.989108-2-ruanjinjie%40huawei.com
patch subject: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()
config: x86_64-randconfig-121-20241017 (https://download.01.org/0day-ci/archive/20241018/202410180045.uBklh7FI-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241018/202410180045.uBklh7FI-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410180045.uBklh7FI-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/tests/drm_connector_test.c:1008:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1008:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1008:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1031:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1031:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1031:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1051:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1051:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1051:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1074:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1074:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1074:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1094:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1094:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1094:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1117:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1117:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1117:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1142:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1142:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1142:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1182:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1182:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1182:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1209:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1209:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1209:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1233:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1233:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1233:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1257:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1257:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1257:31: sparse:     got struct drm_display_mode const *[assigned] mode
   drivers/gpu/drm/tests/drm_connector_test.c:1281:31: sparse: sparse: incorrect type in argument 2 (different modifiers) @@     expected struct drm_display_mode *mode @@     got struct drm_display_mode const *[assigned] mode @@
   drivers/gpu/drm/tests/drm_connector_test.c:1281:31: sparse:     expected struct drm_display_mode *mode
   drivers/gpu/drm/tests/drm_connector_test.c:1281:31: sparse:     got struct drm_display_mode const *[assigned] mode

vim +1008 drivers/gpu/drm/tests/drm_connector_test.c

   987	
   988	/*
   989	 * Test that for a given mode, with 8bpc and an RGB output the TMDS
   990	 * character rate is equal to the mode pixel clock.
   991	 */
   992	static void drm_test_drm_hdmi_compute_mode_clock_rgb(struct kunit *test)
   993	{
   994		struct drm_connector_init_priv *priv = test->priv;
   995		const struct drm_display_mode *mode;
   996		unsigned long long rate;
   997		struct drm_device *drm = &priv->drm;
   998	
   999		mode = drm_display_mode_from_cea_vic(drm, 16);
  1000		KUNIT_ASSERT_NOT_NULL(test, mode);
  1001	
  1002		KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK);
  1003	
  1004		rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB);
  1005		KUNIT_ASSERT_GT(test, rate, 0);
  1006		KUNIT_EXPECT_EQ(test, mode->clock * 1000ULL, rate);
  1007	
> 1008		drm_mode_destroy(drm, mode);
  1009	}
  1010	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()

[kernel test robot]

Hi Jinjie,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on linus/master v6.12-rc3 next-20241017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jinjie-Ruan/drm-connector-hdmi-Fix-memory-leak-in-drm_display_mode_from_cea_vic/20241014-152022
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20241014071632.989108-2-ruanjinjie%40huawei.com
patch subject: [PATCH 1/3] drm/connector: hdmi: Fix memory leak in drm_display_mode_from_cea_vic()
config: arc-randconfig-002-20241017 (https://download.01.org/0day-ci/archive/20241018/202410180830.oitxTsOv-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241018/202410180830.oitxTsOv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410180830.oitxTsOv-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/tests/drm_connector_test.c: In function 'drm_test_drm_hdmi_compute_mode_clock_rgb':
>> drivers/gpu/drm/tests/drm_connector_test.c:1008:31: warning: passing argument 2 of 'drm_mode_destroy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1008 |         drm_mode_destroy(drm, mode);
         |                               ^~~~
   In file included from drivers/gpu/drm/tests/drm_connector_test.c:13:
   include/drm/drm_modes.h:456:72: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
     456 | void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/tests/drm_connector_test.c: In function 'drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc':
   drivers/gpu/drm/tests/drm_connector_test.c:1031:31: warning: passing argument 2 of 'drm_mode_destroy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1031 |         drm_mode_destroy(drm, mode);
         |                               ^~~~
   include/drm/drm_modes.h:456:72: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
     456 | void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/tests/drm_connector_test.c: In function 'drm_test_drm_hdmi_compute_mode_clock_rgb_10bpc_vic_1':
   drivers/gpu/drm/tests/drm_connector_test.c:1051:31: warning: passing argument 2 of 'drm_mode_destroy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1051 |         drm_mode_destroy(drm, mode);
         |                               ^~~~
   include/drm/drm_modes.h:456:72: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
     456 | void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/tests/drm_connector_test.c: In function 'drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc':
   drivers/gpu/drm/tests/drm_connector_test.c:1074:31: warning: passing argument 2 of 'drm_mode_destroy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1074 |         drm_mode_destroy(drm, mode);
         |                               ^~~~
   include/drm/drm_modes.h:456:72: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
     456 | void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/tests/drm_connector_test.c: In function 'drm_test_drm_hdmi_compute_mode_clock_rgb_12bpc_vic_1':
   drivers/gpu/drm/tests/drm_connector_test.c:1094:31: warning: passing argument 2 of 'drm_mode_destroy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1094 |         drm_mode_destroy(drm, mode);
         |                               ^~~~
   include/drm/drm_modes.h:456:72: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
     456 | void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/tests/drm_connector_test.c: In function 'drm_test_drm_hdmi_compute_mode_clock_rgb_double':
   drivers/gpu/drm/tests/drm_connector_test.c:1117:31: warning: passing argument 2 of 'drm_mode_destroy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1117 |         drm_mode_destroy(drm, mode);
         |                               ^~~~
   include/drm/drm_modes.h:456:72: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
     456 | void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/tests/drm_connector_test.c: In function 'drm_test_connector_hdmi_compute_mode_clock_yuv420_valid':
   drivers/gpu/drm/tests/drm_connector_test.c:1142:31: warning: passing argument 2 of 'drm_mode_destroy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1142 |         drm_mode_destroy(drm, mode);
         |                               ^~~~
   include/drm/drm_modes.h:456:72: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
     456 | void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/tests/drm_connector_test.c: In function 'drm_test_connector_hdmi_compute_mode_clock_yuv420_10_bpc':
   drivers/gpu/drm/tests/drm_connector_test.c:1182:31: warning: passing argument 2 of 'drm_mode_destroy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1182 |         drm_mode_destroy(drm, mode);
         |                               ^~~~
   include/drm/drm_modes.h:456:72: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
     456 | void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/tests/drm_connector_test.c: In function 'drm_test_connector_hdmi_compute_mode_clock_yuv420_12_bpc':
   drivers/gpu/drm/tests/drm_connector_test.c:1209:31: warning: passing argument 2 of 'drm_mode_destroy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1209 |         drm_mode_destroy(drm, mode);
         |                               ^~~~
   include/drm/drm_modes.h:456:72: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
     456 | void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/tests/drm_connector_test.c: In function 'drm_test_connector_hdmi_compute_mode_clock_yuv422_8_bpc':
   drivers/gpu/drm/tests/drm_connector_test.c:1233:31: warning: passing argument 2 of 'drm_mode_destroy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1233 |         drm_mode_destroy(drm, mode);
         |                               ^~~~
   include/drm/drm_modes.h:456:72: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
     456 | void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/tests/drm_connector_test.c: In function 'drm_test_connector_hdmi_compute_mode_clock_yuv422_10_bpc':
   drivers/gpu/drm/tests/drm_connector_test.c:1257:31: warning: passing argument 2 of 'drm_mode_destroy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1257 |         drm_mode_destroy(drm, mode);
         |                               ^~~~
   include/drm/drm_modes.h:456:72: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
     456 | void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
   drivers/gpu/drm/tests/drm_connector_test.c: In function 'drm_test_connector_hdmi_compute_mode_clock_yuv422_12_bpc':
   drivers/gpu/drm/tests/drm_connector_test.c:1281:31: warning: passing argument 2 of 'drm_mode_destroy' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    1281 |         drm_mode_destroy(drm, mode);
         |                               ^~~~
   include/drm/drm_modes.h:456:72: note: expected 'struct drm_display_mode *' but argument is of type 'const struct drm_display_mode *'
     456 | void drm_mode_destroy(struct drm_device *dev, struct drm_display_mode *mode);
         |                                               ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for GET_FREE_REGION
   Depends on [n]: SPARSEMEM [=n]
   Selected by [y]:
   - RESOURCE_KUNIT_TEST [=y] && RUNTIME_TESTING_MENU [=y] && KUNIT [=y]


vim +1008 drivers/gpu/drm/tests/drm_connector_test.c

   987	
   988	/*
   989	 * Test that for a given mode, with 8bpc and an RGB output the TMDS
   990	 * character rate is equal to the mode pixel clock.
   991	 */
   992	static void drm_test_drm_hdmi_compute_mode_clock_rgb(struct kunit *test)
   993	{
   994		struct drm_connector_init_priv *priv = test->priv;
   995		const struct drm_display_mode *mode;
   996		unsigned long long rate;
   997		struct drm_device *drm = &priv->drm;
   998	
   999		mode = drm_display_mode_from_cea_vic(drm, 16);
  1000		KUNIT_ASSERT_NOT_NULL(test, mode);
  1001	
  1002		KUNIT_ASSERT_FALSE(test, mode->flags & DRM_MODE_FLAG_DBLCLK);
  1003	
  1004		rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB);
  1005		KUNIT_ASSERT_GT(test, rate, 0);
  1006		KUNIT_EXPECT_EQ(test, mode->clock * 1000ULL, rate);
  1007	
> 1008		drm_mode_destroy(drm, mode);
  1009	}
  1010	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki