* [PATCH] proc: Fix W=1 build kernel-doc warning
@ 2024-10-18 10:27 Thorsten Blum
2024-10-18 11:03 ` Christian Brauner
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2024-10-18 10:27 UTC (permalink / raw)
To: Christian Brauner, Josef Bacik, Tyler Hicks (Microsoft), Al Viro,
Yan Zhen
Cc: Thorsten Blum, linux-kernel, linux-fsdevel
Building the kernel with W=1 generates the following warning:
fs/proc/fd.c:81: warning: This comment starts with '/**',
but isn't a kernel-doc comment.
Use a normal comment for the helper function proc_fdinfo_permission().
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
fs/proc/fd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/fd.c b/fs/proc/fd.c
index 1f54a54bfb91..5e391cbca7a3 100644
--- a/fs/proc/fd.c
+++ b/fs/proc/fd.c
@@ -77,7 +77,7 @@ static int seq_fdinfo_open(struct inode *inode, struct file *file)
return single_open(file, seq_show, inode);
}
-/**
+/*
* Shared /proc/pid/fdinfo and /proc/pid/fdinfo/fd permission helper to ensure
* that the current task has PTRACE_MODE_READ in addition to the normal
* POSIX-like checks.
--
2.47.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] proc: Fix W=1 build kernel-doc warning
2024-10-18 10:27 [PATCH] proc: Fix W=1 build kernel-doc warning Thorsten Blum
@ 2024-10-18 11:03 ` Christian Brauner
0 siblings, 0 replies; 2+ messages in thread
From: Christian Brauner @ 2024-10-18 11:03 UTC (permalink / raw)
To: Thorsten Blum
Cc: Christian Brauner, linux-kernel, linux-fsdevel, Josef Bacik,
Tyler Hicks (Microsoft), Al Viro, Yan Zhen
On Fri, 18 Oct 2024 12:27:03 +0200, Thorsten Blum wrote:
> Building the kernel with W=1 generates the following warning:
>
> fs/proc/fd.c:81: warning: This comment starts with '/**',
> but isn't a kernel-doc comment.
>
> Use a normal comment for the helper function proc_fdinfo_permission().
>
> [...]
Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.
Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.
It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.
Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes
[1/1] proc: Fix W=1 build kernel-doc warning
https://git.kernel.org/vfs/vfs/c/197231da7f6a
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-18 11:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-18 10:27 [PATCH] proc: Fix W=1 build kernel-doc warning Thorsten Blum
2024-10-18 11:03 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox