public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH -tip] cleanup: Remove address space of returned pointer
Date: Fri, 18 Oct 2024 13:22:59 +0200	[thread overview]
Message-ID: <20241018112259.GD36494@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20240819074124.143565-1-ubizjak@gmail.com>

On Mon, Aug 19, 2024 at 09:41:15AM +0200, Uros Bizjak wrote:
> Guard functions in local_lock.h are defined using DEFINE_GUARD() and
> DEFINE_LOCK_GUARD_1() macros having lock type defined as pointer in
> the percpu address space. The functions, defined by these macros
> return value in generic address space, causing:
> 
> cleanup.h:157:18: error: return from pointer to non-enclosed address space
> 
> and
> 
> cleanup.h:214:18: error: return from pointer to non-enclosed address space
> 
> when strict percpu checks are enabled.
> 
> Add explicit casts to remove address space of the returned pointer.
> 
> Found by GCC's named address space checks.
> 
> Fixes: e4ab322fbaaa ("cleanup: Add conditional guard support")
> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>

Thanks!

Now lives in queue locking/core, and barring robot screams will make its
way into tip.

  reply	other threads:[~2024-10-18 11:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19  7:41 [PATCH -tip] cleanup: Remove address space of returned pointer Uros Bizjak
2024-10-18 11:22 ` Peter Zijlstra [this message]
2024-10-25  7:35   ` Uros Bizjak
2024-10-25  7:49     ` Peter Zijlstra
2024-10-25  8:00       ` Peter Zijlstra
2024-10-26  7:35 ` [tip: locking/core] " tip-bot2 for Uros Bizjak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241018112259.GD36494@noisy.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=ubizjak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox