* arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types)
@ 2024-10-20 9:41 kernel test robot
2024-10-22 17:39 ` Sean Christopherson
0 siblings, 1 reply; 9+ messages in thread
From: kernel test robot @ 2024-10-20 9:41 UTC (permalink / raw)
To: Steven Rostedt; +Cc: oe-kbuild-all, linux-kernel, Paolo Bonzini
Hi Steven,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 715ca9dd687f89ddaac8ec8ccb3b5e5a30311a99
commit: 59cbd4eea48fdbc68fc17a29ad71188fea74b28b KVM: Remove HIGH_RES_TIMERS dependency
date: 6 weeks ago
config: x86_64-randconfig-123-20241020 (https://download.01.org/0day-ci/archive/20241020/202410201716.n8f4T911-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241020/202410201716.n8f4T911-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410201716.n8f4T911-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected int [assigned] ret @@ got restricted vm_fault_t @@
arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: expected int [assigned] ret
arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: got restricted vm_fault_t
>> arch/x86/kernel/cpu/sgx/virt.c:60:20: sparse: sparse: restricted vm_fault_t degrades to integer
>> arch/x86/kernel/cpu/sgx/virt.c:354:36: sparse: sparse: cast removes address space '__user' of expression
arch/x86/kernel/cpu/sgx/virt.c:385:24: sparse: sparse: cast removes address space '__user' of expression
arch/x86/kernel/cpu/sgx/virt.c:385:43: sparse: sparse: cast removes address space '__user' of expression
arch/x86/kernel/cpu/sgx/virt.c:385:58: sparse: sparse: cast removes address space '__user' of expression
arch/x86/kernel/cpu/sgx/virt.c: note: in included file (through include/linux/miscdevice.h):
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
vim +59 arch/x86/kernel/cpu/sgx/virt.c
540745ddbc70ea Sean Christopherson 2021-03-19 32
540745ddbc70ea Sean Christopherson 2021-03-19 33 static int __sgx_vepc_fault(struct sgx_vepc *vepc,
540745ddbc70ea Sean Christopherson 2021-03-19 34 struct vm_area_struct *vma, unsigned long addr)
540745ddbc70ea Sean Christopherson 2021-03-19 35 {
540745ddbc70ea Sean Christopherson 2021-03-19 36 struct sgx_epc_page *epc_page;
540745ddbc70ea Sean Christopherson 2021-03-19 37 unsigned long index, pfn;
540745ddbc70ea Sean Christopherson 2021-03-19 38 int ret;
540745ddbc70ea Sean Christopherson 2021-03-19 39
540745ddbc70ea Sean Christopherson 2021-03-19 40 WARN_ON(!mutex_is_locked(&vepc->lock));
540745ddbc70ea Sean Christopherson 2021-03-19 41
540745ddbc70ea Sean Christopherson 2021-03-19 42 /* Calculate index of EPC page in virtual EPC's page_array */
540745ddbc70ea Sean Christopherson 2021-03-19 43 index = vma->vm_pgoff + PFN_DOWN(addr - vma->vm_start);
540745ddbc70ea Sean Christopherson 2021-03-19 44
540745ddbc70ea Sean Christopherson 2021-03-19 45 epc_page = xa_load(&vepc->page_array, index);
540745ddbc70ea Sean Christopherson 2021-03-19 46 if (epc_page)
540745ddbc70ea Sean Christopherson 2021-03-19 47 return 0;
540745ddbc70ea Sean Christopherson 2021-03-19 48
540745ddbc70ea Sean Christopherson 2021-03-19 49 epc_page = sgx_alloc_epc_page(vepc, false);
540745ddbc70ea Sean Christopherson 2021-03-19 50 if (IS_ERR(epc_page))
540745ddbc70ea Sean Christopherson 2021-03-19 51 return PTR_ERR(epc_page);
540745ddbc70ea Sean Christopherson 2021-03-19 52
540745ddbc70ea Sean Christopherson 2021-03-19 53 ret = xa_err(xa_store(&vepc->page_array, index, epc_page, GFP_KERNEL));
540745ddbc70ea Sean Christopherson 2021-03-19 54 if (ret)
540745ddbc70ea Sean Christopherson 2021-03-19 55 goto err_free;
540745ddbc70ea Sean Christopherson 2021-03-19 56
540745ddbc70ea Sean Christopherson 2021-03-19 57 pfn = PFN_DOWN(sgx_get_epc_phys_addr(epc_page));
540745ddbc70ea Sean Christopherson 2021-03-19 58
540745ddbc70ea Sean Christopherson 2021-03-19 @59 ret = vmf_insert_pfn(vma, addr, pfn);
540745ddbc70ea Sean Christopherson 2021-03-19 @60 if (ret != VM_FAULT_NOPAGE) {
540745ddbc70ea Sean Christopherson 2021-03-19 61 ret = -EFAULT;
540745ddbc70ea Sean Christopherson 2021-03-19 62 goto err_delete;
540745ddbc70ea Sean Christopherson 2021-03-19 63 }
540745ddbc70ea Sean Christopherson 2021-03-19 64
540745ddbc70ea Sean Christopherson 2021-03-19 65 return 0;
540745ddbc70ea Sean Christopherson 2021-03-19 66
540745ddbc70ea Sean Christopherson 2021-03-19 67 err_delete:
540745ddbc70ea Sean Christopherson 2021-03-19 68 xa_erase(&vepc->page_array, index);
540745ddbc70ea Sean Christopherson 2021-03-19 69 err_free:
540745ddbc70ea Sean Christopherson 2021-03-19 70 sgx_free_epc_page(epc_page);
540745ddbc70ea Sean Christopherson 2021-03-19 71 return ret;
540745ddbc70ea Sean Christopherson 2021-03-19 72 }
540745ddbc70ea Sean Christopherson 2021-03-19 73
:::::: The code at line 59 was first introduced by commit
:::::: 540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba x86/sgx: Introduce virtual EPC for use by KVM guests
:::::: TO: Sean Christopherson <sean.j.christopherson@intel.com>
:::::: CC: Borislav Petkov <bp@suse.de>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types)
2024-10-20 9:41 arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types) kernel test robot
@ 2024-10-22 17:39 ` Sean Christopherson
0 siblings, 0 replies; 9+ messages in thread
From: Sean Christopherson @ 2024-10-22 17:39 UTC (permalink / raw)
To: kernel test robot
Cc: Steven Rostedt, oe-kbuild-all, linux-kernel, Paolo Bonzini
On Sun, Oct 20, 2024, kernel test robot wrote:
> Hi Steven,
>
> First bad commit (maybe != root cause):
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 715ca9dd687f89ddaac8ec8ccb3b5e5a30311a99
> commit: 59cbd4eea48fdbc68fc17a29ad71188fea74b28b KVM: Remove HIGH_RES_TIMERS dependency
I highly doubt this changed anything.
> date: 6 weeks ago
> config: x86_64-randconfig-123-20241020 (https://download.01.org/0day-ci/archive/20241020/202410201716.n8f4T911-lkp@intel.com/config)
> compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241020/202410201716.n8f4T911-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202410201716.n8f4T911-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
> >> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected int [assigned] ret @@ got restricted vm_fault_t @@
> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: expected int [assigned] ret
> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: got restricted vm_fault_t
> >> arch/x86/kernel/cpu/sgx/virt.c:60:20: sparse: sparse: restricted vm_fault_t degrades to integer
> >> arch/x86/kernel/cpu/sgx/virt.c:354:36: sparse: sparse: cast removes address space '__user' of expression
> arch/x86/kernel/cpu/sgx/virt.c:385:24: sparse: sparse: cast removes address space '__user' of expression
> arch/x86/kernel/cpu/sgx/virt.c:385:43: sparse: sparse: cast removes address space '__user' of expression
> arch/x86/kernel/cpu/sgx/virt.c:385:58: sparse: sparse: cast removes address space '__user' of expression
These are all easy enough to resolve. If I find myself twiddling my thumbs, I'll
send patches.
> arch/x86/kernel/cpu/sgx/virt.c: note: in included file (through include/linux/miscdevice.h):
> include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
> include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
>
> vim +59 arch/x86/kernel/cpu/sgx/virt.c
>
> 540745ddbc70ea Sean Christopherson 2021-03-19 32
> 540745ddbc70ea Sean Christopherson 2021-03-19 33 static int __sgx_vepc_fault(struct sgx_vepc *vepc,
LOL, I can't outrun my past.
^ permalink raw reply [flat|nested] 9+ messages in thread
* arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types)
@ 2024-11-20 5:59 kernel test robot
2024-11-20 15:05 ` Steven Rostedt
0 siblings, 1 reply; 9+ messages in thread
From: kernel test robot @ 2024-11-20 5:59 UTC (permalink / raw)
To: Steven Rostedt; +Cc: oe-kbuild-all, linux-kernel, Paolo Bonzini
Hi Steven,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: bf9aa14fc523d2763fc9a10672a709224e8fcaf4
commit: 59cbd4eea48fdbc68fc17a29ad71188fea74b28b KVM: Remove HIGH_RES_TIMERS dependency
date: 3 months ago
config: x86_64-randconfig-r133-20241119 (https://download.01.org/0day-ci/archive/20241120/202411201356.pXoYlKFB-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241120/202411201356.pXoYlKFB-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411201356.pXoYlKFB-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected int [assigned] ret @@ got restricted vm_fault_t @@
arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: expected int [assigned] ret
arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: got restricted vm_fault_t
>> arch/x86/kernel/cpu/sgx/virt.c:60:20: sparse: sparse: restricted vm_fault_t degrades to integer
>> arch/x86/kernel/cpu/sgx/virt.c:354:36: sparse: sparse: cast removes address space '__user' of expression
arch/x86/kernel/cpu/sgx/virt.c:385:24: sparse: sparse: cast removes address space '__user' of expression
arch/x86/kernel/cpu/sgx/virt.c:385:43: sparse: sparse: cast removes address space '__user' of expression
arch/x86/kernel/cpu/sgx/virt.c:385:58: sparse: sparse: cast removes address space '__user' of expression
arch/x86/kernel/cpu/sgx/virt.c: note: in included file (through include/linux/miscdevice.h):
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
vim +59 arch/x86/kernel/cpu/sgx/virt.c
540745ddbc70eab Sean Christopherson 2021-03-19 32
540745ddbc70eab Sean Christopherson 2021-03-19 33 static int __sgx_vepc_fault(struct sgx_vepc *vepc,
540745ddbc70eab Sean Christopherson 2021-03-19 34 struct vm_area_struct *vma, unsigned long addr)
540745ddbc70eab Sean Christopherson 2021-03-19 35 {
540745ddbc70eab Sean Christopherson 2021-03-19 36 struct sgx_epc_page *epc_page;
540745ddbc70eab Sean Christopherson 2021-03-19 37 unsigned long index, pfn;
540745ddbc70eab Sean Christopherson 2021-03-19 38 int ret;
540745ddbc70eab Sean Christopherson 2021-03-19 39
540745ddbc70eab Sean Christopherson 2021-03-19 40 WARN_ON(!mutex_is_locked(&vepc->lock));
540745ddbc70eab Sean Christopherson 2021-03-19 41
540745ddbc70eab Sean Christopherson 2021-03-19 42 /* Calculate index of EPC page in virtual EPC's page_array */
540745ddbc70eab Sean Christopherson 2021-03-19 43 index = vma->vm_pgoff + PFN_DOWN(addr - vma->vm_start);
540745ddbc70eab Sean Christopherson 2021-03-19 44
540745ddbc70eab Sean Christopherson 2021-03-19 45 epc_page = xa_load(&vepc->page_array, index);
540745ddbc70eab Sean Christopherson 2021-03-19 46 if (epc_page)
540745ddbc70eab Sean Christopherson 2021-03-19 47 return 0;
540745ddbc70eab Sean Christopherson 2021-03-19 48
540745ddbc70eab Sean Christopherson 2021-03-19 49 epc_page = sgx_alloc_epc_page(vepc, false);
540745ddbc70eab Sean Christopherson 2021-03-19 50 if (IS_ERR(epc_page))
540745ddbc70eab Sean Christopherson 2021-03-19 51 return PTR_ERR(epc_page);
540745ddbc70eab Sean Christopherson 2021-03-19 52
540745ddbc70eab Sean Christopherson 2021-03-19 53 ret = xa_err(xa_store(&vepc->page_array, index, epc_page, GFP_KERNEL));
540745ddbc70eab Sean Christopherson 2021-03-19 54 if (ret)
540745ddbc70eab Sean Christopherson 2021-03-19 55 goto err_free;
540745ddbc70eab Sean Christopherson 2021-03-19 56
540745ddbc70eab Sean Christopherson 2021-03-19 57 pfn = PFN_DOWN(sgx_get_epc_phys_addr(epc_page));
540745ddbc70eab Sean Christopherson 2021-03-19 58
540745ddbc70eab Sean Christopherson 2021-03-19 @59 ret = vmf_insert_pfn(vma, addr, pfn);
540745ddbc70eab Sean Christopherson 2021-03-19 @60 if (ret != VM_FAULT_NOPAGE) {
540745ddbc70eab Sean Christopherson 2021-03-19 61 ret = -EFAULT;
540745ddbc70eab Sean Christopherson 2021-03-19 62 goto err_delete;
540745ddbc70eab Sean Christopherson 2021-03-19 63 }
540745ddbc70eab Sean Christopherson 2021-03-19 64
540745ddbc70eab Sean Christopherson 2021-03-19 65 return 0;
540745ddbc70eab Sean Christopherson 2021-03-19 66
540745ddbc70eab Sean Christopherson 2021-03-19 67 err_delete:
540745ddbc70eab Sean Christopherson 2021-03-19 68 xa_erase(&vepc->page_array, index);
540745ddbc70eab Sean Christopherson 2021-03-19 69 err_free:
540745ddbc70eab Sean Christopherson 2021-03-19 70 sgx_free_epc_page(epc_page);
540745ddbc70eab Sean Christopherson 2021-03-19 71 return ret;
540745ddbc70eab Sean Christopherson 2021-03-19 72 }
540745ddbc70eab Sean Christopherson 2021-03-19 73
:::::: The code at line 59 was first introduced by commit
:::::: 540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba x86/sgx: Introduce virtual EPC for use by KVM guests
:::::: TO: Sean Christopherson <sean.j.christopherson@intel.com>
:::::: CC: Borislav Petkov <bp@suse.de>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types)
2024-11-20 5:59 kernel test robot
@ 2024-11-20 15:05 ` Steven Rostedt
2024-11-21 12:19 ` Philip Li
0 siblings, 1 reply; 9+ messages in thread
From: Steven Rostedt @ 2024-11-20 15:05 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, linux-kernel, Paolo Bonzini
On Wed, 20 Nov 2024 13:59:39 +0800
kernel test robot <lkp@intel.com> wrote:
> Hi Steven,
>
> First bad commit (maybe != root cause):
Does not look to be root cause.
-- Steve
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: bf9aa14fc523d2763fc9a10672a709224e8fcaf4
> commit: 59cbd4eea48fdbc68fc17a29ad71188fea74b28b KVM: Remove HIGH_RES_TIMERS dependency
> date: 3 months ago
> config: x86_64-randconfig-r133-20241119 (https://download.01.org/0day-ci/archive/20241120/202411201356.pXoYlKFB-lkp@intel.com/config)
> compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241120/202411201356.pXoYlKFB-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202411201356.pXoYlKFB-lkp@intel.com/
>
> sparse warnings: (new ones prefixed by >>)
> >> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected int [assigned] ret @@ got restricted vm_fault_t @@
> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: expected int [assigned] ret
> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: got restricted vm_fault_t
> >> arch/x86/kernel/cpu/sgx/virt.c:60:20: sparse: sparse: restricted vm_fault_t degrades to integer
> >> arch/x86/kernel/cpu/sgx/virt.c:354:36: sparse: sparse: cast removes address space '__user' of expression
> arch/x86/kernel/cpu/sgx/virt.c:385:24: sparse: sparse: cast removes address space '__user' of expression
> arch/x86/kernel/cpu/sgx/virt.c:385:43: sparse: sparse: cast removes address space '__user' of expression
> arch/x86/kernel/cpu/sgx/virt.c:385:58: sparse: sparse: cast removes address space '__user' of expression
> arch/x86/kernel/cpu/sgx/virt.c: note: in included file (through include/linux/miscdevice.h):
> include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
> include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
>
> vim +59 arch/x86/kernel/cpu/sgx/virt.c
>
> 540745ddbc70eab Sean Christopherson 2021-03-19 32
> 540745ddbc70eab Sean Christopherson 2021-03-19 33 static int __sgx_vepc_fault(struct sgx_vepc *vepc,
> 540745ddbc70eab Sean Christopherson 2021-03-19 34 struct vm_area_struct *vma, unsigned long addr)
> 540745ddbc70eab Sean Christopherson 2021-03-19 35 {
> 540745ddbc70eab Sean Christopherson 2021-03-19 36 struct sgx_epc_page *epc_page;
> 540745ddbc70eab Sean Christopherson 2021-03-19 37 unsigned long index, pfn;
> 540745ddbc70eab Sean Christopherson 2021-03-19 38 int ret;
> 540745ddbc70eab Sean Christopherson 2021-03-19 39
> 540745ddbc70eab Sean Christopherson 2021-03-19 40 WARN_ON(!mutex_is_locked(&vepc->lock));
> 540745ddbc70eab Sean Christopherson 2021-03-19 41
> 540745ddbc70eab Sean Christopherson 2021-03-19 42 /* Calculate index of EPC page in virtual EPC's page_array */
> 540745ddbc70eab Sean Christopherson 2021-03-19 43 index = vma->vm_pgoff + PFN_DOWN(addr - vma->vm_start);
> 540745ddbc70eab Sean Christopherson 2021-03-19 44
> 540745ddbc70eab Sean Christopherson 2021-03-19 45 epc_page = xa_load(&vepc->page_array, index);
> 540745ddbc70eab Sean Christopherson 2021-03-19 46 if (epc_page)
> 540745ddbc70eab Sean Christopherson 2021-03-19 47 return 0;
> 540745ddbc70eab Sean Christopherson 2021-03-19 48
> 540745ddbc70eab Sean Christopherson 2021-03-19 49 epc_page = sgx_alloc_epc_page(vepc, false);
> 540745ddbc70eab Sean Christopherson 2021-03-19 50 if (IS_ERR(epc_page))
> 540745ddbc70eab Sean Christopherson 2021-03-19 51 return PTR_ERR(epc_page);
> 540745ddbc70eab Sean Christopherson 2021-03-19 52
> 540745ddbc70eab Sean Christopherson 2021-03-19 53 ret = xa_err(xa_store(&vepc->page_array, index, epc_page, GFP_KERNEL));
> 540745ddbc70eab Sean Christopherson 2021-03-19 54 if (ret)
> 540745ddbc70eab Sean Christopherson 2021-03-19 55 goto err_free;
> 540745ddbc70eab Sean Christopherson 2021-03-19 56
> 540745ddbc70eab Sean Christopherson 2021-03-19 57 pfn = PFN_DOWN(sgx_get_epc_phys_addr(epc_page));
> 540745ddbc70eab Sean Christopherson 2021-03-19 58
> 540745ddbc70eab Sean Christopherson 2021-03-19 @59 ret = vmf_insert_pfn(vma, addr, pfn);
> 540745ddbc70eab Sean Christopherson 2021-03-19 @60 if (ret != VM_FAULT_NOPAGE) {
> 540745ddbc70eab Sean Christopherson 2021-03-19 61 ret = -EFAULT;
> 540745ddbc70eab Sean Christopherson 2021-03-19 62 goto err_delete;
> 540745ddbc70eab Sean Christopherson 2021-03-19 63 }
> 540745ddbc70eab Sean Christopherson 2021-03-19 64
> 540745ddbc70eab Sean Christopherson 2021-03-19 65 return 0;
> 540745ddbc70eab Sean Christopherson 2021-03-19 66
> 540745ddbc70eab Sean Christopherson 2021-03-19 67 err_delete:
> 540745ddbc70eab Sean Christopherson 2021-03-19 68 xa_erase(&vepc->page_array, index);
> 540745ddbc70eab Sean Christopherson 2021-03-19 69 err_free:
> 540745ddbc70eab Sean Christopherson 2021-03-19 70 sgx_free_epc_page(epc_page);
> 540745ddbc70eab Sean Christopherson 2021-03-19 71 return ret;
> 540745ddbc70eab Sean Christopherson 2021-03-19 72 }
> 540745ddbc70eab Sean Christopherson 2021-03-19 73
>
> :::::: The code at line 59 was first introduced by commit
> :::::: 540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba x86/sgx: Introduce virtual EPC for use by KVM guests
>
> :::::: TO: Sean Christopherson <sean.j.christopherson@intel.com>
> :::::: CC: Borislav Petkov <bp@suse.de>
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types)
2024-11-20 15:05 ` Steven Rostedt
@ 2024-11-21 12:19 ` Philip Li
0 siblings, 0 replies; 9+ messages in thread
From: Philip Li @ 2024-11-21 12:19 UTC (permalink / raw)
To: Steven Rostedt
Cc: kernel test robot, oe-kbuild-all, linux-kernel, Paolo Bonzini
On Wed, Nov 20, 2024 at 10:05:26AM -0500, Steven Rostedt wrote:
> On Wed, 20 Nov 2024 13:59:39 +0800
> kernel test robot <lkp@intel.com> wrote:
>
> > Hi Steven,
> >
> > First bad commit (maybe != root cause):
>
> Does not look to be root cause.
thanks for info, we will ignore this commit to avoid report this issue
against it.
>
> -- Steve
>
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: bf9aa14fc523d2763fc9a10672a709224e8fcaf4
> > commit: 59cbd4eea48fdbc68fc17a29ad71188fea74b28b KVM: Remove HIGH_RES_TIMERS dependency
> > date: 3 months ago
> > config: x86_64-randconfig-r133-20241119 (https://download.01.org/0day-ci/archive/20241120/202411201356.pXoYlKFB-lkp@intel.com/config)
> > compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241120/202411201356.pXoYlKFB-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202411201356.pXoYlKFB-lkp@intel.com/
> >
> > sparse warnings: (new ones prefixed by >>)
> > >> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected int [assigned] ret @@ got restricted vm_fault_t @@
> > arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: expected int [assigned] ret
> > arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: got restricted vm_fault_t
> > >> arch/x86/kernel/cpu/sgx/virt.c:60:20: sparse: sparse: restricted vm_fault_t degrades to integer
> > >> arch/x86/kernel/cpu/sgx/virt.c:354:36: sparse: sparse: cast removes address space '__user' of expression
> > arch/x86/kernel/cpu/sgx/virt.c:385:24: sparse: sparse: cast removes address space '__user' of expression
> > arch/x86/kernel/cpu/sgx/virt.c:385:43: sparse: sparse: cast removes address space '__user' of expression
> > arch/x86/kernel/cpu/sgx/virt.c:385:58: sparse: sparse: cast removes address space '__user' of expression
> > arch/x86/kernel/cpu/sgx/virt.c: note: in included file (through include/linux/miscdevice.h):
> > include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
> > include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true
> >
> > vim +59 arch/x86/kernel/cpu/sgx/virt.c
> >
> > 540745ddbc70eab Sean Christopherson 2021-03-19 32
> > 540745ddbc70eab Sean Christopherson 2021-03-19 33 static int __sgx_vepc_fault(struct sgx_vepc *vepc,
> > 540745ddbc70eab Sean Christopherson 2021-03-19 34 struct vm_area_struct *vma, unsigned long addr)
> > 540745ddbc70eab Sean Christopherson 2021-03-19 35 {
> > 540745ddbc70eab Sean Christopherson 2021-03-19 36 struct sgx_epc_page *epc_page;
> > 540745ddbc70eab Sean Christopherson 2021-03-19 37 unsigned long index, pfn;
> > 540745ddbc70eab Sean Christopherson 2021-03-19 38 int ret;
> > 540745ddbc70eab Sean Christopherson 2021-03-19 39
> > 540745ddbc70eab Sean Christopherson 2021-03-19 40 WARN_ON(!mutex_is_locked(&vepc->lock));
> > 540745ddbc70eab Sean Christopherson 2021-03-19 41
> > 540745ddbc70eab Sean Christopherson 2021-03-19 42 /* Calculate index of EPC page in virtual EPC's page_array */
> > 540745ddbc70eab Sean Christopherson 2021-03-19 43 index = vma->vm_pgoff + PFN_DOWN(addr - vma->vm_start);
> > 540745ddbc70eab Sean Christopherson 2021-03-19 44
> > 540745ddbc70eab Sean Christopherson 2021-03-19 45 epc_page = xa_load(&vepc->page_array, index);
> > 540745ddbc70eab Sean Christopherson 2021-03-19 46 if (epc_page)
> > 540745ddbc70eab Sean Christopherson 2021-03-19 47 return 0;
> > 540745ddbc70eab Sean Christopherson 2021-03-19 48
> > 540745ddbc70eab Sean Christopherson 2021-03-19 49 epc_page = sgx_alloc_epc_page(vepc, false);
> > 540745ddbc70eab Sean Christopherson 2021-03-19 50 if (IS_ERR(epc_page))
> > 540745ddbc70eab Sean Christopherson 2021-03-19 51 return PTR_ERR(epc_page);
> > 540745ddbc70eab Sean Christopherson 2021-03-19 52
> > 540745ddbc70eab Sean Christopherson 2021-03-19 53 ret = xa_err(xa_store(&vepc->page_array, index, epc_page, GFP_KERNEL));
> > 540745ddbc70eab Sean Christopherson 2021-03-19 54 if (ret)
> > 540745ddbc70eab Sean Christopherson 2021-03-19 55 goto err_free;
> > 540745ddbc70eab Sean Christopherson 2021-03-19 56
> > 540745ddbc70eab Sean Christopherson 2021-03-19 57 pfn = PFN_DOWN(sgx_get_epc_phys_addr(epc_page));
> > 540745ddbc70eab Sean Christopherson 2021-03-19 58
> > 540745ddbc70eab Sean Christopherson 2021-03-19 @59 ret = vmf_insert_pfn(vma, addr, pfn);
> > 540745ddbc70eab Sean Christopherson 2021-03-19 @60 if (ret != VM_FAULT_NOPAGE) {
> > 540745ddbc70eab Sean Christopherson 2021-03-19 61 ret = -EFAULT;
> > 540745ddbc70eab Sean Christopherson 2021-03-19 62 goto err_delete;
> > 540745ddbc70eab Sean Christopherson 2021-03-19 63 }
> > 540745ddbc70eab Sean Christopherson 2021-03-19 64
> > 540745ddbc70eab Sean Christopherson 2021-03-19 65 return 0;
> > 540745ddbc70eab Sean Christopherson 2021-03-19 66
> > 540745ddbc70eab Sean Christopherson 2021-03-19 67 err_delete:
> > 540745ddbc70eab Sean Christopherson 2021-03-19 68 xa_erase(&vepc->page_array, index);
> > 540745ddbc70eab Sean Christopherson 2021-03-19 69 err_free:
> > 540745ddbc70eab Sean Christopherson 2021-03-19 70 sgx_free_epc_page(epc_page);
> > 540745ddbc70eab Sean Christopherson 2021-03-19 71 return ret;
> > 540745ddbc70eab Sean Christopherson 2021-03-19 72 }
> > 540745ddbc70eab Sean Christopherson 2021-03-19 73
> >
> > :::::: The code at line 59 was first introduced by commit
> > :::::: 540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba x86/sgx: Introduce virtual EPC for use by KVM guests
> >
> > :::::: TO: Sean Christopherson <sean.j.christopherson@intel.com>
> > :::::: CC: Borislav Petkov <bp@suse.de>
> >
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types)
@ 2023-08-12 10:57 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2023-08-12 10:57 UTC (permalink / raw)
To: Sean Christopherson
Cc: oe-kbuild-all, linux-kernel, Borislav Petkov, Kai Huang
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: f8de32cc060ba3f63171aaa0e8764d22d8c37978
commit: 540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba x86/sgx: Introduce virtual EPC for use by KVM guests
date: 2 years, 4 months ago
config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20230812/202308121812.AERo19Sw-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230812/202308121812.AERo19Sw-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308121812.AERo19Sw-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected int [assigned] ret @@ got restricted vm_fault_t @@
arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: expected int [assigned] ret
arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: got restricted vm_fault_t
>> arch/x86/kernel/cpu/sgx/virt.c:60:20: sparse: sparse: restricted vm_fault_t degrades to integer
arch/x86/kernel/cpu/sgx/virt.c:95:35: sparse: sparse: symbol 'sgx_vepc_vm_ops' was not declared. Should it be static?
vim +59 arch/x86/kernel/cpu/sgx/virt.c
32
33 static int __sgx_vepc_fault(struct sgx_vepc *vepc,
34 struct vm_area_struct *vma, unsigned long addr)
35 {
36 struct sgx_epc_page *epc_page;
37 unsigned long index, pfn;
38 int ret;
39
40 WARN_ON(!mutex_is_locked(&vepc->lock));
41
42 /* Calculate index of EPC page in virtual EPC's page_array */
43 index = vma->vm_pgoff + PFN_DOWN(addr - vma->vm_start);
44
45 epc_page = xa_load(&vepc->page_array, index);
46 if (epc_page)
47 return 0;
48
49 epc_page = sgx_alloc_epc_page(vepc, false);
50 if (IS_ERR(epc_page))
51 return PTR_ERR(epc_page);
52
53 ret = xa_err(xa_store(&vepc->page_array, index, epc_page, GFP_KERNEL));
54 if (ret)
55 goto err_free;
56
57 pfn = PFN_DOWN(sgx_get_epc_phys_addr(epc_page));
58
> 59 ret = vmf_insert_pfn(vma, addr, pfn);
> 60 if (ret != VM_FAULT_NOPAGE) {
61 ret = -EFAULT;
62 goto err_delete;
63 }
64
65 return 0;
66
67 err_delete:
68 xa_erase(&vepc->page_array, index);
69 err_free:
70 sgx_free_epc_page(epc_page);
71 return ret;
72 }
73
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 9+ messages in thread* arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types)
@ 2022-06-04 7:43 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-06-04 7:43 UTC (permalink / raw)
To: Sean Christopherson; +Cc: kbuild-all, linux-kernel, Borislav Petkov, Kai Huang
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 032dcf09e2bf7c822be25b4abef7a6c913870d98
commit: 540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba x86/sgx: Introduce virtual EPC for use by KVM guests
date: 1 year, 2 months ago
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220604/202206041508.vR5NoxR4-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-1) 11.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-18-g56afb504-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/kernel/cpu/sgx/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected int [assigned] ret @@ got restricted vm_fault_t @@
arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: expected int [assigned] ret
arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: got restricted vm_fault_t
>> arch/x86/kernel/cpu/sgx/virt.c:60:20: sparse: sparse: restricted vm_fault_t degrades to integer
arch/x86/kernel/cpu/sgx/virt.c:95:35: sparse: sparse: symbol 'sgx_vepc_vm_ops' was not declared. Should it be static?
vim +59 arch/x86/kernel/cpu/sgx/virt.c
32
33 static int __sgx_vepc_fault(struct sgx_vepc *vepc,
34 struct vm_area_struct *vma, unsigned long addr)
35 {
36 struct sgx_epc_page *epc_page;
37 unsigned long index, pfn;
38 int ret;
39
40 WARN_ON(!mutex_is_locked(&vepc->lock));
41
42 /* Calculate index of EPC page in virtual EPC's page_array */
43 index = vma->vm_pgoff + PFN_DOWN(addr - vma->vm_start);
44
45 epc_page = xa_load(&vepc->page_array, index);
46 if (epc_page)
47 return 0;
48
49 epc_page = sgx_alloc_epc_page(vepc, false);
50 if (IS_ERR(epc_page))
51 return PTR_ERR(epc_page);
52
53 ret = xa_err(xa_store(&vepc->page_array, index, epc_page, GFP_KERNEL));
54 if (ret)
55 goto err_free;
56
57 pfn = PFN_DOWN(sgx_get_epc_phys_addr(epc_page));
58
> 59 ret = vmf_insert_pfn(vma, addr, pfn);
> 60 if (ret != VM_FAULT_NOPAGE) {
61 ret = -EFAULT;
62 goto err_delete;
63 }
64
65 return 0;
66
67 err_delete:
68 xa_erase(&vepc->page_array, index);
69 err_free:
70 sgx_free_epc_page(epc_page);
71 return ret;
72 }
73
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 9+ messages in thread* arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types)
@ 2022-02-21 21:28 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2022-02-21 21:28 UTC (permalink / raw)
To: Sean Christopherson; +Cc: kbuild-all, linux-kernel, Borislav Petkov, Kai Huang
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 038101e6b2cd5c55f888f85db42ea2ad3aecb4b6
commit: 540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba x86/sgx: Introduce virtual EPC for use by KVM guests
date: 11 months ago
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220222/202202220503.9FyCsWJL-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/hyperv/ arch/x86/kernel/cpu/sgx/ drivers/staging/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected int [assigned] ret @@ got restricted vm_fault_t @@
arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: expected int [assigned] ret
arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: got restricted vm_fault_t
>> arch/x86/kernel/cpu/sgx/virt.c:60:20: sparse: sparse: restricted vm_fault_t degrades to integer
arch/x86/kernel/cpu/sgx/virt.c:95:35: sparse: sparse: symbol 'sgx_vepc_vm_ops' was not declared. Should it be static?
vim +59 arch/x86/kernel/cpu/sgx/virt.c
32
33 static int __sgx_vepc_fault(struct sgx_vepc *vepc,
34 struct vm_area_struct *vma, unsigned long addr)
35 {
36 struct sgx_epc_page *epc_page;
37 unsigned long index, pfn;
38 int ret;
39
40 WARN_ON(!mutex_is_locked(&vepc->lock));
41
42 /* Calculate index of EPC page in virtual EPC's page_array */
43 index = vma->vm_pgoff + PFN_DOWN(addr - vma->vm_start);
44
45 epc_page = xa_load(&vepc->page_array, index);
46 if (epc_page)
47 return 0;
48
49 epc_page = sgx_alloc_epc_page(vepc, false);
50 if (IS_ERR(epc_page))
51 return PTR_ERR(epc_page);
52
53 ret = xa_err(xa_store(&vepc->page_array, index, epc_page, GFP_KERNEL));
54 if (ret)
55 goto err_free;
56
57 pfn = PFN_DOWN(sgx_get_epc_phys_addr(epc_page));
58
> 59 ret = vmf_insert_pfn(vma, addr, pfn);
> 60 if (ret != VM_FAULT_NOPAGE) {
61 ret = -EFAULT;
62 goto err_delete;
63 }
64
65 return 0;
66
67 err_delete:
68 xa_erase(&vepc->page_array, index);
69 err_free:
70 sgx_free_epc_page(epc_page);
71 return ret;
72 }
73
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 9+ messages in thread* arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types)
@ 2021-12-04 19:34 kernel test robot
0 siblings, 0 replies; 9+ messages in thread
From: kernel test robot @ 2021-12-04 19:34 UTC (permalink / raw)
To: Sean Christopherson; +Cc: kbuild-all, linux-kernel, Borislav Petkov, Kai Huang
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 12119cfa1052d512a92524e90ebee85029a918f8
commit: 540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba x86/sgx: Introduce virtual EPC for use by KVM guests
date: 8 months ago
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20211205/202112050357.x46al1AR-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 540745ddbc70eabdc7dbd3fcc00fe4fb17cd59ba
# save the config file to linux build tree
mkdir build_dir
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash arch/x86/hyperv/ arch/x86/kernel/cpu/sgx/ drivers/hv/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types) @@ expected int [assigned] ret @@ got restricted vm_fault_t @@
arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: expected int [assigned] ret
arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: got restricted vm_fault_t
>> arch/x86/kernel/cpu/sgx/virt.c:60:20: sparse: sparse: restricted vm_fault_t degrades to integer
arch/x86/kernel/cpu/sgx/virt.c:95:35: sparse: sparse: symbol 'sgx_vepc_vm_ops' was not declared. Should it be static?
vim +59 arch/x86/kernel/cpu/sgx/virt.c
32
33 static int __sgx_vepc_fault(struct sgx_vepc *vepc,
34 struct vm_area_struct *vma, unsigned long addr)
35 {
36 struct sgx_epc_page *epc_page;
37 unsigned long index, pfn;
38 int ret;
39
40 WARN_ON(!mutex_is_locked(&vepc->lock));
41
42 /* Calculate index of EPC page in virtual EPC's page_array */
43 index = vma->vm_pgoff + PFN_DOWN(addr - vma->vm_start);
44
45 epc_page = xa_load(&vepc->page_array, index);
46 if (epc_page)
47 return 0;
48
49 epc_page = sgx_alloc_epc_page(vepc, false);
50 if (IS_ERR(epc_page))
51 return PTR_ERR(epc_page);
52
53 ret = xa_err(xa_store(&vepc->page_array, index, epc_page, GFP_KERNEL));
54 if (ret)
55 goto err_free;
56
57 pfn = PFN_DOWN(sgx_get_epc_phys_addr(epc_page));
58
> 59 ret = vmf_insert_pfn(vma, addr, pfn);
> 60 if (ret != VM_FAULT_NOPAGE) {
61 ret = -EFAULT;
62 goto err_delete;
63 }
64
65 return 0;
66
67 err_delete:
68 xa_erase(&vepc->page_array, index);
69 err_free:
70 sgx_free_epc_page(epc_page);
71 return ret;
72 }
73
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-11-21 12:19 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-20 9:41 arch/x86/kernel/cpu/sgx/virt.c:59:13: sparse: sparse: incorrect type in assignment (different base types) kernel test robot
2024-10-22 17:39 ` Sean Christopherson
-- strict thread matches above, loose matches on Subject: below --
2024-11-20 5:59 kernel test robot
2024-11-20 15:05 ` Steven Rostedt
2024-11-21 12:19 ` Philip Li
2023-08-12 10:57 kernel test robot
2022-06-04 7:43 kernel test robot
2022-02-21 21:28 kernel test robot
2021-12-04 19:34 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox