Re: [PATCH v1 1/1] iio: gyro: bmg160: Drop most likely fake ACPI IDs

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 21 Oct 2024 09:47:16 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Fri, Oct 18, 2024 at 01:27:57PM -0700, Justin Weiss wrote:
> > Jonathan Cameron <jic23@kernel.org> writes:
> >   
> > > On Fri, 18 Oct 2024 17:57:32 +0300
> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> > >  
> > >> The commits in question do not proove that ACPI IDs exist.
> > >> Quite likely it was a cargo cult addition while doing that
> > >> for DT-based enumeration. Drop most likely fake ACPI IDs.
> > >> 
> > >> The to be removed IDs has been checked against the following resources:
> > >> 1) DuckDuckGo
> > >> 2) Google
> > >> 3) MS catalog: https://www.catalog.update.microsoft.com/Search.aspx
> > >> This gives no useful results in regard to DSDT, moreover, the official
> > >> vendor IDs in the registry for Bosh are BSG and BOSC.
> > >>   
> > >
> > > I'm nervous about Bosch drivers in the wild given recent report
> > > from Justin
> > > https://lore.kernel.org/linux-iio/87jzeboi3g.fsf@justinweiss.com/  
> 
> I know about Realtek case, but for BMI0/BMI it's interesting that MS
> catalog shows hits on BMI160 (note no leading zero!), but not on BMI0160.
> 
> > > Justin, I couldn't find the driver you were referring to for the bmi160,
> > > is it online somewhere?  
> > 
> > Yes, the BMI160/260 Windows driver is on this page:
> > https://ayaneo.com/support/download
> > 
> > It's at the very bottom, under "AYANEO Universal Gyro Driver." GPD also
> > has a copy inside their driver pack under the "Drivers & BIOS" tab here:
> > https://www.gpd.hk/gpdwinminifirmwaredriver, but the download is often  
> >>  at capacity unless you're signed into Google.  
> 
> I was not Cc'ed on ACPI ID parts, please make sure that the patch
> that adds it has a pointer to the actual device which uses it _and_
> DSDT excerpt of the respective Device object. Without that info provided,
> NAK from me.
Device we have in the patch comments. Justin if you can supply the DSDT
excerpts in reply to that patch that would be great.

I'll try and remember to check you are on the CC next time Andy.

Jonathan
> 
> > > Also if you have other bosch drivers could you check for these + bmc150
> > > IDs Andy is proposing dropping in:
> > >
> > > https://lore.kernel.org/linux-iio/20241018145805.2181682-1-andriy.shevchenko@linux.intel.com/  
> > 
> > Unfortunately, the 160/260 driver is the only one I have. I wanted gyro
> > support in Linux for a handheld PC I bought, and it was the IMU that
> > happened to be inside.  
>