From: Christoph Hellwig <hch@lst.de>
To: Liu Jing <liujing@cmss.chinamobile.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-pci: After the memory is released, the corresponding pointer needs to point to empty
Date: Tue, 22 Oct 2024 09:29:13 +0200 [thread overview]
Message-ID: <20241022072913.GA12854@lst.de> (raw)
In-Reply-To: <20241021190150.5974-1-liujing@cmss.chinamobile.com>
On Tue, Oct 22, 2024 at 03:01:50AM +0800, Liu Jing wrote:
> The code frees memory pointed to by dev->queues. After freeing memory,
> dev->queues should be set to NULL to avoid dangling Pointers.
How claims that? Clearing pointers clearly defeats redzoning in the
slab allocator so actually is counterproductive.
prev parent reply other threads:[~2024-10-22 7:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 19:01 [PATCH] nvme-pci: After the memory is released, the corresponding pointer needs to point to empty Liu Jing
2024-10-22 7:29 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022072913.GA12854@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=liujing@cmss.chinamobile.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox