From: linux@treblig.org
To: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: [PATCH 4/5] drm/client: Remove unused drm_client_framebuffer_flush
Date: Wed, 23 Oct 2024 00:29:33 +0100 [thread overview]
Message-ID: <20241022232934.238124-5-linux@treblig.org> (raw)
In-Reply-To: <20241022232934.238124-1-linux@treblig.org>
From: "Dr. David Alan Gilbert" <linux@treblig.org>
drm_client_framebuffer_flush() was explicitly added in 2020
by
commit c9c03e3cf072 ("drm/client: Add drm_client_framebuffer_flush()")
but has never been used.
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/gpu/drm/drm_client.c | 33 ---------------------------------
include/drm/drm_client.h | 1 -
2 files changed, 34 deletions(-)
diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
index bfedcbf516db..5d10ad3c2ca5 100644
--- a/drivers/gpu/drm/drm_client.c
+++ b/drivers/gpu/drm/drm_client.c
@@ -552,39 +552,6 @@ void drm_client_framebuffer_delete(struct drm_client_buffer *buffer)
}
EXPORT_SYMBOL(drm_client_framebuffer_delete);
-/**
- * drm_client_framebuffer_flush - Manually flush client framebuffer
- * @buffer: DRM client buffer (can be NULL)
- * @rect: Damage rectangle (if NULL flushes all)
- *
- * This calls &drm_framebuffer_funcs->dirty (if present) to flush buffer changes
- * for drivers that need it.
- *
- * Returns:
- * Zero on success or negative error code on failure.
- */
-int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect)
-{
- if (!buffer || !buffer->fb || !buffer->fb->funcs->dirty)
- return 0;
-
- if (rect) {
- struct drm_clip_rect clip = {
- .x1 = rect->x1,
- .y1 = rect->y1,
- .x2 = rect->x2,
- .y2 = rect->y2,
- };
-
- return buffer->fb->funcs->dirty(buffer->fb, buffer->client->file,
- 0, 0, &clip, 1);
- }
-
- return buffer->fb->funcs->dirty(buffer->fb, buffer->client->file,
- 0, 0, NULL, 0);
-}
-EXPORT_SYMBOL(drm_client_framebuffer_flush);
-
#ifdef CONFIG_DEBUG_FS
static int drm_client_debugfs_internal_clients(struct seq_file *m, void *data)
{
diff --git a/include/drm/drm_client.h b/include/drm/drm_client.h
index bc0e66f9c425..560aae47e06d 100644
--- a/include/drm/drm_client.h
+++ b/include/drm/drm_client.h
@@ -165,7 +165,6 @@ struct drm_client_buffer {
struct drm_client_buffer *
drm_client_framebuffer_create(struct drm_client_dev *client, u32 width, u32 height, u32 format);
void drm_client_framebuffer_delete(struct drm_client_buffer *buffer);
-int drm_client_framebuffer_flush(struct drm_client_buffer *buffer, struct drm_rect *rect);
int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer,
struct iosys_map *map_copy);
void drm_client_buffer_vunmap_local(struct drm_client_buffer *buffer);
--
2.47.0
next prev parent reply other threads:[~2024-10-22 23:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 23:29 [PATCH 0/5] DRM deadcode linux
2024-10-22 23:29 ` [PATCH 1/5] drm: Remove unused drm_atomic_helper_commit_planes_on_crtc linux
2024-10-28 13:16 ` Dmitry Baryshkov
2024-10-22 23:29 ` [PATCH 2/5] drm/sysfs: Remove unused drm_class_device_(un)register linux
2024-10-28 13:16 ` Dmitry Baryshkov
2024-10-22 23:29 ` [PATCH 3/5] drm/vblank: Remove unused drm_crtc_vblank_count_and_time linux
2024-10-28 15:49 ` Dmitry Baryshkov
2024-10-28 16:13 ` Ville Syrjälä
2024-10-28 16:54 ` Dr. David Alan Gilbert
2024-10-22 23:29 ` linux [this message]
2024-10-23 6:46 ` [PATCH 4/5] drm/client: Remove unused drm_client_framebuffer_flush Thomas Zimmermann
2024-10-23 8:04 ` Jocelyn Falempe
2024-10-23 11:03 ` Dr. David Alan Gilbert
2024-10-22 23:29 ` [PATCH 5/5] drm/client: Remove unused drm_client_modeset_check linux
2024-10-28 13:24 ` Dmitry Baryshkov
2024-10-28 13:52 ` Dr. David Alan Gilbert
2024-10-29 23:48 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241022232934.238124-5-linux@treblig.org \
--to=linux@treblig.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox