Re: [PATCH v3 1/4] PCI: dwc: ep: Add bus_addr_base for outbound window

kernel test robot
2024-10-22T19:42:06Z

Hi Frank,

kernel test robot noticed the following build errors:

[auto build test ERROR on afb15ca28055352101286046c1f9f01fdaa1ace1]

url: https://github.com/intel-lab-lkp/linux/commits/Frank-Li/PCI-dwc-ep-Add-bus_addr_base-for-outbound-window/20241022-041043
base: afb15ca28055352101286046c1f9f01fdaa1ace1
patch link: https://lore.kernel.org/r/20241021-pcie_ep_range-v3-1-b13526eb0089%40nxp.com
patch subject: [PATCH v3 1/4] PCI: dwc: ep: Add bus_addr_base for outbound window
config: arm-allmodconfig (https://download.01.org/0day-ci/archive/20241023/202410230328.BTHareG1-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241023/202410230328.BTHareG1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410230328.BTHareG1-lkp@intel.com/

All errors (new ones prefixed by >>):

drivers/pci/controller/dwc/pcie-designware-ep.c: In function 'dw_pcie_ep_init':
>> drivers/pci/controller/dwc/pcie-designware-ep.c:885:49: error: passing argument 3 of 'of_property_read_reg' from incompatible pointer type [-Wincompatible-pointer-types]
885 | of_property_read_reg(np, index, &ep->bus_addr_base, NULL);
| ^~~~~~~~~~~~~~~~~~
| |
| phys_addr_t * {aka unsigned int *}
In file included from drivers/pci/controller/dwc/pcie-designware-ep.c:12:
include/linux/of_address.h:75:64: note: expected 'u64 *' {aka 'long long unsigned int *'} but argument is of type 'phys_addr_t *' {aka 'unsigned int *'}
75 | int of_property_read_reg(struct device_node *np, int idx, u64 *addr, u64 *size);
| ~~~~~^~~~

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for GET_FREE_REGION
Depends on [n]: SPARSEMEM [=n]
Selected by [m]:
- RESOURCE_KUNIT_TEST [=m] && RUNTIME_TESTING_MENU [=y] && KUNIT [=m]

vim +/of_property_read_reg +885 drivers/pci/controller/dwc/pcie-designware-ep.c

846
847 /**
848 * dw_pcie_ep_init - Initialize the endpoint device
849 * @ep: DWC EP device
850 *
851 * Initialize the endpoint device. Allocate resources and create the EPC
852 * device with the endpoint framework.
853 *
854 * Return: 0 if success, errno otherwise.
855 */
856 int dw_pcie_ep_init(struct dw_pcie_ep *ep)
857 {
858 int ret;
859 struct resource *res;
860 struct pci_epc *epc;
861 struct dw_pcie *pci = to_dw_pcie_from_ep(ep);
862 struct device *dev = pci->dev;
863 struct platform_device *pdev = to_platform_device(dev);
864 struct device_node *np = dev->of_node;
865 int index;
866
867 INIT_LIST_HEAD(&ep->func_list);
868
869 ret = dw_pcie_get_resources(pci);
870 if (ret)
871 return ret;
872
873 res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space");
874 if (!res)
875 return -EINVAL;
876
877 ep->phys_base = res->start;
878 ep->bus_addr_base = ep->phys_base;
879
880 if (pci->using_dtbus_info) {
881 index = of_property_match_string(np, "reg-names", "addr_space");
882 if (index < 0)
883 return -EINVAL;
884
> 885 of_property_read_reg(np, index, &ep->bus_addr_base, NULL);

--
0-DAY CI Kernel Test Service