From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Ming Lei <ming.lei@redhat.com>,
zhuxiaohui <zhuxiaohui400@gmail.com>,
axboe@kernel.dk, kbusch@kernel.org, hch@lst.de,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvme@lists.infradead.org,
Zhu Xiaohui <zhuxiaohui.400@bytedance.com>
Subject: Re: [PATCH v1] blk-mq: add one blk_mq_req_flags_t type to support mq ctx fallback
Date: Wed, 23 Oct 2024 07:19:15 +0200 [thread overview]
Message-ID: <20241023051914.GA1341@lst.de> (raw)
In-Reply-To: <fe49daac-5990-464a-aeeb-c7c5f9d4d156@grimberg.me>
On Tue, Oct 22, 2024 at 04:23:29PM +0300, Sagi Grimberg wrote:
> I agree. NVMe may have a unique need here, but it needs a tag from a
> specific hctx while the context requesting it does not map according to
> the hctx cpumap. It cannot use any other tag from any other hctx.
>
> The reason is that the connect for a queue must be done from a tag that
> belongs to the queue because nvme relies on it when it does resolution back
> to
> the request to the completion.
I wonder if we should byte the bullet and not use a request for the
connect commands. We've already special cased the AEN command because
it was causing too many problems, and given all the pain so far connect
might also have hit that treshold.
next prev parent reply other threads:[~2024-10-23 5:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-20 14:40 [PATCH v1] blk-mq: add one blk_mq_req_flags_t type to support mq ctx fallback zhuxiaohui
2024-10-21 1:39 ` Ming Lei
2024-10-21 7:05 ` Sagi Grimberg
2024-10-21 8:31 ` Ming Lei
2024-10-21 11:30 ` Sagi Grimberg
2024-10-21 14:36 ` Ming Lei
2024-10-21 15:27 ` Sagi Grimberg
2024-10-22 1:13 ` Ming Lei
2024-10-22 13:23 ` Sagi Grimberg
2024-10-23 5:19 ` Christoph Hellwig [this message]
2024-10-23 9:42 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023051914.GA1341@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=zhuxiaohui.400@bytedance.com \
--cc=zhuxiaohui400@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox