Re: [PATCH net-next v3] selftest/tcp-ao: Add filter tests

Simon Horman
2024-10-23T12:53:19Z

On Mon, Oct 21, 2024 at 10:46:44AM -0700, Leo Stone wrote:
> Add tests that check if getsockopt(TCP_AO_GET_KEYS) returns the right
> keys when using different filters.
>
> Sample output:
>
> > # ok 114 filter keys: by sndid, rcvid, address
> > # ok 115 filter keys: by is_current
> > # ok 116 filter keys: by is_rnext
> > # ok 117 filter keys: by sndid, rcvid
> > # ok 118 filter keys: correct nkeys when in.nkeys < matches
>
> Acked-by: Dmitry Safonov <0x7f454c46@gmail.com>
> Signed-off-by: Leo Stone <leocstone@gmail.com>
> ---
> v3:
> - Ordered locals in reverse xmas tree order
> - Separated socket fd declaration from assignment
> - Broke lines longer than 80 columns
> v2: https://lore.kernel.org/netdev/20241016055823.21299-1-leocstone@gmail.com/
> - Changed 2 unnecessary test_error calls to test_fail
> - Added another test to make sure getsockopt returns the right nkeys
> value when the input nkeys is smaller than the number of matching keys
> - Removed the TODO that this patch addresses
> v1: https://lore.kernel.org/netdev/20241014213313.15100-1-leocstone@gmail.com/
>
> Thanks to the reviewers for their time and feedback!

Thanks for the updates.

Reviewed-by: Simon Horman <horms@kernel.org>