From: Heiko Carstens <hca@linux.ibm.com>
To: David Hildenbrand <david@redhat.com>
Cc: Alexander Egorenkov <egorenar@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH v3] s390/kdump: make is_kdump_kernel() consistently return "true" in kdump environments only
Date: Wed, 23 Oct 2024 14:53:51 +0200 [thread overview]
Message-ID: <20241023125351.8013-I-hca@linux.ibm.com> (raw)
In-Reply-To: <7da9f43f-e2a8-4079-8b1d-d7b16d8f388e@redhat.com>
On Wed, Oct 23, 2024 at 02:22:18PM +0200, David Hildenbrand wrote:
> On 23.10.24 14:12, Alexander Egorenkov wrote:
> > Here is a typo in the condition, a redundant '!' before is_ipl_type_dump().
> >
>
> Thanks for catching these! Too much going back and forth ... :)
>
> > Otherwise, looks very good to me.
>
> Thanks for the fast review. I assume these can be fixed up when applying.
> But please let me know if a v3 is preferred, and I can send one after
> waiting a couple of days.
Fixed typos, slightly reworded subject and commit message, and applied.
Thanks a lot!
prev parent reply other threads:[~2024-10-23 12:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 9:06 [PATCH v3] s390/kdump: make is_kdump_kernel() consistently return "true" in kdump environments only David Hildenbrand
2024-10-23 12:12 ` Alexander Egorenkov
2024-10-23 12:22 ` David Hildenbrand
2024-10-23 12:53 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241023125351.8013-I-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=egorenar@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox