From: Eric Biggers <ebiggers@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: linux-riscv@lists.infradead.org,
"Conor Dooley" <conor.dooley@microchip.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Clément Léger" <cleger@rivosinc.com>,
"Andy Chiu" <andybnac@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] RISC-V: add vector crypto extension validation checks
Date: Thu, 24 Oct 2024 19:08:10 -0700 [thread overview]
Message-ID: <20241025020810.GA1781@sol.localdomain> (raw)
In-Reply-To: <20241024-bunny-unexposed-196d8da36e7a@spud>
Thanks for working on this!
On Thu, Oct 24, 2024 at 01:34:29PM +0100, Conor Dooley wrote:
> @@ -308,12 +354,10 @@ const struct riscv_isa_ext_data riscv_isa_ext[] = {
> __RISCV_ISA_EXT_DATA(d, RISCV_ISA_EXT_d),
> __RISCV_ISA_EXT_DATA(q, RISCV_ISA_EXT_q),
> __RISCV_ISA_EXT_SUPERSET(c, RISCV_ISA_EXT_c, riscv_c_exts),
> - __RISCV_ISA_EXT_SUPERSET(v, RISCV_ISA_EXT_v, riscv_v_exts),
> + __RISCV_ISA_EXT_SUPERSET_VALIDATE(v, RISCV_ISA_EXT_v, riscv_v_exts, riscv_ext_vector_float_validate),
This patch adds validation for not just the vector crypto extensions but also v,
zve32f, zve32x, zve64d, zve64f, and zve64x. I think that should be split into a
separate patch or at least called out explicitly in the commit message.
> + __RISCV_ISA_EXT_BUNDLE_VALIDATE(zk, riscv_zk_bundled_exts, riscv_ext_vector_crypto_validate),
> + __RISCV_ISA_EXT_BUNDLE_VALIDATE(zkn, riscv_zkn_bundled_exts, riscv_ext_vector_crypto_validate),
> __RISCV_ISA_EXT_DATA(zknd, RISCV_ISA_EXT_ZKND),
> __RISCV_ISA_EXT_DATA(zkne, RISCV_ISA_EXT_ZKNE),
> __RISCV_ISA_EXT_DATA(zknh, RISCV_ISA_EXT_ZKNH),
> __RISCV_ISA_EXT_DATA(zkr, RISCV_ISA_EXT_ZKR),
> - __RISCV_ISA_EXT_BUNDLE(zks, riscv_zks_bundled_exts),
> + __RISCV_ISA_EXT_BUNDLE_VALIDATE(zks, riscv_zks_bundled_exts, riscv_ext_vector_crypto_validate),
zk* are the scalar crypto extensions, which don't require vector.
- Eric
next prev parent reply other threads:[~2024-10-25 2:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 12:34 [PATCH v2 0/5] Add some validation for vector, vector crypto and fp stuff Conor Dooley
2024-10-24 12:34 ` [PATCH v2 1/5] RISC-V: add vector crypto extension validation checks Conor Dooley
2024-10-25 2:08 ` Eric Biggers [this message]
2024-10-25 16:52 ` Conor Dooley
2024-10-24 12:34 ` [PATCH v2 2/5] RISC-V: add f & d " Conor Dooley
2024-10-24 12:34 ` [PATCH v2 3/5] dt-bindings: riscv: d requires f Conor Dooley
2024-10-24 12:34 ` [PATCH v2 4/5] dt-bindings: riscv: add vector sub-extension dependencies Conor Dooley
2024-10-24 12:34 ` [PATCH v2 5/5] dt-bindings: riscv: document vector crypto requirements Conor Dooley
2024-10-25 2:24 ` Eric Biggers
2024-10-25 2:42 ` Eric Biggers
2024-10-25 16:53 ` Conor Dooley
2025-01-18 0:54 ` Charlie Jenkins
2025-01-20 17:17 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025020810.GA1781@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=andybnac@gmail.com \
--cc=cleger@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox