The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Tamir Duberstein <tamird@gmail.com>
Cc: "Andy Whitcroft" <apw@canonical.com>,
	"Joe Perches" <joe@perches.com>,
	"Dwaipayan Ray" <dwaipayanray1@gmail.com>,
	"Lukas Bulwahn" <lukas.bulwahn@gmail.com>,
	"Simon Horman" <horms@kernel.org>,
	"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
	"Louis Peens" <louis.peens@corigine.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] checkpatch: always parse orig_commit in fixes tag
Date: Fri, 25 Oct 2024 14:47:13 -0700	[thread overview]
Message-ID: <20241025144713.49ec30423ecce710618235d5@linux-foundation.org> (raw)
In-Reply-To: <20241025-checkpatch-fixes-commit-v1-1-1b31f9ce178b@gmail.com>

On Fri, 25 Oct 2024 16:48:34 -0400 Tamir Duberstein <tamird@gmail.com> wrote:

> Do not require the presence of `$balanced_parens` to get the commit SHA;
> this allows a `Fixes: deadbeef` tag to get a correct suggestion rather
> than a suggestion containing a reference to HEAD.

Please prepare a more complete (and more understandable) description
of the issue.  Including sample input and checkpatch's response to that
input would be appropriate.  Then please resend.

Thanks.

      reply	other threads:[~2024-10-25 21:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25 20:48 [PATCH RESEND] checkpatch: always parse orig_commit in fixes tag Tamir Duberstein
2024-10-25 21:47 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241025144713.49ec30423ecce710618235d5@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=dwaipayanray1@gmail.com \
    --cc=horms@kernel.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.peens@corigine.com \
    --cc=lukas.bulwahn@gmail.com \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=tamird@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox