From: Aren Moynihan <aren@peacevolution.org>
To: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>
Cc: "Aren Moynihan" <aren@peacevolution.org>,
"Kaustabh Chakraborty" <kauschluss@disroot.org>,
"Barnabás Czémán" <trabarni@gmail.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Ondrej Jirman" <megi@xff.cz>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, "Dragan Simic" <dsimic@manjaro.org>,
phone-devel@vger.kernel.org
Subject: [PATCH v3 0/6] iio: light: stk3310: support powering off during suspend
Date: Mon, 28 Oct 2024 10:19:54 -0400 [thread overview]
Message-ID: <20241028142000.1058149-1-aren@peacevolution.org> (raw)
In the Pine64 PinePhone, the stk3310 chip is powered by a regulator that is
disabled at system boot and can be shut off during suspend. To ensure that
the chip properly initializes, both after boot and suspend, we need to
manage this regulator.
Additionally if the chip is shut off in suspend, we need to make sure that
it gets reinitialized with the same parameters after resume.
Major changes in v3:
- Use bulk regulators instead of two individual ones
- Replace stk3310_remove with devm callbacks
- Hopefully I haven't missed anything, it's been a while since I worked on this
patch, and I didn't take good enough notes
Major changes in v2:
- Add handling of the IR LED. I was hesitant to include this as it is the
same as pull-up regulator for the i2c bus on the hardware I have, so I
can't test it well. I think leaving it out is more likely to cause
issues than including it.
- Convert stk3310 to use dev_err_probe for errors.
- Always enable / disable regulators and rely on dummy devices if they're
not specified.
- more listed in individual patches
Aren Moynihan (5):
dt-bindings: iio: light: stk33xx: add vdd and leda regulators
iio: light: stk3310: handle all remove logic with devm callbacks
iio: light: stk3310: Implement vdd and leda supplies
iio: light: stk3310: use dev_err_probe where possible
iio: light: stk3310: log error if reading the chip id fails
Ondrej Jirman (1):
arm64: dts: allwinner: pinephone: Add power supplies to stk3311
.../bindings/iio/light/stk33xx.yaml | 4 +
.../dts/allwinner/sun50i-a64-pinephone.dtsi | 2 +
drivers/iio/light/stk3310.c | 156 +++++++++++++-----
3 files changed, 118 insertions(+), 44 deletions(-)
--
2.47.0
next reply other threads:[~2024-10-28 14:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 14:19 Aren Moynihan [this message]
2024-10-28 14:19 ` [PATCH v3 1/6] dt-bindings: iio: light: stk33xx: add vdd and leda regulators Aren Moynihan
2024-10-28 14:19 ` [PATCH v3 2/6] iio: light: stk3310: handle all remove logic with devm callbacks Aren Moynihan
2024-10-28 14:19 ` [PATCH v3 3/6] iio: light: stk3310: Implement vdd and leda supplies Aren Moynihan
2024-10-28 14:38 ` Andy Shevchenko
2024-10-28 16:37 ` Aren Moynihan
2024-10-28 20:38 ` Jonathan Cameron
2024-10-28 20:44 ` Dragan Simic
2024-10-28 14:19 ` [PATCH v3 4/6] iio: light: stk3310: use dev_err_probe where possible Aren Moynihan
2024-10-28 14:44 ` Andy Shevchenko
2024-10-28 14:19 ` [PATCH v3 5/6] iio: light: stk3310: log error if reading the chip id fails Aren Moynihan
2024-10-28 14:45 ` Andy Shevchenko
2024-10-28 15:29 ` Aren
2024-10-28 15:59 ` Andy Shevchenko
2024-10-28 14:20 ` [PATCH v3 6/6] arm64: dts: allwinner: pinephone: Add power supplies to stk3311 Aren Moynihan
2024-10-28 20:42 ` [PATCH v3 0/6] iio: light: stk3310: support powering off during suspend Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028142000.1058149-1-aren@peacevolution.org \
--to=aren@peacevolution.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=jernej.skrabec@gmail.com \
--cc=jic23@kernel.org \
--cc=kauschluss@disroot.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=megi@xff.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=trabarni@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox