From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dionna Glaze <dionnaglaze@google.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Luis Chamberlain <mcgrof@kernel.org>,
Russ Weight <russ.weight@linux.dev>,
Danilo Krummrich <dakr@redhat.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Tianfei zhang <tianfei.zhang@intel.com>,
Russ Weight <russell.h.weight@intel.com>
Subject: Re: [PATCH 2/4] firmware_loader: Move module refcounts to allow unloading
Date: Wed, 30 Oct 2024 01:14:24 +0100 [thread overview]
Message-ID: <2024103012-precise-utmost-f423@gregkh> (raw)
In-Reply-To: <20241029183907.3536683-3-dionnaglaze@google.com>
On Tue, Oct 29, 2024 at 06:39:02PM +0000, Dionna Glaze wrote:
> If a kernel module registers a firmware upload API ops set, then it's
> unable to be moved due to effectively a cyclic reference that the module
> depends on the upload which depends on the module.
>
> Instead, only require the try_module_get when an upload is requested to
> disallow unloading a module only while the upload is in progress.
>
> Fixes: 97730bbb242cd ("firmware_loader: Add firmware-upload support")
>
> CC: Luis Chamberlain <mcgrof@kernel.org>
> CC: Russ Weight <russ.weight@linux.dev>
> CC: Danilo Krummrich <dakr@redhat.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: "Rafael J. Wysocki" <rafael@kernel.org>
> CC: Tianfei zhang <tianfei.zhang@intel.com>
>
> Signed-off-by: Dionna Glaze <dionnaglaze@google.com>
> Change-Id: Ifac9513de2f58a5120d4c0a681e969cd71cd3c68
Please always run checkpatch on a change before sending it out :(
next prev parent reply other threads:[~2024-10-30 0:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 18:39 [PATCH 0/4] Support SEV firmware hotloading Dionna Glaze
2024-10-29 18:39 ` [PATCH 1/4] kvm: svm: Fix gctx page leak on invalid inputs Dionna Glaze
2024-10-29 18:39 ` [PATCH 2/4] firmware_loader: Move module refcounts to allow unloading Dionna Glaze
2024-10-30 0:14 ` Greg Kroah-Hartman [this message]
2024-10-31 15:53 ` Russ Weight
2024-10-29 18:39 ` [PATCH 3/4] crypto: ccp: Add SNP firmware hotload support Dionna Glaze
2024-10-31 10:43 ` Kalra, Ashish
2024-10-29 18:39 ` [PATCH 4/4] KVM: SVM: Delay legacy platform initialization on SNP Dionna Glaze
2024-10-31 8:17 ` Kalra, Ashish
2024-10-31 8:00 ` [PATCH 2/4] firmware_loader: Move module refcounts to allow unloading Ashish Kalra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024103012-precise-utmost-f423@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dakr@redhat.com \
--cc=dionnaglaze@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rafael@kernel.org \
--cc=russ.weight@linux.dev \
--cc=russell.h.weight@intel.com \
--cc=tianfei.zhang@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox