From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH v1 0/4] iio: acpi: always initialise data in iio_get_acpi_device_name_and_data()
Date: Wed, 30 Oct 2024 18:02:16 +0200 [thread overview]
Message-ID: <20241030160756.2099326-1-andriy.shevchenko@linux.intel.com> (raw)
Dan reported that data might be used uninitialised in some cases.
Let's initialise it to NULL (patch 1). With that, update one driver
to drop an unneeded anymore check (patch 2). Another driver (patch 4)
gain almost a dead code — feel free to not apply it.
While at it, one more cleanup to kxcjk-1013 (patch 3) is added.
Jonathan, dunno if you want to rebase at this stage (probably not),
but if you do, feel free to fold the patches 1-2 to the initial code.
The rest seems to me like the independent patches.
Andy Shevchenko (4):
iio: acpi: Fill data with NULL when
iio_get_acpi_device_name_and_data() fails
iio: accel: kxcjk-1013: Drop duplicate NULL check in kxcjk1013_probe()
iio: accel: kxcjk-1013: Deduplicate ODR startup time array
iio: light: isl29018: Check if name is valid in isl29018_probe()
drivers/iio/accel/kxcjk-1013.c | 28 +++++-----------------------
drivers/iio/industrialio-acpi.c | 6 +++++-
drivers/iio/light/isl29018.c | 2 ++
3 files changed, 12 insertions(+), 24 deletions(-)
--
2.43.0.rc1.1336.g36b5255a03ac
next reply other threads:[~2024-10-30 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 16:02 Andy Shevchenko [this message]
2024-10-30 16:02 ` [PATCH v1 1/4] iio: acpi: Fill data with NULL when iio_get_acpi_device_name_and_data() fails Andy Shevchenko
2024-10-31 19:17 ` Jonathan Cameron
2024-11-01 8:14 ` Andy Shevchenko
2024-10-30 16:02 ` [PATCH v1 2/4] iio: accel: kxcjk-1013: Drop duplicate NULL check in kxcjk1013_probe() Andy Shevchenko
2024-10-30 16:02 ` [PATCH v1 3/4] iio: accel: kxcjk-1013: Deduplicate ODR startup time array Andy Shevchenko
2024-10-30 16:02 ` [PATCH v1 4/4] iio: light: isl29018: Check if name is valid in isl29018_probe() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030160756.2099326-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox