Re: [PATCH v2 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

Andreas Kemnade
2024-10-31T07:32:55Z

Hi,

Am Thu, 31 Oct 2024 06:55:24 +0000
schrieb Mithil Bavishi <bavishimithil@gmail.com>:

> > this has to be system-power-controller;
>
> I am so sorry for the mess up, I was on the wrong branch which is
> almost the same as pmOS but a bit older, hence the entire mess up.
> I'll run a quick diff from pmOS and this patch and fix them
> accordingly.
>
> > There is still a lot other stuff to fix here but I want to make
> > sure we are looking at the right thing.
>
> Could you please go ahead and mention them as well.
>
well, that takes time, I wanted to start that on the right thing.

1. make dtbs shows warnings

2. make CHECK_DTBS=y ti/omap/omap4-samsung-espresso7.dtb is too noisy
(probably same for espresso10).

a lot comes from the dtsi files, so you need to ignore a lot, probably
either strip down the new dts to almost nothing besides dtsi includes
to determine the background noise or take a similar device, redirect
output and errors, diff that output with the full devicetree.
I am trying to clean that dtsi warning mess up, linux-next shows a lot
less warnings but that takes time.

One of the warnings that should be fixed:
dts/ti/omap/omap4-samsung-espresso7.dtb: lvds-encoder: compatible:
'oneOf' conditional failed, one must be fixed: ['lvds-encoder'] is too
short 'lvds-encoder' is not one of ['ti,ds90c185', 'ti,ds90c187',
'ti,sn75lvds83'] 'lvds-encoder' is not one of ['ti,ds90cf364a',
'ti,ds90cf384a', 'ti,sn65lvds94'] 'lvds-encoder' is not one of
['thine,thc63lvdm83d'] from schema $id:
http://devicetree.org/schemas/display/bridge/lvds-codec.yaml

Regards,
Andreas