Re: [PATCH v2 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

Andreas Kemnade
2024-10-30T22:42:29Z

Hi Mithil,

Am Wed, 30 Oct 2024 21:12:11 +0000
schrieb Mithil Bavishi <bavishimithil@gmail.com>:

> + twl: twl@48 {
> + reg = <0x48>;
> + #clock-cells = <1>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <
> + &twl6030_pins
> + &twl6030_wkup_pins
> + >;
> +
> + /* SPI = 0, IRQ# = 7, 4 = active high
> level-sensitive */
> + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /*
> IRQ_SYS_1N cascaded to gic */
> + interrupt-parent = <&gic>;
> + ti,system-power-controller;

this has to be system-power-controller;

And you have it correctly here:
https://gitlab.postmarketos.org/postmarketOS/pmaports/-/blob/master/device/community/linux-postmarketos-omap/0002-arm-dts-Add-common-dtsi-for-espresso.patch?ref_type=heads#L532

so, please double-check if you are trying to mainline the right branch.
No need to respin just for this line. There is still a lot other stuff
to fix here but I want to make sure we are looking at the right thing.

Regards,
Andreas