Re: [PATCH v2 2/6] arm/dts: Add common device tree for Samsung Galaxy Tab 2 series

Andreas Kemnade
2024-11-08T10:41:59Z

Am Fri, 8 Nov 2024 09:51:07 +0000
schrieb Mithil Bavishi <bavishimithil@gmail.com>:

> > probably you did not notice an error in make dtbs and the old
> > devicetree on the device was still there and was used.
>
> I messed up my PowerVR tree with mainline, hence the problems. I've fixed
> it now locally.
>
> > are not the ones you need to fix, so just the diff between old and new.
>
> Yeah, I ran the command for espresso and then panda for a comparision.
> The diff is what i worked on, but I have some doubts which I'd like to ask
>
> dts/ti/omap/omap4-samsung-espresso7.dtb: /: irled@0: 'anyOf' conditional
> failed, one must be fixed:
> 'reg' is a required property
> 'ranges' is a required property
> from schema $id: http://devicetree.org/schemas/root-node.yaml#
>
> Documentation/devicetree/bindings/leds/irled/gpio-ir-tx.yaml does not say
> those properties to be required, is the node placed incorrectly?
>
Well, anything with @ in the node nade needs reg as a property. So
probably best is led-ir since having reg does not make any sense here
since we are not on a bus with devices having addresses on that bus.

> /home/mighty/linux/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb:
> /: pwm@10: 'anyOf' conditional failed, one must be fixed:
> 'reg' is a required property
> 'ranges' is a required property
> from schema $id: http://devicetree.org/schemas/root-node.yaml#
>
> Similarly here as well.
>
Same issue here, too.

> /home/mighty/linux/arch/arm/boot/dts/ti/omap/omap4-samsung-espresso7.dtb:
> current-sense-shunt: 'io-channel-ranges' does not match any of the
> regexes: 'pinctrl-[0-9]+'
> from schema $id:
> http://devicetree.org/schemas/iio/afe/current-sense-shunt.yaml#
>
> I tried searching the tree for "io-channel-ranges" which has only one
> example - ste-ux500-samsung-janice.dts. In that dts the node is same as
> in espresso.
>
Not documented, so not allowed. There is code using it in kernel, but
that might only come into effect if current-sense-shunt has children
nodes. So drop it and check functionality.

Regards,
Andreas