From: Andrea Righi <arighi@nvidia.com>
To: Tejun Heo <tj@kernel.org>, David Vernet <void@manifault.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH sched_ext/for-6.13] sched_ext: Do not enable LLC/NUMA optimizations when domains overlap
Date: Thu, 31 Oct 2024 08:34:01 +0100 [thread overview]
Message-ID: <20241031073401.13034-1-arighi@nvidia.com> (raw)
When the LLC and NUMA domains fully overlap, enabling both optimizations
in the built-in idle CPU selection policy is redundant, as it leads to
searching for an idle CPU within the same domain twice.
Likewise, if all online CPUs are within a single LLC domain, LLC
optimization is unnecessary.
Therefore, detect overlapping domains and enable topology optimizations
only when necessary.
Fixes: 860a45219bce ("sched_ext: Introduce NUMA awareness to the default idle selection policy")
Signed-off-by: Andrea Righi <arighi@nvidia.com>
---
kernel/sched/ext.c | 23 ++++++++++++++++++-----
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index fc7f15eefe54..82acbaffd5a7 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -3140,7 +3140,7 @@ static void update_selcpu_topology(void)
{
bool enable_llc = false, enable_numa = false;
struct sched_domain *sd;
- const struct cpumask *cpus;
+ const struct cpumask *llc_cpus = NULL, *numa_cpus = NULL;
s32 cpu = cpumask_first(cpu_online_mask);
/*
@@ -3154,16 +3154,29 @@ static void update_selcpu_topology(void)
rcu_read_lock();
sd = rcu_dereference(per_cpu(sd_llc, cpu));
if (sd) {
- cpus = sched_domain_span(sd);
- if (cpumask_weight(cpus) < num_possible_cpus())
+ llc_cpus = sched_domain_span(sd);
+ if (cpumask_weight(llc_cpus) < num_possible_cpus())
enable_llc = true;
}
sd = highest_flag_domain(cpu, SD_NUMA);
if (sd) {
- cpus = sched_group_span(sd->groups);
- if (cpumask_weight(cpus) < num_possible_cpus())
+ numa_cpus = sched_group_span(sd->groups);
+ if (cpumask_weight(numa_cpus) < num_possible_cpus())
enable_numa = true;
}
+ /*
+ * If the NUMA domain perfectly overlaps with the LLC domain, enable
+ * LLC optimization only, as checking for an idle CPU in the same
+ * domain twice is redundant.
+ */
+ if (enable_numa && enable_llc && cpumask_equal(numa_cpus, llc_cpus))
+ enable_numa = false;
+ /*
+ * If all the online CPUs are in the same LLC domain, there is no
+ * reason to enable LLC optimization.
+ */
+ if (enable_llc && cpumask_equal(llc_cpus, cpu_online_mask))
+ enable_llc = false;
rcu_read_unlock();
pr_debug("sched_ext: LLC idle selection %s\n",
--
2.47.0
next reply other threads:[~2024-10-31 7:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 7:34 Andrea Righi [this message]
2024-11-05 23:32 ` [PATCH sched_ext/for-6.13] sched_ext: Do not enable LLC/NUMA optimizations when domains overlap Tejun Heo
2024-11-06 0:29 ` Andrea Righi
2024-11-06 0:33 ` Tejun Heo
2024-11-06 1:08 ` Andrea Righi
2024-11-06 1:15 ` Tejun Heo
2024-11-06 1:25 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031073401.13034-1-arighi@nvidia.com \
--to=arighi@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox