From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: John Stultz <jstultz@google.com>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: [patch 0/2] timekeeping: Fall cleaning
Date: Thu, 31 Oct 2024 13:04:06 +0100 (CET) [thread overview]
Message-ID: <20241031115448.978498636@linutronix.de> (raw)
The sanity checks under CONFIG_TIMEKEEPING_DEBUG have served their purpose
for some time, but now that timekeeping handles potential 64bit math
overflow correctly and is unconditionally protected against negative motion
of time, these checks have no real value anymore.
CONFIG_CLOCKSOURCE_VALIDATE_LAST_CYCLE, which contains a protection against
negative motion of time is only used on x86. It used to be in the
timekeeper hot path, but now it's only in relative slow paths (watchdog and
timekeeping_advance()). This protection is useful in general and the extra
conditional in these usage sites does not really matter.
This series removes CONFIG_TIMEKEEPING_DEBUG and related code and makes the
negative protected variant of clocksource_delta() unconditional.
The series applies on top of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core
Thanks,
tglx
---
arch/riscv/configs/defconfig | 1
arch/x86/Kconfig | 1
include/linux/timekeeper_internal.h | 16 --
kernel/time/Kconfig | 5
kernel/time/timekeeping.c | 108 --------------------
kernel/time/timekeeping_internal.h | 7 -
lib/Kconfig.debug | 13 --
tools/testing/selftests/wireguard/qemu/debug.config | 1
8 files changed, 3 insertions(+), 149 deletions(-)
next reply other threads:[~2024-10-31 12:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 12:04 Thomas Gleixner [this message]
2024-10-31 12:04 ` [patch 1/2] timekeeping: Remove CONFIG_DEBUG_TIMEKEEPING Thomas Gleixner
2024-11-02 4:14 ` John Stultz
2024-11-02 9:24 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-10-31 12:04 ` [patch 2/2] timekeeping: Always check for negative motion Thomas Gleixner
2024-11-02 4:15 ` John Stultz
2024-11-02 9:24 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-11-25 0:48 ` [patch 2/2] " Guenter Roeck
2024-11-27 22:08 ` John Stultz
2024-11-27 23:02 ` Guenter Roeck
2024-11-28 14:51 ` Thomas Gleixner
2024-11-28 15:30 ` Guenter Roeck
2024-11-29 12:16 ` Thomas Gleixner
2024-11-29 16:09 ` Guenter Roeck
2024-11-30 11:09 ` Thomas Gleixner
2024-11-30 18:21 ` Guenter Roeck
2024-12-03 10:16 ` [patch] clocksource: Make negative motion detection more robust Thomas Gleixner
2024-12-05 15:11 ` [tip: timers/urgent] " tip-bot2 for Thomas Gleixner
2024-11-28 15:57 ` [patch 2/2] timekeeping: Always check for negative motion Guenter Roeck
2024-11-28 17:13 ` Guenter Roeck
2024-11-28 17:47 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031115448.978498636@linutronix.de \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox