From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Machon <daniel.machon@microchip.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Lars Povlsen <lars.povlsen@microchip.com>,
"Steen Hegelund" <Steen.Hegelund@microchip.com>,
<horatiu.vultur@microchip.com>,
<jensemil.schulzostergaard@microchip.com>,
<Parthiban.Veerasooran@microchip.com>,
<Raju.Lakkaraju@microchip.com>, <UNGLinuxDriver@microchip.com>,
Richard Cochran <richardcochran@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, <jacob.e.keller@intel.com>,
<ast@fiberby.net>, <maxime.chevallier@bootlin.com>,
<horms@kernel.org>, <netdev@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next v2 10/15] net: lan969x: add PTP handler function
Date: Thu, 31 Oct 2024 17:16:13 -0700 [thread overview]
Message-ID: <20241031171613.565e6eb7@kernel.org> (raw)
In-Reply-To: <20241031093628.faiupqqny7oco7uz@DEN-DL-M70577>
On Thu, 31 Oct 2024 09:36:28 +0000 Daniel Machon wrote:
> > For a followup for both drivers -- you're mixing irqsave and bare
> > spin_lock() here. The _irqsave/_irqrestore is not necessary, let's
> > drop it.
> >
> > > + spin_lock(&sparx5->ptp_ts_id_lock);
>
> Hi Jakub,
>
> I agree it seems wrong to mix these.
>
> I just talked to Horatiu, and he mentioned posting a similar fix for the
> lan966x driver some time ago [1]. Only this fix added
> _irqsave/_irqrestore to the ptp_ts_id_lock - so basically the opposite
> of what you are suggesting. Why do you think that the
> _irqsave/_irqrestore is not necessary?
Oh, I thought this is a real IRQ handler, not a threaded one.
I haven't read the code to figure out whether ptp_ts_id_lock
needs to be IRQ-safe, but in other places you lock if _irqsave
so yes, let's irqsave here, too.
next prev parent reply other threads:[~2024-11-01 0:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 22:01 [PATCH net-next v2 00/15] net: sparx5: add support for lan969x switch device Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 01/15] net: sparx5: add support for lan969x targets and core clock Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 02/15] net: sparx5: change spx5_wr to spx5_rmw in cal update() Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 03/15] net: sparx5: change frequency calculation for SDLB's Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 04/15] net: sparx5: add sparx5 context pointer to a few functions Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 05/15] net: sparx5: add registers required by lan969x Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 06/15] net: lan969x: add match data for lan969x Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 07/15] net: lan969x: add register diffs to match data Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 08/15] net: lan969x: add constants " Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 09/15] net: lan969x: add lan969x ops " Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 10/15] net: lan969x: add PTP handler function Daniel Machon
2024-10-24 0:54 ` Vadim Fedorenko
2024-10-25 7:17 ` Daniel Machon
2024-10-31 1:07 ` Jakub Kicinski
2024-10-31 9:36 ` Daniel Machon
2024-11-01 0:16 ` Jakub Kicinski [this message]
2024-10-23 22:01 ` [PATCH net-next v2 11/15] net: lan969x: add function for calculating the DSM calendar Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 12/15] net: sparx5: use is_sparx5() macro throughout Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 13/15] dt-bindings: net: add compatible strings for lan969x targets Daniel Machon
2024-10-24 7:36 ` Krzysztof Kozlowski
2024-10-23 22:01 ` [PATCH net-next v2 14/15] net: sparx5: add compatible string for lan969x Daniel Machon
2024-10-23 22:01 ` [PATCH net-next v2 15/15] net: sparx5: add feature support Daniel Machon
2024-10-31 1:30 ` [PATCH net-next v2 00/15] net: sparx5: add support for lan969x switch device patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031171613.565e6eb7@kernel.org \
--to=kuba@kernel.org \
--cc=Parthiban.Veerasooran@microchip.com \
--cc=Raju.Lakkaraju@microchip.com \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=conor+dt@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jensemil.schulzostergaard@microchip.com \
--cc=krzk+dt@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).