From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: David Vernet <void@manifault.com>,
linux-kernel@vger.kernel.org, sched-ext@meta.com,
kernel-team@meta.com, Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH sched_ext/for-6.12-fixes] sched_ext: Call __balance_callbacks() from __scx_task_iter_rq_unlock()
Date: Fri, 1 Nov 2024 00:36:34 +0100 [thread overview]
Message-ID: <20241031233634.GU14555@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <ZyKoE9RUulWtYpEh@slm.duckdns.org>
On Wed, Oct 30, 2024 at 11:41:39AM -1000, Tejun Heo wrote:
> --- a/kernel/sched/ext.c
> +++ b/kernel/sched/ext.c
> @@ -1315,6 +1315,8 @@ static void scx_task_iter_start(struct s
> static void __scx_task_iter_rq_unlock(struct scx_task_iter *iter)
> {
> if (iter->locked) {
> + /* ->switched_from() may have scheduled balance callbacks */
> + __balance_callbacks(iter->rq);
> task_rq_unlock(iter->rq, iter->locked, &iter->rf);
> iter->locked = NULL;
> }
I think you need to unpin/repin around it. The balance callbacks like to
drop rq->lock at times.
next prev parent reply other threads:[~2024-10-31 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 21:41 [PATCH sched_ext/for-6.12-fixes] sched_ext: Call __balance_callbacks() from __scx_task_iter_rq_unlock() Tejun Heo
2024-10-31 23:36 ` Peter Zijlstra [this message]
2024-11-01 14:12 ` Peter Zijlstra
2024-11-08 20:36 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031233634.GU14555@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=sched-ext@meta.com \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox