Re: [for-next][PATCH 03/11] kdb: Replace the use of simple_strto with safer kstrto in kdb_main

Nir Lichtman
2024-11-01T18:42:29Z

On Fri, Nov 01, 2024 at 06:22:04PM +0000, Daniel Thompson wrote:
> On Fri, Nov 01, 2024 at 10:31:28AM -0400, Steven Rostedt wrote:
> > On Fri, 1 Nov 2024 07:21:05 -0700
> > Doug Anderson <dianders@chromium.org> wrote:
> >
> > > FWIW, I personally have no objection to this patch and patch #3/3 in
> > > Nir's series (#5/11 in your email thread) going through the ftrace
> > > tree, I'm not actually the maintainer of kdb/kgdb. I'm a reviewer and
> > > I try my best to help, but officially you should probably have Daniel
> > > Thompson's Ack for them. ...or at least make sure he's CCed here
> > > saying that you've picked them up.
> > >
> > > I've added him to the conversation here.
> >
> > Sure, I can even drop this patch if need be. Thanks for adding Daniel to
> > the Cc. I probably should have run these patches through get maintainers to
> > make sure everyone was accounted for.
>
>
> I presume the tracing tree is involved because one of them changes the
> kdb ftrace command? Are there dependencies between that and other
> patches in the seriesm?

I assume that is the reason, I just used the same recipient list that
the original author of the patch series used a couple of months ago.
The patch series is mostly around migrating to usage of better string
to int conversion functions, so technically each change is not really
dependant on the others.

BTW, Thanks for the reviews Doug and for applying Steven.

Nir.

>
>
> Daniel.