[PATCH 1/9] Fix buffer overflow in ni_usb_init

Dave Penkler
2024-11-01T17:47:43Z

The writes buffer size was taking into accont the number of
entries causing random oopses.

Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
index 571f07800c9a..9ff56b063681 100644
--- a/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
+++ b/drivers/staging/gpib/ni_usb/ni_usb_gpib.c
@@ -1726,7 +1726,7 @@ static int ni_usb_init(gpib_board_t *board)
unsigned int ibsta;
int writes_len;

- writes = kmalloc(sizeof(*writes), GFP_KERNEL);
+ writes = kmalloc(sizeof(*writes) * NUM_INIT_WRITES, GFP_KERNEL);
if (!writes)
return -ENOMEM;

--
2.46.2