Re: [PATCH 2/2 resend] dt-bindings: firmware: imx95-scmi: Allow linux,code for protocol@81

Rob Herring
2024-11-01T19:55:44Z

On Wed, Oct 30, 2024 at 10:55:52AM +0100, Alexander Stein wrote:
> BBM protocol supports a single power button, supported by driver
> imx-sm-bbm-key.c. By default this is KEY_POWER, but can also be overwritten
> using linux,code. Add a reference to this schema and add linux,code as a
> supported property.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> Admittedly, I'm not sure if this is the correct way of referencing the
> linux,code from input.yaml.
>
> .../devicetree/bindings/firmware/nxp,imx95-scmi.yaml | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
> index 1a95010a546b1..112c3a3eb1980 100644
> --- a/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/nxp,imx95-scmi.yaml
> @@ -12,13 +12,18 @@ maintainers:
>
> properties:
> protocol@81:
> - $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
> - unevaluatedProperties: false
> + type: object
> + allOf:
> + - $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
> + - $ref: /schemas/input/input.yaml#
> + additionalProperties: false
>
> properties:
> reg:
> const: 0x81
>
> + linux,code: true

default: ??

> +
> protocol@84:
> $ref: '/schemas/firmware/arm,scmi.yaml#/$defs/protocol-node'
> unevaluatedProperties: false
> --
> 2.34.1
>