From: Greg KH <gregkh@linuxfoundation.org>
To: Dave Penkler <dpenkler@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, arnd@arndb.de
Subject: Re: [PATCH 0/9] Patch set for gpib staging drivers
Date: Sat, 2 Nov 2024 01:51:35 +0100 [thread overview]
Message-ID: <2024110240-wound-quicken-a70c@gregkh> (raw)
In-Reply-To: <20241101174705.12682-1-dpenkler@gmail.com>
On Fri, Nov 01, 2024 at 06:46:56PM +0100, Dave Penkler wrote:
> Patch 1 is a bug fix
> Patches 2-6 replace custom debug with dev_dbg as well as
> using dev_xxx for pr_xxx where feasible.
> Patch 7 Corrects some errors in Kconfig
> Patch 8 is a code cleanup
> Patch 9 corrects GPIB behaviour
>
> Dave Penkler (9):
> Fix buffer overflow in ni_usb_init
> Replace custom debug with dev_dbg
> Update messaging and usb_device refs in ni_usb
> Update messaging and usb_device refs in agilent_usb
> Remove GPIB_DEBUG reference and update messaging
> Use dev_xxx for messaging
> Fix Kconfig
> Rationalize lookup tables
> Correct check for max secondary address
The subject lines for all of these need to have something like:
staging: gpib: ....
as a prefix, otherwise they don't make much sense when looking at all of
the commits in the whole tree.
Can you fix that up, and the other issues pointed out by people, and
send a v2 series?
thanks,
greg k-h
prev parent reply other threads:[~2024-11-02 0:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 17:46 [PATCH 0/9] Patch set for gpib staging drivers Dave Penkler
2024-11-01 17:46 ` [PATCH 1/9] Fix buffer overflow in ni_usb_init Dave Penkler
2024-11-01 19:46 ` Dan Carpenter
2024-11-01 17:46 ` [PATCH 2/9] Replace custom debug with dev_dbg Dave Penkler
2024-11-01 17:46 ` [PATCH 3/9] Update messaging and usb_device refs in ni_usb Dave Penkler
2024-11-01 19:48 ` Dan Carpenter
2024-11-01 17:47 ` [PATCH 4/9] Update messaging and usb_device refs in agilent_usb Dave Penkler
2024-11-01 17:47 ` [PATCH 5/9] Remove GPIB_DEBUG reference and update messaging Dave Penkler
2024-11-01 17:47 ` [PATCH 6/9] Use dev_xxx for messaging Dave Penkler
2024-11-01 17:47 ` [PATCH 7/9] Fix Kconfig Dave Penkler
2024-11-01 19:51 ` Dan Carpenter
2024-11-01 20:03 ` Dan Carpenter
2024-11-01 17:47 ` [PATCH 8/9] Rationalize lookup tables Dave Penkler
2024-11-01 19:55 ` Dan Carpenter
2024-11-01 17:47 ` [PATCH 9/9] Correct check for max secondary address Dave Penkler
2024-11-01 19:59 ` Dan Carpenter
2024-11-02 0:51 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024110240-wound-quicken-a70c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=dpenkler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox