* [PATCH 1/5] drm/amd/display: Remove unused enable_surface_flip_reporting
2024-11-04 2:38 [PATCH 0/5] Some more drm/amd/display deadcoding linux
@ 2024-11-04 2:38 ` linux
2024-11-04 2:38 ` [PATCH 2/5] drm/amd/display: Remove unused dwb3_set_host_read_rate_control linux
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: linux @ 2024-11-04 2:38 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
christian.koenig, Xinhui.Pan, chaitanya.dhere, jun.lei
Cc: airlied, simona, amd-gfx, dri-devel, linux-kernel,
Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
enable_surface_flip_reporting() has been unused since it was added by
commit 4562236b3bc0 ("drm/amd/dc: Add dc display driver (v2)")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/gpu/drm/amd/display/dc/core/dc_surface.c | 7 -------
drivers/gpu/drm/amd/display/dc/inc/core_types.h | 3 ---
2 files changed, 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_surface.c b/drivers/gpu/drm/amd/display/dc/core/dc_surface.c
index ccbb15f1638c..3299684f9a4e 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_surface.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_surface.c
@@ -83,13 +83,6 @@ uint8_t dc_plane_get_pipe_mask(struct dc_state *dc_state, const struct dc_plane
/*******************************************************************************
* Public functions
******************************************************************************/
-void enable_surface_flip_reporting(struct dc_plane_state *plane_state,
- uint32_t controller_id)
-{
- plane_state->irq_source = controller_id + DC_IRQ_SOURCE_PFLIP1 - 1;
- /*register_flip_interrupt(surface);*/
-}
-
struct dc_plane_state *dc_create_plane_state(const struct dc *dc)
{
struct dc_plane_state *plane_state = kvzalloc(sizeof(*plane_state),
diff --git a/drivers/gpu/drm/amd/display/dc/inc/core_types.h b/drivers/gpu/drm/amd/display/dc/inc/core_types.h
index bfb8b8502d20..f241316aff82 100644
--- a/drivers/gpu/drm/amd/display/dc/inc/core_types.h
+++ b/drivers/gpu/drm/amd/display/dc/inc/core_types.h
@@ -45,9 +45,6 @@
#define MAX_SVP_PHANTOM_STREAMS 2
#define MAX_SVP_PHANTOM_PLANES 2
-void enable_surface_flip_reporting(struct dc_plane_state *plane_state,
- uint32_t controller_id);
-
#include "grph_object_id.h"
#include "link_encoder.h"
#include "stream_encoder.h"
--
2.47.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 2/5] drm/amd/display: Remove unused dwb3_set_host_read_rate_control
2024-11-04 2:38 [PATCH 0/5] Some more drm/amd/display deadcoding linux
2024-11-04 2:38 ` [PATCH 1/5] drm/amd/display: Remove unused enable_surface_flip_reporting linux
@ 2024-11-04 2:38 ` linux
2024-11-04 2:38 ` [PATCH 3/5] drm/amd/display: Remove unused dc_stream_warmup_writeback linux
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: linux @ 2024-11-04 2:38 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
christian.koenig, Xinhui.Pan, chaitanya.dhere, jun.lei
Cc: airlied, simona, amd-gfx, dri-devel, linux-kernel,
Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
dwb3_set_host_read_rate_control() has been unused since it was added by
commit 8993dee0de2a ("drm/amd/display: Add DCN3 DWB")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
.../gpu/drm/amd/display/dc/dwb/dcn30/dcn30_dwb.c | 13 -------------
.../gpu/drm/amd/display/dc/dwb/dcn30/dcn30_dwb.h | 1 -
2 files changed, 14 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dwb/dcn30/dcn30_dwb.c b/drivers/gpu/drm/amd/display/dc/dwb/dcn30/dcn30_dwb.c
index fae98cf52020..bc058f682438 100644
--- a/drivers/gpu/drm/amd/display/dc/dwb/dcn30/dcn30_dwb.c
+++ b/drivers/gpu/drm/amd/display/dc/dwb/dcn30/dcn30_dwb.c
@@ -270,16 +270,3 @@ void dcn30_dwbc_construct(struct dcn30_dwbc *dwbc30,
dwbc30->dwbc_shift = dwbc_shift;
dwbc30->dwbc_mask = dwbc_mask;
}
-
-void dwb3_set_host_read_rate_control(struct dwbc *dwbc, bool host_read_delay)
-{
- struct dcn30_dwbc *dwbc30 = TO_DCN30_DWBC(dwbc);
-
- /*
- * Set maximum delay of host read access to DWBSCL LUT or OGAM LUT if there are no
- * idle cycles in HW pipeline (in number of clock cycles times 4)
- */
- REG_UPDATE(DWB_HOST_READ_CONTROL, DWB_HOST_READ_RATE_CONTROL, host_read_delay);
-
- DC_LOG_DWB("%s dwb3_rate_control at inst = %d", __func__, dwbc->inst);
-}
diff --git a/drivers/gpu/drm/amd/display/dc/dwb/dcn30/dcn30_dwb.h b/drivers/gpu/drm/amd/display/dc/dwb/dcn30/dcn30_dwb.h
index 0f3f7c5fbaec..7f053f49ec6a 100644
--- a/drivers/gpu/drm/amd/display/dc/dwb/dcn30/dcn30_dwb.h
+++ b/drivers/gpu/drm/amd/display/dc/dwb/dcn30/dcn30_dwb.h
@@ -914,7 +914,6 @@ bool dwb3_ogam_set_input_transfer_func(
struct dwbc *dwbc,
const struct dc_transfer_func *in_transfer_func_dwb_ogam);
-void dwb3_set_host_read_rate_control(struct dwbc *dwbc, bool host_read_delay);
#endif
--
2.47.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 3/5] drm/amd/display: Remove unused dc_stream_warmup_writeback
2024-11-04 2:38 [PATCH 0/5] Some more drm/amd/display deadcoding linux
2024-11-04 2:38 ` [PATCH 1/5] drm/amd/display: Remove unused enable_surface_flip_reporting linux
2024-11-04 2:38 ` [PATCH 2/5] drm/amd/display: Remove unused dwb3_set_host_read_rate_control linux
@ 2024-11-04 2:38 ` linux
2024-11-04 2:38 ` [PATCH 4/5] drm/amd/display: Remove unused mmhubbub_warmup field linux
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: linux @ 2024-11-04 2:38 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
christian.koenig, Xinhui.Pan, chaitanya.dhere, jun.lei
Cc: airlied, simona, amd-gfx, dri-devel, linux-kernel,
Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
dc_stream_warmup_writeback() is unused since it was added in 2019 by
commit 6a652f6d127d ("drm/amd/display: Add warmup escape call support")
Remove it.
Note there is a dcn30 version that's called directly which is kept.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 11 -----------
drivers/gpu/drm/amd/display/dc/dc_stream.h | 4 ----
2 files changed, 15 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
index 9a406d74c0dd..a05f8d7c4367 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_stream.c
@@ -612,17 +612,6 @@ bool dc_stream_remove_writeback(struct dc *dc,
return true;
}
-bool dc_stream_warmup_writeback(struct dc *dc,
- int num_dwb,
- struct dc_writeback_info *wb_info)
-{
- dc_exit_ips_for_hw_access(dc);
-
- if (dc->hwss.mmhubbub_warmup)
- return dc->hwss.mmhubbub_warmup(dc, num_dwb, wb_info);
- else
- return false;
-}
uint32_t dc_stream_get_vblank_counter(const struct dc_stream_state *stream)
{
uint8_t i;
diff --git a/drivers/gpu/drm/amd/display/dc/dc_stream.h b/drivers/gpu/drm/amd/display/dc/dc_stream.h
index 14ea47eda0c8..602e77560373 100644
--- a/drivers/gpu/drm/amd/display/dc/dc_stream.h
+++ b/drivers/gpu/drm/amd/display/dc/dc_stream.h
@@ -444,10 +444,6 @@ enum dc_status dc_stream_add_dsc_to_resource(struct dc *dc,
struct dc_state *state,
struct dc_stream_state *stream);
-bool dc_stream_warmup_writeback(struct dc *dc,
- int num_dwb,
- struct dc_writeback_info *wb_info);
-
bool dc_stream_dmdata_status_done(struct dc *dc, struct dc_stream_state *stream);
bool dc_stream_set_dynamic_metadata(struct dc *dc,
--
2.47.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 4/5] drm/amd/display: Remove unused mmhubbub_warmup field
2024-11-04 2:38 [PATCH 0/5] Some more drm/amd/display deadcoding linux
` (2 preceding siblings ...)
2024-11-04 2:38 ` [PATCH 3/5] drm/amd/display: Remove unused dc_stream_warmup_writeback linux
@ 2024-11-04 2:38 ` linux
2024-11-04 2:38 ` [PATCH 5/5] drm/amd/display: Remove unused dcn_find_dcfclk_suits_all linux
2024-12-06 2:27 ` [PATCH 0/5] Some more drm/amd/display deadcoding Dr. David Alan Gilbert
5 siblings, 0 replies; 8+ messages in thread
From: linux @ 2024-11-04 2:38 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
christian.koenig, Xinhui.Pan, chaitanya.dhere, jun.lei
Cc: airlied, simona, amd-gfx, dri-devel, linux-kernel,
Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
mmhubbub_warmup is a field that was only read by the just removed
dc_stream_warmup_writeback() function.
Remove the field and it's initialisers.
It was only ever initialised to a single function value
(dcn30_mmhubbub_warmup) which is called explicitly elsewhere.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_init.c | 1 -
drivers/gpu/drm/amd/display/dc/hwss/dcn301/dcn301_init.c | 1 -
drivers/gpu/drm/amd/display/dc/hwss/dcn31/dcn31_init.c | 1 -
drivers/gpu/drm/amd/display/dc/hwss/dcn314/dcn314_init.c | 1 -
drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_init.c | 1 -
drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_init.c | 1 -
drivers/gpu/drm/amd/display/dc/hwss/dcn351/dcn351_init.c | 1 -
drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_init.c | 1 -
drivers/gpu/drm/amd/display/dc/hwss/hw_sequencer.h | 4 ----
9 files changed, 12 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_init.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_init.c
index 2a8dc40d2847..41c30478439a 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_init.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn30/dcn30_init.c
@@ -86,7 +86,6 @@ static const struct hw_sequencer_funcs dcn30_funcs = {
.enable_writeback = dcn30_enable_writeback,
.disable_writeback = dcn30_disable_writeback,
.update_writeback = dcn30_update_writeback,
- .mmhubbub_warmup = dcn30_mmhubbub_warmup,
.dmdata_status_done = dcn20_dmdata_status_done,
.program_dmdata_engine = dcn30_program_dmdata_engine,
.set_dmdata_attributes = dcn20_set_dmdata_attributes,
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn301/dcn301_init.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn301/dcn301_init.c
index 93e49d87a67c..99870fbbb424 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn301/dcn301_init.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn301/dcn301_init.c
@@ -86,7 +86,6 @@ static const struct hw_sequencer_funcs dcn301_funcs = {
.enable_writeback = dcn30_enable_writeback,
.disable_writeback = dcn30_disable_writeback,
.update_writeback = dcn30_update_writeback,
- .mmhubbub_warmup = dcn30_mmhubbub_warmup,
.dmdata_status_done = dcn20_dmdata_status_done,
.program_dmdata_engine = dcn30_program_dmdata_engine,
.set_dmdata_attributes = dcn20_set_dmdata_attributes,
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn31/dcn31_init.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn31/dcn31_init.c
index 56f3c70d4b55..fb2ffb637931 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn31/dcn31_init.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn31/dcn31_init.c
@@ -89,7 +89,6 @@ static const struct hw_sequencer_funcs dcn31_funcs = {
.enable_writeback = dcn30_enable_writeback,
.disable_writeback = dcn30_disable_writeback,
.update_writeback = dcn30_update_writeback,
- .mmhubbub_warmup = dcn30_mmhubbub_warmup,
.dmdata_status_done = dcn20_dmdata_status_done,
.program_dmdata_engine = dcn30_program_dmdata_engine,
.set_dmdata_attributes = dcn20_set_dmdata_attributes,
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn314/dcn314_init.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn314/dcn314_init.c
index 68e6de6b5758..21ef03a76229 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn314/dcn314_init.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn314/dcn314_init.c
@@ -91,7 +91,6 @@ static const struct hw_sequencer_funcs dcn314_funcs = {
.enable_writeback = dcn30_enable_writeback,
.disable_writeback = dcn30_disable_writeback,
.update_writeback = dcn30_update_writeback,
- .mmhubbub_warmup = dcn30_mmhubbub_warmup,
.dmdata_status_done = dcn20_dmdata_status_done,
.program_dmdata_engine = dcn30_program_dmdata_engine,
.set_dmdata_attributes = dcn20_set_dmdata_attributes,
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_init.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_init.c
index 3422b564ae98..bcaaf98cade7 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_init.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn32/dcn32_init.c
@@ -87,7 +87,6 @@ static const struct hw_sequencer_funcs dcn32_funcs = {
.enable_writeback = dcn30_enable_writeback,
.disable_writeback = dcn30_disable_writeback,
.update_writeback = dcn30_update_writeback,
- .mmhubbub_warmup = dcn30_mmhubbub_warmup,
.dmdata_status_done = dcn20_dmdata_status_done,
.program_dmdata_engine = dcn30_program_dmdata_engine,
.set_dmdata_attributes = dcn20_set_dmdata_attributes,
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_init.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_init.c
index 2bbf1fef94fd..ab20c47e6d6e 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_init.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_init.c
@@ -92,7 +92,6 @@ static const struct hw_sequencer_funcs dcn35_funcs = {
.enable_writeback = dcn30_enable_writeback,
.disable_writeback = dcn30_disable_writeback,
.update_writeback = dcn30_update_writeback,
- .mmhubbub_warmup = dcn30_mmhubbub_warmup,
.dmdata_status_done = dcn20_dmdata_status_done,
.program_dmdata_engine = dcn30_program_dmdata_engine,
.set_dmdata_attributes = dcn20_set_dmdata_attributes,
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn351/dcn351_init.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn351/dcn351_init.c
index d00822e8daa5..ba7ff8f97d49 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn351/dcn351_init.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn351/dcn351_init.c
@@ -91,7 +91,6 @@ static const struct hw_sequencer_funcs dcn351_funcs = {
.enable_writeback = dcn30_enable_writeback,
.disable_writeback = dcn30_disable_writeback,
.update_writeback = dcn30_update_writeback,
- .mmhubbub_warmup = dcn30_mmhubbub_warmup,
.dmdata_status_done = dcn20_dmdata_status_done,
.program_dmdata_engine = dcn30_program_dmdata_engine,
.set_dmdata_attributes = dcn20_set_dmdata_attributes,
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_init.c b/drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_init.c
index a2ca07235c83..d6dabcb8f4fe 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_init.c
+++ b/drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_init.c
@@ -66,7 +66,6 @@ static const struct hw_sequencer_funcs dcn401_funcs = {
.enable_writeback = dcn30_enable_writeback,
.disable_writeback = dcn30_disable_writeback,
.update_writeback = dcn30_update_writeback,
- .mmhubbub_warmup = dcn30_mmhubbub_warmup,
.dmdata_status_done = dcn20_dmdata_status_done,
.program_dmdata_engine = dcn30_program_dmdata_engine,
.set_dmdata_attributes = dcn20_set_dmdata_attributes,
diff --git a/drivers/gpu/drm/amd/display/dc/hwss/hw_sequencer.h b/drivers/gpu/drm/amd/display/dc/hwss/hw_sequencer.h
index ac9205625623..5d1a83769136 100644
--- a/drivers/gpu/drm/amd/display/dc/hwss/hw_sequencer.h
+++ b/drivers/gpu/drm/amd/display/dc/hwss/hw_sequencer.h
@@ -331,10 +331,6 @@ struct hw_sequencer_funcs {
void (*disable_writeback)(struct dc *dc,
unsigned int dwb_pipe_inst);
- bool (*mmhubbub_warmup)(struct dc *dc,
- unsigned int num_dwb,
- struct dc_writeback_info *wb_info);
-
/* Clock Related */
enum dc_status (*set_clock)(struct dc *dc,
enum dc_clock_type clock_type,
--
2.47.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH 5/5] drm/amd/display: Remove unused dcn_find_dcfclk_suits_all
2024-11-04 2:38 [PATCH 0/5] Some more drm/amd/display deadcoding linux
` (3 preceding siblings ...)
2024-11-04 2:38 ` [PATCH 4/5] drm/amd/display: Remove unused mmhubbub_warmup field linux
@ 2024-11-04 2:38 ` linux
2024-12-06 2:27 ` [PATCH 0/5] Some more drm/amd/display deadcoding Dr. David Alan Gilbert
5 siblings, 0 replies; 8+ messages in thread
From: linux @ 2024-11-04 2:38 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
christian.koenig, Xinhui.Pan, chaitanya.dhere, jun.lei
Cc: airlied, simona, amd-gfx, dri-devel, linux-kernel,
Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
dcn_find_dcfclk_suits_all() last use was removed by 2018's
commit 4fd994c448a3 ("drm/amd/display: Start using the new pp_smu
interface")
Remove it, and the dcn_find_normalized_clock_vdd_Level helper it used.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
.../drm/amd/display/dc/dml/calcs/dcn_calcs.c | 132 ------------------
.../gpu/drm/amd/display/dc/inc/dcn_calcs.h | 4 -
2 files changed, 136 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.c b/drivers/gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.c
index 39525721c976..f1235bf9a596 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/calcs/dcn_calcs.c
@@ -1312,138 +1312,6 @@ bool dcn_validate_bandwidth(
return false;
}
-static unsigned int dcn_find_normalized_clock_vdd_Level(
- const struct dc *dc,
- enum dm_pp_clock_type clocks_type,
- int clocks_in_khz)
-{
- int vdd_level = dcn_bw_v_min0p65;
-
- if (clocks_in_khz == 0)/*todo some clock not in the considerations*/
- return vdd_level;
-
- switch (clocks_type) {
- case DM_PP_CLOCK_TYPE_DISPLAY_CLK:
- if (clocks_in_khz > dc->dcn_soc->max_dispclk_vmax0p9*1000) {
- vdd_level = dcn_bw_v_max0p91;
- BREAK_TO_DEBUGGER();
- } else if (clocks_in_khz > dc->dcn_soc->max_dispclk_vnom0p8*1000) {
- vdd_level = dcn_bw_v_max0p9;
- } else if (clocks_in_khz > dc->dcn_soc->max_dispclk_vmid0p72*1000) {
- vdd_level = dcn_bw_v_nom0p8;
- } else if (clocks_in_khz > dc->dcn_soc->max_dispclk_vmin0p65*1000) {
- vdd_level = dcn_bw_v_mid0p72;
- } else
- vdd_level = dcn_bw_v_min0p65;
- break;
- case DM_PP_CLOCK_TYPE_DISPLAYPHYCLK:
- if (clocks_in_khz > dc->dcn_soc->phyclkv_max0p9*1000) {
- vdd_level = dcn_bw_v_max0p91;
- BREAK_TO_DEBUGGER();
- } else if (clocks_in_khz > dc->dcn_soc->phyclkv_nom0p8*1000) {
- vdd_level = dcn_bw_v_max0p9;
- } else if (clocks_in_khz > dc->dcn_soc->phyclkv_mid0p72*1000) {
- vdd_level = dcn_bw_v_nom0p8;
- } else if (clocks_in_khz > dc->dcn_soc->phyclkv_min0p65*1000) {
- vdd_level = dcn_bw_v_mid0p72;
- } else
- vdd_level = dcn_bw_v_min0p65;
- break;
-
- case DM_PP_CLOCK_TYPE_DPPCLK:
- if (clocks_in_khz > dc->dcn_soc->max_dppclk_vmax0p9*1000) {
- vdd_level = dcn_bw_v_max0p91;
- BREAK_TO_DEBUGGER();
- } else if (clocks_in_khz > dc->dcn_soc->max_dppclk_vnom0p8*1000) {
- vdd_level = dcn_bw_v_max0p9;
- } else if (clocks_in_khz > dc->dcn_soc->max_dppclk_vmid0p72*1000) {
- vdd_level = dcn_bw_v_nom0p8;
- } else if (clocks_in_khz > dc->dcn_soc->max_dppclk_vmin0p65*1000) {
- vdd_level = dcn_bw_v_mid0p72;
- } else
- vdd_level = dcn_bw_v_min0p65;
- break;
-
- case DM_PP_CLOCK_TYPE_MEMORY_CLK:
- {
- unsigned factor = (ddr4_dram_factor_single_Channel * dc->dcn_soc->number_of_channels);
-
- if (clocks_in_khz > dc->dcn_soc->fabric_and_dram_bandwidth_vmax0p9*1000000/factor) {
- vdd_level = dcn_bw_v_max0p91;
- BREAK_TO_DEBUGGER();
- } else if (clocks_in_khz > dc->dcn_soc->fabric_and_dram_bandwidth_vnom0p8*1000000/factor) {
- vdd_level = dcn_bw_v_max0p9;
- } else if (clocks_in_khz > dc->dcn_soc->fabric_and_dram_bandwidth_vmid0p72*1000000/factor) {
- vdd_level = dcn_bw_v_nom0p8;
- } else if (clocks_in_khz > dc->dcn_soc->fabric_and_dram_bandwidth_vmin0p65*1000000/factor) {
- vdd_level = dcn_bw_v_mid0p72;
- } else
- vdd_level = dcn_bw_v_min0p65;
- }
- break;
-
- case DM_PP_CLOCK_TYPE_DCFCLK:
- if (clocks_in_khz > dc->dcn_soc->dcfclkv_max0p9*1000) {
- vdd_level = dcn_bw_v_max0p91;
- BREAK_TO_DEBUGGER();
- } else if (clocks_in_khz > dc->dcn_soc->dcfclkv_nom0p8*1000) {
- vdd_level = dcn_bw_v_max0p9;
- } else if (clocks_in_khz > dc->dcn_soc->dcfclkv_mid0p72*1000) {
- vdd_level = dcn_bw_v_nom0p8;
- } else if (clocks_in_khz > dc->dcn_soc->dcfclkv_min0p65*1000) {
- vdd_level = dcn_bw_v_mid0p72;
- } else
- vdd_level = dcn_bw_v_min0p65;
- break;
-
- default:
- break;
- }
- return vdd_level;
-}
-
-unsigned int dcn_find_dcfclk_suits_all(
- const struct dc *dc,
- struct dc_clocks *clocks)
-{
- unsigned vdd_level, vdd_level_temp;
- unsigned dcf_clk;
-
- /*find a common supported voltage level*/
- vdd_level = dcn_find_normalized_clock_vdd_Level(
- dc, DM_PP_CLOCK_TYPE_DISPLAY_CLK, clocks->dispclk_khz);
- vdd_level_temp = dcn_find_normalized_clock_vdd_Level(
- dc, DM_PP_CLOCK_TYPE_DISPLAYPHYCLK, clocks->phyclk_khz);
-
- vdd_level = dcn_bw_max(vdd_level, vdd_level_temp);
- vdd_level_temp = dcn_find_normalized_clock_vdd_Level(
- dc, DM_PP_CLOCK_TYPE_DPPCLK, clocks->dppclk_khz);
- vdd_level = dcn_bw_max(vdd_level, vdd_level_temp);
-
- vdd_level_temp = dcn_find_normalized_clock_vdd_Level(
- dc, DM_PP_CLOCK_TYPE_MEMORY_CLK, clocks->fclk_khz);
- vdd_level = dcn_bw_max(vdd_level, vdd_level_temp);
- vdd_level_temp = dcn_find_normalized_clock_vdd_Level(
- dc, DM_PP_CLOCK_TYPE_DCFCLK, clocks->dcfclk_khz);
-
- /*find that level conresponding dcfclk*/
- vdd_level = dcn_bw_max(vdd_level, vdd_level_temp);
- if (vdd_level == dcn_bw_v_max0p91) {
- BREAK_TO_DEBUGGER();
- dcf_clk = dc->dcn_soc->dcfclkv_max0p9*1000;
- } else if (vdd_level == dcn_bw_v_max0p9)
- dcf_clk = dc->dcn_soc->dcfclkv_max0p9*1000;
- else if (vdd_level == dcn_bw_v_nom0p8)
- dcf_clk = dc->dcn_soc->dcfclkv_nom0p8*1000;
- else if (vdd_level == dcn_bw_v_mid0p72)
- dcf_clk = dc->dcn_soc->dcfclkv_mid0p72*1000;
- else
- dcf_clk = dc->dcn_soc->dcfclkv_min0p65*1000;
-
- DC_LOG_BANDWIDTH_CALCS("\tdcf_clk for voltage = %d\n", dcf_clk);
- return dcf_clk;
-}
-
void dcn_bw_update_from_pplib_fclks(
struct dc *dc,
struct dm_pp_clock_levels_with_voltage *fclks)
diff --git a/drivers/gpu/drm/amd/display/dc/inc/dcn_calcs.h b/drivers/gpu/drm/amd/display/dc/inc/dcn_calcs.h
index 55529c5f471c..d19a595c2be4 100644
--- a/drivers/gpu/drm/amd/display/dc/inc/dcn_calcs.h
+++ b/drivers/gpu/drm/amd/display/dc/inc/dcn_calcs.h
@@ -624,10 +624,6 @@ bool dcn_validate_bandwidth(
struct dc_state *context,
bool fast_validate);
-unsigned int dcn_find_dcfclk_suits_all(
- const struct dc *dc,
- struct dc_clocks *clocks);
-
void dcn_get_soc_clks(
struct dc *dc,
int *min_fclk_khz,
--
2.47.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 0/5] Some more drm/amd/display deadcoding
2024-11-04 2:38 [PATCH 0/5] Some more drm/amd/display deadcoding linux
` (4 preceding siblings ...)
2024-11-04 2:38 ` [PATCH 5/5] drm/amd/display: Remove unused dcn_find_dcfclk_suits_all linux
@ 2024-12-06 2:27 ` Dr. David Alan Gilbert
2024-12-09 20:56 ` Alex Deucher
5 siblings, 1 reply; 8+ messages in thread
From: Dr. David Alan Gilbert @ 2024-12-06 2:27 UTC (permalink / raw)
To: alexander.deucher, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
christian.koenig, Xinhui.Pan, chaitanya.dhere, jun.lei
Cc: airlied, simona, amd-gfx, dri-devel, linux-kernel
* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> Hi,
> This removes a bunch more functions (and a field) from
> drm/amd/display that are unused.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Hi Alex, Harry,
Gentle ping on this set - I think you've already pulled in all
of the older ones (Thanks!).
Dave
> Dave
>
> Dr. David Alan Gilbert (5):
> drm/amd/display: Remove unused enable_surface_flip_reporting
> drm/amd/display: Remove unused dwb3_set_host_read_rate_control
> drm/amd/display: Remove unused dc_stream_warmup_writeback
> drm/amd/display: Remove unused mmhubbub_warmup field
> drm/amd/display: Remove unused dcn_find_dcfclk_suits_all
>
> .../gpu/drm/amd/display/dc/core/dc_stream.c | 11 --
> .../gpu/drm/amd/display/dc/core/dc_surface.c | 7 -
> drivers/gpu/drm/amd/display/dc/dc_stream.h | 4 -
> .../drm/amd/display/dc/dml/calcs/dcn_calcs.c | 132 ------------------
> .../drm/amd/display/dc/dwb/dcn30/dcn30_dwb.c | 13 --
> .../drm/amd/display/dc/dwb/dcn30/dcn30_dwb.h | 1 -
> .../amd/display/dc/hwss/dcn30/dcn30_init.c | 1 -
> .../amd/display/dc/hwss/dcn301/dcn301_init.c | 1 -
> .../amd/display/dc/hwss/dcn31/dcn31_init.c | 1 -
> .../amd/display/dc/hwss/dcn314/dcn314_init.c | 1 -
> .../amd/display/dc/hwss/dcn32/dcn32_init.c | 1 -
> .../amd/display/dc/hwss/dcn35/dcn35_init.c | 1 -
> .../amd/display/dc/hwss/dcn351/dcn351_init.c | 1 -
> .../amd/display/dc/hwss/dcn401/dcn401_init.c | 1 -
> .../drm/amd/display/dc/hwss/hw_sequencer.h | 4 -
> .../gpu/drm/amd/display/dc/inc/core_types.h | 3 -
> .../gpu/drm/amd/display/dc/inc/dcn_calcs.h | 4 -
> 17 files changed, 187 deletions(-)
>
> --
> 2.47.0
>
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 0/5] Some more drm/amd/display deadcoding
2024-12-06 2:27 ` [PATCH 0/5] Some more drm/amd/display deadcoding Dr. David Alan Gilbert
@ 2024-12-09 20:56 ` Alex Deucher
0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2024-12-09 20:56 UTC (permalink / raw)
To: Dr. David Alan Gilbert
Cc: alexander.deucher, harry.wentland, sunpeng.li, Rodrigo.Siqueira,
christian.koenig, Xinhui.Pan, chaitanya.dhere, jun.lei, airlied,
simona, amd-gfx, dri-devel, linux-kernel
On Thu, Dec 5, 2024 at 9:35 PM Dr. David Alan Gilbert <linux@treblig.org> wrote:
>
> * linux@treblig.org (linux@treblig.org) wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> >
> > Hi,
> > This removes a bunch more functions (and a field) from
> > drm/amd/display that are unused.
> >
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
>
> Hi Alex, Harry,
> Gentle ping on this set - I think you've already pulled in all
> of the older ones (Thanks!).
Applied. Thanks!
Alex
>
> Dave
>
> > Dave
> >
> > Dr. David Alan Gilbert (5):
> > drm/amd/display: Remove unused enable_surface_flip_reporting
> > drm/amd/display: Remove unused dwb3_set_host_read_rate_control
> > drm/amd/display: Remove unused dc_stream_warmup_writeback
> > drm/amd/display: Remove unused mmhubbub_warmup field
> > drm/amd/display: Remove unused dcn_find_dcfclk_suits_all
> >
> > .../gpu/drm/amd/display/dc/core/dc_stream.c | 11 --
> > .../gpu/drm/amd/display/dc/core/dc_surface.c | 7 -
> > drivers/gpu/drm/amd/display/dc/dc_stream.h | 4 -
> > .../drm/amd/display/dc/dml/calcs/dcn_calcs.c | 132 ------------------
> > .../drm/amd/display/dc/dwb/dcn30/dcn30_dwb.c | 13 --
> > .../drm/amd/display/dc/dwb/dcn30/dcn30_dwb.h | 1 -
> > .../amd/display/dc/hwss/dcn30/dcn30_init.c | 1 -
> > .../amd/display/dc/hwss/dcn301/dcn301_init.c | 1 -
> > .../amd/display/dc/hwss/dcn31/dcn31_init.c | 1 -
> > .../amd/display/dc/hwss/dcn314/dcn314_init.c | 1 -
> > .../amd/display/dc/hwss/dcn32/dcn32_init.c | 1 -
> > .../amd/display/dc/hwss/dcn35/dcn35_init.c | 1 -
> > .../amd/display/dc/hwss/dcn351/dcn351_init.c | 1 -
> > .../amd/display/dc/hwss/dcn401/dcn401_init.c | 1 -
> > .../drm/amd/display/dc/hwss/hw_sequencer.h | 4 -
> > .../gpu/drm/amd/display/dc/inc/core_types.h | 3 -
> > .../gpu/drm/amd/display/dc/inc/dcn_calcs.h | 4 -
> > 17 files changed, 187 deletions(-)
> >
> > --
> > 2.47.0
> >
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ dave @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org |_______/
^ permalink raw reply [flat|nested] 8+ messages in thread