Re: [PATCH v3 3/3] power: reset: nvmem-reboot-mode: fix write for small cells

Sebastian Reichel
2024-11-11T22:07:23Z

[-- Attachment #1: Type: text/plain, Size: 1334 bytes --]

Hi,

On Mon, Nov 04, 2024 at 10:23:12AM -0500, Jennifer Berringer wrote:
> Some devices, such as Qualcomm sa8775p, have an nvmem reboot mode cell
> that is smaller than 32 bits, which resulted in
> nvmem_reboot_mode_write() failing. Using nvmem_cell_write_variable_u32()
> fixes this by writing only the least-significant byte of the magic value
> when the size specified in device tree is only one byte.
>
> Signed-off-by: Jennifer Berringer <jberring@redhat.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> drivers/power/reset/nvmem-reboot-mode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/nvmem-reboot-mode.c b/drivers/power/reset/nvmem-reboot-mode.c
> index 41530b70cfc4..b52eb879d1c1 100644
> --- a/drivers/power/reset/nvmem-reboot-mode.c
> +++ b/drivers/power/reset/nvmem-reboot-mode.c
> @@ -24,7 +24,7 @@ static int nvmem_reboot_mode_write(struct reboot_mode_driver *reboot,
>
> nvmem_rbm = container_of(reboot, struct nvmem_reboot_mode, reboot);
>
> - ret = nvmem_cell_write(nvmem_rbm->cell, &magic, sizeof(magic));
> + ret = nvmem_cell_write_variable_u32(nvmem_rbm->cell, magic);
> if (ret < 0)
> dev_err(reboot->dev, "update reboot mode bits failed\n");
>
> --
> 2.46.2
>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]