public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] irqchip/stm32mp-exti: Use of_property_present() for non-boolean properties
@ 2024-11-04 19:08 Rob Herring (Arm)
  2024-11-05  8:23 ` [Linux-stm32] " Antonio Borneo
  2024-11-06 23:32 ` [tip: irq/core] " tip-bot2 for Rob Herring (Arm)
  0 siblings, 2 replies; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-11-04 19:08 UTC (permalink / raw)
  To: Thomas Gleixner, Maxime Coquelin, Alexandre Torgue
  Cc: linux-kernel, linux-stm32, linux-arm-kernel

The use of of_property_read_bool() for non-boolean properties is
deprecated in favor of of_property_present() when testing for property
presence.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 drivers/irqchip/irq-stm32mp-exti.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-stm32mp-exti.c b/drivers/irqchip/irq-stm32mp-exti.c
index 33e0cfdea654..cb83d6cc6113 100644
--- a/drivers/irqchip/irq-stm32mp-exti.c
+++ b/drivers/irqchip/irq-stm32mp-exti.c
@@ -696,8 +696,7 @@ static int stm32mp_exti_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	if (of_property_read_bool(np, "interrupts-extended"))
-		host_data->dt_has_irqs_desc = true;
+	host_data->dt_has_irqs_desc = of_property_present(np, "interrupts-extended");
 
 	return 0;
 }
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Linux-stm32] [PATCH] irqchip/stm32mp-exti: Use of_property_present() for non-boolean properties
  2024-11-04 19:08 [PATCH] irqchip/stm32mp-exti: Use of_property_present() for non-boolean properties Rob Herring (Arm)
@ 2024-11-05  8:23 ` Antonio Borneo
  2024-11-06 23:32 ` [tip: irq/core] " tip-bot2 for Rob Herring (Arm)
  1 sibling, 0 replies; 3+ messages in thread
From: Antonio Borneo @ 2024-11-05  8:23 UTC (permalink / raw)
  To: Rob Herring (Arm), Thomas Gleixner, Maxime Coquelin,
	Alexandre Torgue
  Cc: linux-kernel, linux-arm-kernel, linux-stm32

On Mon, 2024-11-04 at 13:08 -0600, Rob Herring (Arm) wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
>  drivers/irqchip/irq-stm32mp-exti.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-stm32mp-exti.c b/drivers/irqchip/irq-stm32mp-exti.c
> index 33e0cfdea654..cb83d6cc6113 100644
> --- a/drivers/irqchip/irq-stm32mp-exti.c
> +++ b/drivers/irqchip/irq-stm32mp-exti.c
> @@ -696,8 +696,7 @@ static int stm32mp_exti_probe(struct platform_device *pdev)
>         if (ret)
>                 return ret;
>  
> -       if (of_property_read_bool(np, "interrupts-extended"))
> -               host_data->dt_has_irqs_desc = true;
> +       host_data->dt_has_irqs_desc = of_property_present(np, "interrupts-extended");
>  
>         return 0;
>  }

Reviewed-by: Antonio Borneo <antonio.borneo@foss.st.com>

Thanks,
Antonio

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip: irq/core] irqchip/stm32mp-exti: Use of_property_present() for non-boolean properties
  2024-11-04 19:08 [PATCH] irqchip/stm32mp-exti: Use of_property_present() for non-boolean properties Rob Herring (Arm)
  2024-11-05  8:23 ` [Linux-stm32] " Antonio Borneo
@ 2024-11-06 23:32 ` tip-bot2 for Rob Herring (Arm)
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot2 for Rob Herring (Arm) @ 2024-11-06 23:32 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: Rob Herring (Arm), Thomas Gleixner, Antonio Borneo, x86,
	linux-kernel, maz

The following commit has been merged into the irq/core branch of tip:

Commit-ID:     194c4f569eac889d9b0822bc001771683b6e9b8a
Gitweb:        https://git.kernel.org/tip/194c4f569eac889d9b0822bc001771683b6e9b8a
Author:        Rob Herring (Arm) <robh@kernel.org>
AuthorDate:    Mon, 04 Nov 2024 13:08:35 -06:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Thu, 07 Nov 2024 00:23:59 +01:00

irqchip/stm32mp-exti: Use of_property_present() for non-boolean properties

The use of of_property_read_bool() for non-boolean properties is deprecated
in favor of of_property_present() when testing for property presence.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Antonio Borneo <antonio.borneo@foss.st.com>
Link: https://lore.kernel.org/all/20241104190836.278117-1-robh@kernel.org
---
 drivers/irqchip/irq-stm32mp-exti.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-stm32mp-exti.c b/drivers/irqchip/irq-stm32mp-exti.c
index 33e0cfd..cb83d6c 100644
--- a/drivers/irqchip/irq-stm32mp-exti.c
+++ b/drivers/irqchip/irq-stm32mp-exti.c
@@ -696,8 +696,7 @@ static int stm32mp_exti_probe(struct platform_device *pdev)
 	if (ret)
 		return ret;
 
-	if (of_property_read_bool(np, "interrupts-extended"))
-		host_data->dt_has_irqs_desc = true;
+	host_data->dt_has_irqs_desc = of_property_present(np, "interrupts-extended");
 
 	return 0;
 }

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-11-06 23:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-04 19:08 [PATCH] irqchip/stm32mp-exti: Use of_property_present() for non-boolean properties Rob Herring (Arm)
2024-11-05  8:23 ` [Linux-stm32] " Antonio Borneo
2024-11-06 23:32 ` [tip: irq/core] " tip-bot2 for Rob Herring (Arm)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox